| Message ID | 1499270189-29945-3-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ff53e6064fd8badaf52ce5c13eeefd84c2e14332 |
| Delegated to: | Simon Horman |
| Headers | show |
Hello! On 07/05/2017 06:56 PM, Biju Das wrote: > The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel KSZ9031MNX). > Gigabit Ethernet support is available in Renesas AVB driver. > To increase hardware support enable the driver in the shmobile_defconfig > multiplatform configuration. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > arch/arm/configs/shmobile_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig > index 3c66a42..d992911 100644 > --- a/arch/arm/configs/shmobile_defconfig > +++ b/arch/arm/configs/shmobile_defconfig > @@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y > # CONFIG_NET_VENDOR_MICREL is not set > # CONFIG_NET_VENDOR_NATSEMI is not set > CONFIG_SH_ETH=y > +CONFIG_RAVB=y Hm, I would enable it only as a module, given it's not easy to make use of AVB on the 32-bit boards. [...] MBR Sergei
Hello Sergei, Thank you for your comments. > From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com] > Sent: 05 July 2017 17:14 > > Hello! > > On 07/05/2017 06:56 PM, Biju Das wrote: > > > The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel > KSZ9031MNX). > > Gigabit Ethernet support is available in Renesas AVB driver. > > To increase hardware support enable the driver in the > > shmobile_defconfig multiplatform configuration. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > arch/arm/configs/shmobile_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/configs/shmobile_defconfig > > b/arch/arm/configs/shmobile_defconfig > > index 3c66a42..d992911 100644 > > --- a/arch/arm/configs/shmobile_defconfig > > +++ b/arch/arm/configs/shmobile_defconfig > > @@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y > > # CONFIG_NET_VENDOR_MICREL is not set # > CONFIG_NET_VENDOR_NATSEMI is > > not set CONFIG_SH_ETH=y > > +CONFIG_RAVB=y > > Hm, I would enable it only as a module, given it's not easy to make use of > AVB on the 32-bit boards. On the iWave-M platforms the only available Ethernet interface is AVB. Without including the RAVB driver in the Kernel we won't be able to use NFS. I know adding CONFIG_RAVB for all shmobile devices may increase the Kernel size for everyone, especially when most cannot use AVB without an add-on board, but I don't think the increase will be big. Kind regards, Chris > > [...] > > MBR Sergei
On Thu, Jul 06, 2017 at 08:05:43AM +0000, Chris Paterson wrote: > Hello Sergei, > > Thank you for your comments. > > > From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com] > > Sent: 05 July 2017 17:14 > > > > Hello! > > > > On 07/05/2017 06:56 PM, Biju Das wrote: > > > > > The iWave RZ/G1M Q7 SOM supports Gigabit Ethernet Phy (Micrel > > KSZ9031MNX). > > > Gigabit Ethernet support is available in Renesas AVB driver. > > > To increase hardware support enable the driver in the > > > shmobile_defconfig multiplatform configuration. > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- > > > arch/arm/configs/shmobile_defconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm/configs/shmobile_defconfig > > > b/arch/arm/configs/shmobile_defconfig > > > index 3c66a42..d992911 100644 > > > --- a/arch/arm/configs/shmobile_defconfig > > > +++ b/arch/arm/configs/shmobile_defconfig > > > @@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y > > > # CONFIG_NET_VENDOR_MICREL is not set # > > CONFIG_NET_VENDOR_NATSEMI is > > > not set CONFIG_SH_ETH=y > > > +CONFIG_RAVB=y > > > > Hm, I would enable it only as a module, given it's not easy to make use of > > AVB on the 32-bit boards. > > On the iWave-M platforms the only available Ethernet interface is AVB. > Without including the RAVB driver in the Kernel we won't be able to use > NFS. > > I know adding CONFIG_RAVB for all shmobile devices may increase the > Kernel size for everyone, especially when most cannot use AVB without an > add-on board, but I don't think the increase will be big. Thanks for the explanation, applied for v4.14.
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig index 3c66a42..d992911 100644 --- a/arch/arm/configs/shmobile_defconfig +++ b/arch/arm/configs/shmobile_defconfig @@ -83,6 +83,7 @@ CONFIG_NETDEVICES=y # CONFIG_NET_VENDOR_MICREL is not set # CONFIG_NET_VENDOR_NATSEMI is not set CONFIG_SH_ETH=y +CONFIG_RAVB=y # CONFIG_NET_VENDOR_SEEQ is not set CONFIG_SMSC911X=y # CONFIG_NET_VENDOR_STMICRO is not set