| Message ID | 1499700776-54504-1-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Mon, Jul 10, 2017 at 5:32 PM, Biju Das <biju.das@bp.renesas.com> wrote: > Add a new compatible string for the RZ/G1M (R8A7743) SoC. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Mon, Jul 10, 2017 at 05:51:09PM +0200, Geert Uytterhoeven wrote: > On Mon, Jul 10, 2017 at 5:32 PM, Biju Das <biju.das@bp.renesas.com> wrote: > > Add a new compatible string for the RZ/G1M (R8A7743) SoC. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> I believe that as net-next is currently closed you should repost it once it re-opens (likely in about a week) with the following subject prefix and Geert's tag. [PATCH net-next repost v2]
Hello! On 07/10/2017 06:32 PM, Biju Das wrote: > Add a new compatible string for the RZ/G1M (R8A7743) SoC. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > --- > v1->v2 > * Changed the subject > * re-formatted the required properties > > .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++--------- > 1 file changed, 17 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt > index b519503..4717bc2 100644 > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt > @@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB > interface contains. > > Required properties: > -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC. > - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC. > - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC. > - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC. > - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC. > - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC. > - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC. > - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface. > - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface. > +- compatible: Must contain one or more of the following: No, it can't contain more than one SoC specific value. > + - "renesas,etheravb-r8a7743" for the R8A7743 SoC. > + - "renesas,etheravb-r8a7790" for the R8A7790 SoC. > + - "renesas,etheravb-r8a7791" for the R8A7791 SoC. > + - "renesas,etheravb-r8a7792" for the R8A7792 SoC. > + - "renesas,etheravb-r8a7793" for the R8A7793 SoC. > + - "renesas,etheravb-r8a7794" for the R8A7794 SoC. > + - "renesas,etheravb-rcar-gen2" as a fallback for the above > + R-Car Gen2 and RZ/G1 devices. > > - When compatible with the generic version, nodes must list the > - SoC-specific version corresponding to the platform first > - followed by the generic version. > + - "renesas,etheravb-r8a7795" for the R8A7795 SoC. > + - "renesas,etheravb-r8a7796" for the R8A7796 SoC. Neither here. > + - "renesas,etheravb-rcar-gen3" as a fallback for the above > + R-Car Gen3 devices. > + > + When compatible with the generic version, nodes must list the > + SoC-specific version corresponding to the platform first followed by > + the generic version. > > - reg: offset and length of (1) the register block and (2) the stream buffer. > - interrupts: A list of interrupt-specifiers, one for each entry in WBR, Sergei
Hello Sergei, > From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com] > Sent: 11 July 2017 13:12 > > Hello! > > On 07/10/2017 06:32 PM, Biju Das wrote: > > > Add a new compatible string for the RZ/G1M (R8A7743) SoC. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > --- > > v1->v2 > > * Changed the subject > > * re-formatted the required properties > > > > .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++------ > --- > > 1 file changed, 17 insertions(+), 12 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt > > b/Documentation/devicetree/bindings/net/renesas,ravb.txt > > index b519503..4717bc2 100644 > > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt > > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt > > @@ -4,19 +4,24 @@ This file provides information on what the device > > node for the Ethernet AVB interface contains. > > > > Required properties: > > -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 > SoC. > > - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC. > > - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC. > > - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC. > > - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC. > > - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC. > > - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC. > > - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible > interface. > > - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible > interface. > > +- compatible: Must contain one or more of the following: > > No, it can't contain more than one SoC specific value. Surely it can contain both "renesas,etheravb-r8a7743" and "renesas,etheravb-rcar-gen2" for example? As indeed dictated by the instruction further down: > > + When compatible with the generic version, nodes must list the > > + SoC-specific version corresponding to the platform first followed by > > + the generic version. Kind regards, Chris
On Tue, Jul 11, 2017 at 03:12:14PM +0300, Sergei Shtylyov wrote: > Hello! > > On 07/10/2017 06:32 PM, Biju Das wrote: > > >Add a new compatible string for the RZ/G1M (R8A7743) SoC. > > > >Signed-off-by: Biju Das <biju.das@bp.renesas.com> > >--- > >v1->v2 > >* Changed the subject > >* re-formatted the required properties > > > > .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++--------- > > 1 file changed, 17 insertions(+), 12 deletions(-) > > > >diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt > >index b519503..4717bc2 100644 > >--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt > >+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt > >@@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB > > interface contains. > > > > Required properties: > >-- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC. > >- "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC. > >- "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC. > >- "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC. > >- "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC. > >- "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC. > >- "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC. > >- "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface. > >- "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface. > >+- compatible: Must contain one or more of the following: > > No, it can't contain more than one SoC specific value. The text above does not say it can unless one is under the delusion that, f.e. an r8a7790 SoC is also an r8a7791 SoC. If you would prefer an alternate wording please provide a suggestion. > >+ - "renesas,etheravb-r8a7743" for the R8A7743 SoC. > >+ - "renesas,etheravb-r8a7790" for the R8A7790 SoC. > >+ - "renesas,etheravb-r8a7791" for the R8A7791 SoC. > >+ - "renesas,etheravb-r8a7792" for the R8A7792 SoC. > >+ - "renesas,etheravb-r8a7793" for the R8A7793 SoC. > >+ - "renesas,etheravb-r8a7794" for the R8A7794 SoC. > >+ - "renesas,etheravb-rcar-gen2" as a fallback for the above > >+ R-Car Gen2 and RZ/G1 devices. > > > >- When compatible with the generic version, nodes must list the > >- SoC-specific version corresponding to the platform first > >- followed by the generic version. > >+ - "renesas,etheravb-r8a7795" for the R8A7795 SoC. > >+ - "renesas,etheravb-r8a7796" for the R8A7796 SoC. > > Neither here. > > >+ - "renesas,etheravb-rcar-gen3" as a fallback for the above > >+ R-Car Gen3 devices. > >+ > >+ When compatible with the generic version, nodes must list the > >+ SoC-specific version corresponding to the platform first followed by > >+ the generic version. > > > > - reg: offset and length of (1) the register block and (2) the stream buffer. > > - interrupts: A list of interrupt-specifiers, one for each entry in > > WBR, Sergei >
On 07/11/2017 03:21 PM, Simon Horman wrote: >>> Add a new compatible string for the RZ/G1M (R8A7743) SoC. >>> >>> Signed-off-by: Biju Das <biju.das@bp.renesas.com> >>> --- >>> v1->v2 >>> * Changed the subject >>> * re-formatted the required properties >>> >>> .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++--------- >>> 1 file changed, 17 insertions(+), 12 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt >>> index b519503..4717bc2 100644 >>> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt >>> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt >>> @@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB >>> interface contains. >>> >>> Required properties: >>> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC. >>> - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC. >>> - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC. >>> - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC. >>> - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC. >>> - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC. >>> - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC. >>> - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface. >>> - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface. >>> +- compatible: Must contain one or more of the following: >> >> No, it can't contain more than one SoC specific value. > > The text above does not say it can unless one is under the delusion > that, f.e. an r8a7790 SoC is also an r8a7791 SoC. Hm, you're right. Sorry about my misunderstanding... The only problem I'm still seeing with the current wording is that gen2/3 fallback values are declared optional, while you can't get the driver to bind without them on the newer SoCs. But this is probably not a new problem... > If you would prefer an alternate wording please provide a suggestion. Perhaps we should emphasize that the gen2/3 fallback values are mandatory? >>> + - "renesas,etheravb-r8a7743" for the R8A7743 SoC. >>> + - "renesas,etheravb-r8a7790" for the R8A7790 SoC. >>> + - "renesas,etheravb-r8a7791" for the R8A7791 SoC. >>> + - "renesas,etheravb-r8a7792" for the R8A7792 SoC. >>> + - "renesas,etheravb-r8a7793" for the R8A7793 SoC. >>> + - "renesas,etheravb-r8a7794" for the R8A7794 SoC. >>> + - "renesas,etheravb-rcar-gen2" as a fallback for the above >>> + R-Car Gen2 and RZ/G1 devices. [...] WBR, Sergei
On 07/11/2017 03:20 PM, Chris Paterson wrote: >>> Add a new compatible string for the RZ/G1M (R8A7743) SoC. >>> >>> Signed-off-by: Biju Das <biju.das@bp.renesas.com> >>> --- >>> v1->v2 >>> * Changed the subject >>> * re-formatted the required properties >>> >>> .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++------ >> --- >>> 1 file changed, 17 insertions(+), 12 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt >>> b/Documentation/devicetree/bindings/net/renesas,ravb.txt >>> index b519503..4717bc2 100644 >>> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt >>> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt >>> @@ -4,19 +4,24 @@ This file provides information on what the device >>> node for the Ethernet AVB interface contains. >>> >>> Required properties: >>> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 >> SoC. >>> - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC. >>> - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC. >>> - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC. >>> - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC. >>> - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC. >>> - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC. >>> - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible >> interface. >>> - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible >> interface. >>> +- compatible: Must contain one or more of the following: >> >> No, it can't contain more than one SoC specific value. > > Surely it can contain both "renesas,etheravb-r8a7743" and "renesas,etheravb-rcar-gen2" for example? > > As indeed dictated by the instruction further down: Yes. Sorry, I should have been more attentive. >>> + When compatible with the generic version, nodes must list the >>> + SoC-specific version corresponding to the platform first followed by >>> + the generic version. > Kind regards, Chris MBR, Sergei
On Tue, Jul 11, 2017 at 03:51:40PM +0300, Sergei Shtylyov wrote: > On 07/11/2017 03:21 PM, Simon Horman wrote: > > >>>Add a new compatible string for the RZ/G1M (R8A7743) SoC. > >>> > >>>Signed-off-by: Biju Das <biju.das@bp.renesas.com> > >>>--- > >>>v1->v2 > >>>* Changed the subject > >>>* re-formatted the required properties > >>> > >>>.../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++--------- > >>>1 file changed, 17 insertions(+), 12 deletions(-) > >>> > >>>diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt > >>>index b519503..4717bc2 100644 > >>>--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt > >>>+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt > >>>@@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB > >>>interface contains. > >>> > >>>Required properties: > >>>-- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC. > >>>- "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC. > >>>- "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC. > >>>- "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC. > >>>- "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC. > >>>- "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC. > >>>- "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC. > >>>- "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface. > >>>- "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface. > >>>+- compatible: Must contain one or more of the following: > >> > >> No, it can't contain more than one SoC specific value. > > > >The text above does not say it can unless one is under the delusion > >that, f.e. an r8a7790 SoC is also an r8a7791 SoC. > > Hm, you're right. Sorry about my misunderstanding... > > The only problem I'm still seeing with the current wording is that gen2/3 > fallback > values are declared optional, while you can't get the driver to bind without > them on > the newer SoCs. But this is probably not a new problem... > > >If you would prefer an alternate wording please provide a suggestion. > > Perhaps we should emphasize that the gen2/3 fallback values are mandatory? It's only mandatory for SoCs covered by those values - admittedly all SoCs supported by the driver at this time. But that is an artifact of the implementation rather than a property of the binding. In any case I think is already described sufficiently in: When compatible with the generic version, nodes must list the SoC-specific version corresponding to the platform first followed by the generic version. > >>>+ - "renesas,etheravb-r8a7743" for the R8A7743 SoC. > >>>+ - "renesas,etheravb-r8a7790" for the R8A7790 SoC. > >>>+ - "renesas,etheravb-r8a7791" for the R8A7791 SoC. > >>>+ - "renesas,etheravb-r8a7792" for the R8A7792 SoC. > >>>+ - "renesas,etheravb-r8a7793" for the R8A7793 SoC. > >>>+ - "renesas,etheravb-r8a7794" for the R8A7794 SoC. > >>>+ - "renesas,etheravb-rcar-gen2" as a fallback for the above > >>>+ R-Car Gen2 and RZ/G1 devices. > [...] > > WBR, Sergei >
diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt index b519503..4717bc2 100644 --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt @@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB interface contains. Required properties: -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC. - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC. - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC. - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC. - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC. - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC. - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC. - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface. - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface. +- compatible: Must contain one or more of the following: + - "renesas,etheravb-r8a7743" for the R8A7743 SoC. + - "renesas,etheravb-r8a7790" for the R8A7790 SoC. + - "renesas,etheravb-r8a7791" for the R8A7791 SoC. + - "renesas,etheravb-r8a7792" for the R8A7792 SoC. + - "renesas,etheravb-r8a7793" for the R8A7793 SoC. + - "renesas,etheravb-r8a7794" for the R8A7794 SoC. + - "renesas,etheravb-rcar-gen2" as a fallback for the above + R-Car Gen2 and RZ/G1 devices. - When compatible with the generic version, nodes must list the - SoC-specific version corresponding to the platform first - followed by the generic version. + - "renesas,etheravb-r8a7795" for the R8A7795 SoC. + - "renesas,etheravb-r8a7796" for the R8A7796 SoC. + - "renesas,etheravb-rcar-gen3" as a fallback for the above + R-Car Gen3 devices. + + When compatible with the generic version, nodes must list the + SoC-specific version corresponding to the platform first followed by + the generic version. - reg: offset and length of (1) the register block and (2) the stream buffer. - interrupts: A list of interrupt-specifiers, one for each entry in
Add a new compatible string for the RZ/G1M (R8A7743) SoC. Signed-off-by: Biju Das <biju.das@bp.renesas.com> --- v1->v2 * Changed the subject * re-formatted the required properties .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++--------- 1 file changed, 17 insertions(+), 12 deletions(-)