| Message ID | 1502197465-61546-2-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Commit | 6c746b92e5d673f0c3c601d8f0a17b7f185b60be |
| Headers | show |
On Tue, Aug 08, 2017 at 02:04:24PM +0100, Biju Das wrote: > Define the iWave RainboW-G20D-Qseven board dependent part of the > RTC device node. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > --- > arch/arm/boot/dts/r8a7743-iwg20d-q7.dts | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) This has a compile-time dependency on "[PATCH 2/2] ARM: dts: r8a7743: Add I2C DT support" for the i2c2 node, right? > > diff --git a/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts b/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts > index 081af01..b3a1efa 100644 > --- a/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts > +++ b/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts > @@ -31,6 +31,11 @@ > groups = "avb_mdio", "avb_gmii"; > function = "avb"; > }; > + > + i2c2_pins: i2c2 { > + groups = "i2c2"; > + function = "i2c2"; > + }; > }; > > &scif0 { > @@ -54,3 +59,16 @@ > micrel,led-mode = <1>; > }; > }; > + > +&i2c2 { > + pinctrl-0 = <&i2c2_pins>; > + pinctrl-names = "default"; > + > + status = "okay"; > + clock-frequency = <400000>; > + > + rtc@68 { > + compatible = "bq32000"; > + reg = <0x68>; > + }; > +}; > -- > 1.9.1 >
On Wed, Aug 09, 2017 at 11:02:30AM +0200, Simon Horman wrote: > On Tue, Aug 08, 2017 at 02:04:24PM +0100, Biju Das wrote: > > Define the iWave RainboW-G20D-Qseven board dependent part of the > > RTC device node. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > --- > > arch/arm/boot/dts/r8a7743-iwg20d-q7.dts | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > This has a compile-time dependency on > "[PATCH 2/2] ARM: dts: r8a7743: Add I2C DT support" > for the i2c2 node, right? As I have now applied the above dependency I have also applied this patch for v4.14.
On Tue, Aug 8, 2017 at 3:04 PM, Biju Das <biju.das@bp.renesas.com> wrote: > Define the iWave RainboW-G20D-Qseven board dependent part of the > RTC device node. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > @@ -54,3 +59,16 @@ > micrel,led-mode = <1>; > }; > }; > + > +&i2c2 { > + pinctrl-0 = <&i2c2_pins>; > + pinctrl-names = "default"; > + > + status = "okay"; > + clock-frequency = <400000>; > + > + rtc@68 { > + compatible = "bq32000"; "ti,bq32000" > + reg = <0x68>; > + }; > +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
> -----Original Message----- > From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com] > On Behalf Of Geert Uytterhoeven > Sent: 14 August 2017 15:12 > To: Biju Das <biju.das@bp.renesas.com> > Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland > <mark.rutland@arm.com>; Simon Horman <horms@verge.net.au>; Magnus > Damm <magnus.damm@gmail.com>; Russell King <linux@armlinux.org.uk>; > Chris Paterson <Chris.Paterson2@renesas.com>; devicetree@vger.kernel.org; > Linux-Renesas <linux-renesas-soc@vger.kernel.org>; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH 1/2] ARM: dts: iwg20d-q7: Add RTC support > > On Tue, Aug 8, 2017 at 3:04 PM, Biju Das <biju.das@bp.renesas.com> wrote: > > Define the iWave RainboW-G20D-Qseven board dependent part of the RTC > > device node. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > @@ -54,3 +59,16 @@ > > micrel,led-mode = <1>; > > }; > > }; > > + > > +&i2c2 { > > + pinctrl-0 = <&i2c2_pins>; > > + pinctrl-names = "default"; > > + > > + status = "okay"; > > + clock-frequency = <400000>; > > + > > + rtc@68 { > > + compatible = "bq32000"; > > "ti,bq32000" Thanks. I will change this. > > + reg = <0x68>; > > + }; > > +}; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
On Mon, Aug 14, 2017 at 02:26:08PM +0000, Biju Das wrote: > > > > -----Original Message----- > > From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com] > > On Behalf Of Geert Uytterhoeven > > Sent: 14 August 2017 15:12 > > To: Biju Das <biju.das@bp.renesas.com> > > Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland > > <mark.rutland@arm.com>; Simon Horman <horms@verge.net.au>; Magnus > > Damm <magnus.damm@gmail.com>; Russell King <linux@armlinux.org.uk>; > > Chris Paterson <Chris.Paterson2@renesas.com>; devicetree@vger.kernel.org; > > Linux-Renesas <linux-renesas-soc@vger.kernel.org>; linux-arm- > > kernel@lists.infradead.org > > Subject: Re: [PATCH 1/2] ARM: dts: iwg20d-q7: Add RTC support > > > > On Tue, Aug 8, 2017 at 3:04 PM, Biju Das <biju.das@bp.renesas.com> wrote: > > > Define the iWave RainboW-G20D-Qseven board dependent part of the RTC > > > device node. > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > > > @@ -54,3 +59,16 @@ > > > micrel,led-mode = <1>; > > > }; > > > }; > > > + > > > +&i2c2 { > > > + pinctrl-0 = <&i2c2_pins>; > > > + pinctrl-names = "default"; > > > + > > > + status = "okay"; > > > + clock-frequency = <400000>; > > > + > > > + rtc@68 { > > > + compatible = "bq32000"; > > > > "ti,bq32000" > > Thanks. I will change this. Thanks, I have dropped this patch for now. Please submit a v2.
diff --git a/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts b/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts index 081af01..b3a1efa 100644 --- a/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts +++ b/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts @@ -31,6 +31,11 @@ groups = "avb_mdio", "avb_gmii"; function = "avb"; }; + + i2c2_pins: i2c2 { + groups = "i2c2"; + function = "i2c2"; + }; }; &scif0 { @@ -54,3 +59,16 @@ micrel,led-mode = <1>; }; }; + +&i2c2 { + pinctrl-0 = <&i2c2_pins>; + pinctrl-names = "default"; + + status = "okay"; + clock-frequency = <400000>; + + rtc@68 { + compatible = "bq32000"; + reg = <0x68>; + }; +};
Define the iWave RainboW-G20D-Qseven board dependent part of the RTC device node. Signed-off-by: Biju Das <biju.das@bp.renesas.com> --- arch/arm/boot/dts/r8a7743-iwg20d-q7.dts | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)