| Message ID | 1505322341-9480-2-git-send-email-chris.paterson2@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Simon Horman |
| Headers | show |
On Wed, Sep 13, 2017 at 7:05 PM, Chris Paterson <chris.paterson2@renesas.com> wrote: > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Add DT node for the Advanced Power Management Unit (APMU), add the > second CPU core, and use "renesas,apmu" as "enable-method". > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Simon, On Fri, Sep 15, 2017 at 1:06 PM, Simon Horman <horms@verge.net.au> wrote: > On Fri, Sep 15, 2017 at 08:57:53AM +0000, Fabrizio Castro wrote: >> > -----Original Message----- >> > From: linux-renesas-soc-owner@vger.kernel.org [mailto:linux-renesas-soc-owner@vger.kernel.org] On Behalf Of Geert >> > Uytterhoeven >> > Sent: 15 September 2017 09:05 >> > To: Simon Horman <horms@verge.net.au>; Fabrizio Castro <fabrizio.castro@bp.renesas.com> >> > Cc: Chris Paterson <Chris.Paterson2@renesas.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; >> > Magnus Damm <magnus.damm@gmail.com>; Russell King <linux@armlinux.org.uk>; devicetree@vger.kernel.org; Linux-Renesas >> > <linux-renesas-soc@vger.kernel.org>; linux-arm-kernel@lists.infradead.org; Geert Uytterhoeven <geert+renesas@glider.be> >> > Subject: Re: [PATCH 1/8] ARM: dts: r8a7745: Add APMU node and second CPU core >> > >> > Hi Simon, Fabrizio, >> > >> > On Fri, Sep 15, 2017 at 9:45 AM, Simon Horman <horms@verge.net.au> wrote: >> > > On Wed, Sep 13, 2017 at 06:05:34PM +0100, Chris Paterson wrote: >> > >> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> >> > >> >> > >> Add DT node for the Advanced Power Management Unit (APMU), add the >> > >> second CPU core, and use "renesas,apmu" as "enable-method". >> > >> >> > >> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> >> > >> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> >> > >> --- >> > >> This patch is based on renesas-devel-20170913-v4.13. >> > > >> > > Hi, >> > > >> > > with reference to "[PATCH v3 0/3] ARM: renesas: Enable SMP on R-Car E2" >> > > is the CNTVOFF initialised in the boot loader of boards (in upstream) >> > > for this SoC? If not I expect you will have trouble with the arch timer >> > > on secondary CPU cores. >> >> I can confirm that this patch relies on: >> * "ARM: Add definition for monitor mode", and >> * "ARM: shmobile: rcar-gen2: Make sure CNTVOFF is initialized on CA7/15 " >> as the bootloader doesn't initialize CNTVOFF. >> >> > >> > Exactly my question. >> > >> > Fabrizio: Given your feedback on "[PATCH v3 0/3] ARM: renesas: Enable SMP on >> > R-Car E2", I think SMP enablement on RZ/G1E has to be postponed until "ARM: >> > shmobile: rcar-gen2: Make sure CNTVOFF is initialized on CA7/15" has been >> > accepted upstream. >> >> You are right, somehow we missed the comment made by Simon on Monday: >> >> " I would like to deffer the third and last patch until v4.16 to avoid >> an awkward branch dependency on the above - the branches are different >> even though the tree is the same. Please resubmit this patch once the >> above dependencies are present in an rc release, which at this stage >> I expect to be v4.15-rc1." >> >> Apologies for this, we will send this patch later on, once both patches have been >> accepted upstream. > > No problem, I will mark this one as deferred. As the dependency is in v4.15-rc1, it can be applied now. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hello Geert, Simon, > > As the dependency is in v4.15-rc1, it can be applied now. > we thought exactly the same thing, therefore we rebased and we re-ran our tests, to discover that something broke in between versions. I'll be in touch once I have more information, but it's a no go for now. Thanks, Fab [https://www2.renesas.eu/media/email/unicef_2017.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hello Geert, Simon, the problems I am seeing are not related to APMU/SMP, I'll send a v2 shortly. Thanks, Fab > > Hello Geert, Simon, > > > > > As the dependency is in v4.15-rc1, it can be applied now. > > > > we thought exactly the same thing, therefore we rebased and we re-ran our tests, to discover that something broke in between > versions. > I'll be in touch once I have more information, but it's a no go for now. > > Thanks, > Fab > > > [https://www2.renesas.eu/media/email/unicef_2017.jpg] > > This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further > details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. > We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. > > > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & > Wales under Registered No. 04586709. [https://www2.renesas.eu/media/email/unicef_2017.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi index 6e82991..8ed2ac5 100644 --- a/arch/arm/boot/dts/r8a7745.dtsi +++ b/arch/arm/boot/dts/r8a7745.dtsi @@ -30,6 +30,7 @@ cpus { #address-cells = <1>; #size-cells = <0>; + enable-method = "renesas,apmu"; cpu0: cpu@0 { device_type = "cpu"; @@ -41,6 +42,15 @@ next-level-cache = <&L2_CA7>; }; + cpu1: cpu@1 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <1>; + clock-frequency = <1000000000>; + power-domains = <&sysc R8A7745_PD_CA7_CPU1>; + next-level-cache = <&L2_CA7>; + }; + L2_CA7: cache-controller-0 { compatible = "cache"; cache-unified; @@ -57,6 +67,12 @@ #size-cells = <2>; ranges; + apmu@e6151000 { + compatible = "renesas,r8a7745-apmu", "renesas,apmu"; + reg = <0 0xe6151000 0 0x188>; + cpus = <&cpu0 &cpu1>; + }; + gic: interrupt-controller@f1001000 { compatible = "arm,gic-400"; #interrupt-cells = <3>;