| Message ID | 1507308574-32047-1-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Fri, Oct 06, 2017 at 05:49:34PM +0100, Biju Das wrote: > This patch adds support for r8a7743/5 SoCs. The Renesas RZ/G1[ME] > (R8A7743/5) usbhs is identical to the R-Car Gen2 family. > > No driver change is needed due to the fallback compatible value > "renesas,rcar-gen2-usbhs". > Adding the SoC-specific compatible values here has two purposes: > 1. Document which SoCs have this hardware module, > 2. Allow checkpatch to validate compatible values. 3. Allow the driver to support SoC specific implementations in future as necessary. Acked-by: Simon Horman <horms+renesas@verge.net.au> > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > v1-->v2 > * Modified the patch description > * Rebased on the below R-Car D3 patch > https://patchwork.kernel.org/patch/9982267/ > > This patch is tested against Linux next tag next-20170929 + > https://patchwork.kernel.org/patch/9982267/ > > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > index e79f6e4..47394ab 100644 > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > @@ -3,6 +3,8 @@ Renesas Electronics USBHS driver > Required properties: > - compatible: Must contain one or more of the following: > > + - "renesas,usbhs-r8a7743" for r8a7743 (RZ/G1M) compatible device > + - "renesas,usbhs-r8a7745" for r8a7745 (RZ/G1E) compatible device > - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device > - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device > - "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device > @@ -11,7 +13,7 @@ Required properties: > - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device > - "renesas,usbhs-r8a7796" for r8a7796 (R-Car M3-W) compatible device > - "renesas,usbhs-r8a77995" for r8a77995 (R-Car D3) compatible device > - - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device > + - "renesas,rcar-gen2-usbhs" for R-Car Gen2 or RZ/G1 compatible devices > - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device > > When compatible with the generic version, nodes must list the > -- > 1.9.1 >
Hi Simon, On Mon, Oct 9, 2017 at 7:59 AM, Simon Horman <horms@verge.net.au> wrote: > On Fri, Oct 06, 2017 at 05:49:34PM +0100, Biju Das wrote: >> This patch adds support for r8a7743/5 SoCs. The Renesas RZ/G1[ME] >> (R8A7743/5) usbhs is identical to the R-Car Gen2 family. >> >> No driver change is needed due to the fallback compatible value >> "renesas,rcar-gen2-usbhs". >> Adding the SoC-specific compatible values here has two purposes: >> 1. Document which SoCs have this hardware module, >> 2. Allow checkpatch to validate compatible values. > > 3. Allow the driver to support SoC specific implementations in future > as necessary. Thanks for amending! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Fri, Oct 06, 2017 at 05:49:34PM +0100, Biju Das wrote: > This patch adds support for r8a7743/5 SoCs. The Renesas RZ/G1[ME] > (R8A7743/5) usbhs is identical to the R-Car Gen2 family. > > No driver change is needed due to the fallback compatible value > "renesas,rcar-gen2-usbhs". > Adding the SoC-specific compatible values here has two purposes: > 1. Document which SoCs have this hardware module, > 2. Allow checkpatch to validate compatible values. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > v1-->v2 > * Modified the patch description > * Rebased on the below R-Car D3 patch > https://patchwork.kernel.org/patch/9982267/ > > This patch is tested against Linux next tag next-20170929 + > https://patchwork.kernel.org/patch/9982267/ > > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt index e79f6e4..47394ab 100644 --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt @@ -3,6 +3,8 @@ Renesas Electronics USBHS driver Required properties: - compatible: Must contain one or more of the following: + - "renesas,usbhs-r8a7743" for r8a7743 (RZ/G1M) compatible device + - "renesas,usbhs-r8a7745" for r8a7745 (RZ/G1E) compatible device - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device - "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device @@ -11,7 +13,7 @@ Required properties: - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device - "renesas,usbhs-r8a7796" for r8a7796 (R-Car M3-W) compatible device - "renesas,usbhs-r8a77995" for r8a77995 (R-Car D3) compatible device - - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device + - "renesas,rcar-gen2-usbhs" for R-Car Gen2 or RZ/G1 compatible devices - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device When compatible with the generic version, nodes must list the