| Message ID | 1510743363-25798-5-git-send-email-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Horman |
| Headers | show |
On Wed, Nov 15, 2017 at 11:55:57AM +0100, Jacopo Mondi wrote:
> Add Capture Engine Unit (CEU) node to device tree.
Other patches in this series (which are not for my tree) appear
to warrant updating. Accordingly I am marking this patch as
"Changes Requested" and am expecting it to be reposted at some point.
Hi Jacopo, On Wed, Nov 15, 2017 at 11:55 AM, Jacopo Mondi <jacopo+renesas@jmondi.org> wrote: > Add Capture Engine Unit (CEU) node to device tree. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Thanks for your patch! > --- a/arch/arm/boot/dts/r7s72100.dtsi > +++ b/arch/arm/boot/dts/r7s72100.dtsi > @@ -136,8 +136,8 @@ > compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks"; > reg = <0xfcfe042c 4>; > clocks = <&p0_clk>; You forgot to add an entry to clocks. The parent clock of the CEU module clock is b_clk. > - clock-indices = <R7S72100_CLK_RTC>; > - clock-output-names = "rtc"; > + clock-indices = <R7S72100_CLK_RTC R7S72100_CLK_CEU>; > + clock-output-names = "rtc", "ceu"; Usually we follow the order from <dt-bindings/clock/r7s72100-clock.h>, so CEU should come before RTC. > @@ -666,4 +666,12 @@ > power-domains = <&cpg_clocks>; > status = "disabled"; > }; > + > + ceu: ceu@e8210000 { > + reg = <0xe8210000 0x209c>; > + compatible = "renesas,renesas-ceu"; > + interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>; > + power-domains = <&cpg_clocks>; if you describe the device to be part of the CPG clock domain, you should provide a clocks property: clocks = <&mstp6_clks R7S72100_CLK_CEU>; > + status = "disabled"; > + }; > }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi index 4ed12a4..683d459 100644 --- a/arch/arm/boot/dts/r7s72100.dtsi +++ b/arch/arm/boot/dts/r7s72100.dtsi @@ -136,8 +136,8 @@ compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks"; reg = <0xfcfe042c 4>; clocks = <&p0_clk>; - clock-indices = <R7S72100_CLK_RTC>; - clock-output-names = "rtc"; + clock-indices = <R7S72100_CLK_RTC R7S72100_CLK_CEU>; + clock-output-names = "rtc", "ceu"; }; mstp7_clks: mstp7_clks@fcfe0430 { @@ -666,4 +666,12 @@ power-domains = <&cpg_clocks>; status = "disabled"; }; + + ceu: ceu@e8210000 { + reg = <0xe8210000 0x209c>; + compatible = "renesas,renesas-ceu"; + interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>; + power-domains = <&cpg_clocks>; + status = "disabled"; + }; };
Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- arch/arm/boot/dts/r7s72100.dtsi | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)