From patchwork Mon Jan 8 11:44:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 10149275 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 88900601BE for ; Mon, 8 Jan 2018 11:44:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7ABF51FFE5 for ; Mon, 8 Jan 2018 11:44:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6F437286E1; Mon, 8 Jan 2018 11:44:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E850E1FFE5 for ; Mon, 8 Jan 2018 11:44:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756223AbeAHLov (ORCPT ); Mon, 8 Jan 2018 06:44:51 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:44282 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756049AbeAHLou (ORCPT ); Mon, 8 Jan 2018 06:44:50 -0500 Received: by mail-lf0-f65.google.com with SMTP id w23so1600211lfd.11 for ; Mon, 08 Jan 2018 03:44:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=gO5LTI+4vUuhoii3lkp++pg9Sj5CfX8eQLxeK2r/eBo=; b=c0qhvzoaiLtpumcDCBbOc/yG7leZcNn1w9uxDh/mvWKLfON3xfcTE7u2Nlf3IBGM+P qbFfI8/fbOAQp4hfYnYSv2C6W450+I/3HcLBD1o6qmOPr1DhDt8yX8v5Q/32PuYs8Zxh SAO5HcgphvB285fG9SoKKoIqnigT0vexBfYv0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=gO5LTI+4vUuhoii3lkp++pg9Sj5CfX8eQLxeK2r/eBo=; b=hqWAs8OoHPcRGymRm8dZyo8OGjV4WmuMYR5C5/uKgWm58k5nBZURKzhg1hEXi82NIK AwJHKmjS3wXGJcjLCsnCetq8jPQN4YY85EunI7jTpz95WC9fuFYJ8xO8rHkpT0S3eIWN tl0cz5ht/hfuEwGG7k09EdCXmTrgFdh3vCxijCIbQMb5BHzdX1WkSINxJzUjKov9qdQW hdVuYlKYY29j17wGQQHX0E3XaoSbvbufpg8yl+SaEY/QeGnAm6yM7GXnA1uRFOt4YbXg snc5OPxjTHmNvRJ5aPe/U5YTbrS/BtUqOjWce3hNHTjkqSMAv1cpk0cSf5LAiE9ztkXH Ym7w== X-Gm-Message-State: AKGB3mKysas9mR3n1CilvCBHiag7oklGv7wgBy1Kl6Zhq3azlM7OI5Bu 7cL+rN53GihY0Tc0mwZ3F7PX9g== X-Google-Smtp-Source: ACJfBotTHI4Q97VHdUApThRKgQ55URLPx/h6Lmp07uNpZ2gkZKjZI34itOmO8U1B/5mKJy/booyABw== X-Received: by 10.46.64.81 with SMTP id n78mr1777442lja.129.1515411888808; Mon, 08 Jan 2018 03:44:48 -0800 (PST) Received: from localhost.localdomain (h-158-174-22-67.NA.cust.bahnhof.se. [158.174.22.67]) by smtp.gmail.com with ESMTPSA id w7sm2281824ljd.95.2018.01.08.03.44.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 08 Jan 2018 03:44:47 -0800 (PST) From: Ulf Hansson To: "Rafael J . Wysocki" , linux-pm@vger.kernel.org Cc: Kevin Hilman , Viresh Kumar , Geert Uytterhoeven , Simon Horman , Niklas Soderlund , Vincent Guittot , linux-renesas-soc@vger.kernel.org, Ulf Hansson Subject: [PATCH v4] PM / wakeup: Print warn if device gets enabled as wakeup source during sleep Date: Mon, 8 Jan 2018 12:44:43 +0100 Message-Id: <1515411883-12626-1-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In general, wakeup settings are not supposed to be changed during any of the system wide PM phases. The reason is simply that it would break guarantees provided by the PM core, to properly act on active wakeup sources. However, there are exceptions to when, in particular, disabling a device as wakeup source makes sense. For example, in cases when a driver realizes that its device is dead during system suspend. For these scenarios, we don't need to care about acting on the wakeup source correctly, because a dead device shouldn't deliver wakeup signals. To this reasoning and to help users to properly manage wakeup settings, let's print a warning in cases someone calls device_wakeup_enable() during system sleep. Suggested-by: Rafael J. Wysocki Signed-off-by: Ulf Hansson --- Changes in v4: - Send this as a separate change. - Changed from dev_warn() to dev_dbg(). --- drivers/base/power/wakeup.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c index e73a081..f30c233 100644 --- a/drivers/base/power/wakeup.c +++ b/drivers/base/power/wakeup.c @@ -268,6 +268,9 @@ int device_wakeup_enable(struct device *dev) if (!dev || !dev->power.can_wakeup) return -EINVAL; + if (pm_suspend_target_state != PM_SUSPEND_ON) + dev_dbg(dev, "don't enable as wakup source during sleep!\n"); + ws = wakeup_source_register(dev_name(dev)); if (!ws) return -ENOMEM;