Message ID | 1522161443-54428-11-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
---|---|
State | Changes Requested |
Delegated to: | Simon Horman |
Headers | show |
Hi Biju, On Tue, Mar 27, 2018 at 4:37 PM, Biju Das <biju.das@bp.renesas.com> wrote: > Add support for iWave iW-RainboW-G23S single board computer based on > RZ/G1C. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> One question below. > --- /dev/null > +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > @@ -0,0 +1,30 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Device Tree Source for the iWave-RZ/G1C single board computer > + * > + * Copyright (C) 2018 Renesas Electronics Corp. > + */ > + > +/dts-v1/; > +#include "r8a77470.dtsi" > +/ { > + model = "iWave iW-RainboW-G23S single board computer based on RZ/G1C"; > + compatible = "iwave,g23s", "renesas,r8a77470"; > + > + aliases { > + serial1 = &scif1; > + }; No chosen / stdout-path? Gr{oetje,eeting}s, Geert
Hi Geert, Thanks for the feedback. > On Tue, Mar 27, 2018 at 4:37 PM, Biju Das <biju.das@bp.renesas.com> wrote: > > Add support for iWave iW-RainboW-G23S single board computer based on > > RZ/G1C. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Thanks for your patch! > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > One question below. > > > --- /dev/null > > +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > > @@ -0,0 +1,30 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Device Tree Source for the iWave-RZ/G1C single board computer > > + * > > + * Copyright (C) 2018 Renesas Electronics Corp. > > + */ > > + > > +/dts-v1/; > > +#include "r8a77470.dtsi" > > +/ { > > + model = "iWave iW-RainboW-G23S single board computer based on > RZ/G1C"; > > + compatible = "iwave,g23s", "renesas,r8a77470"; > > + > > + aliases { > > + serial1 = &scif1; > > + }; > > No chosen / stdout-path? I am planning this later as part of ethernet patch submission. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hi Biju, On Wed, Mar 28, 2018 at 3:13 PM, Biju Das <biju.das@bp.renesas.com> wrote: >> On Tue, Mar 27, 2018 at 4:37 PM, Biju Das <biju.das@bp.renesas.com> wrote: >> > Add support for iWave iW-RainboW-G23S single board computer based on >> > RZ/G1C. >> > >> > Signed-off-by: Biju Das <biju.das@bp.renesas.com> >> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> >> >> Thanks for your patch! >> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >> One question below. >> >> > --- /dev/null >> > +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts >> > @@ -0,0 +1,30 @@ >> > +// SPDX-License-Identifier: GPL-2.0 >> > +/* >> > + * Device Tree Source for the iWave-RZ/G1C single board computer >> > + * >> > + * Copyright (C) 2018 Renesas Electronics Corp. >> > + */ >> > + >> > +/dts-v1/; >> > +#include "r8a77470.dtsi" >> > +/ { >> > + model = "iWave iW-RainboW-G23S single board computer based on >> RZ/G1C"; >> > + compatible = "iwave,g23s", "renesas,r8a77470"; >> > + >> > + aliases { >> > + serial1 = &scif1; >> > + }; >> >> No chosen / stdout-path? > > I am planning this later as part of ethernet patch submission. But stdout-path is not related to Ethernet? Gr{oetje,eeting}s, Geert
Hi Geert, Thanks for the feedback. > Hi Biju, > > On Wed, Mar 28, 2018 at 3:13 PM, Biju Das <biju.das@bp.renesas.com> wrote: > >> On Tue, Mar 27, 2018 at 4:37 PM, Biju Das <biju.das@bp.renesas.com> > wrote: > >> > Add support for iWave iW-RainboW-G23S single board computer based > >> > on RZ/G1C. > >> > > >> > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > >> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > >> > >> Thanks for your patch! > >> > >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> > >> One question below. > >> > >> > --- /dev/null > >> > +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > >> > @@ -0,0 +1,30 @@ > >> > +// SPDX-License-Identifier: GPL-2.0 > >> > +/* > >> > + * Device Tree Source for the iWave-RZ/G1C single board computer > >> > + * > >> > + * Copyright (C) 2018 Renesas Electronics Corp. > >> > + */ > >> > + > >> > +/dts-v1/; > >> > +#include "r8a77470.dtsi" > >> > +/ { > >> > + model = "iWave iW-RainboW-G23S single board computer based > >> > +on > >> RZ/G1C"; > >> > + compatible = "iwave,g23s", "renesas,r8a77470"; > >> > + > >> > + aliases { > >> > + serial1 = &scif1; > >> > + }; > >> > >> No chosen / stdout-path? > > > > I am planning this later as part of ethernet patch submission. > > But stdout-path is not related to Ethernet? Ok. Will add stdout-path in V2. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But when > I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 3b4cc1b..3e4df0d 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -795,6 +795,7 @@ dtb-$(CONFIG_ARCH_RENESAS) += \ r8a7745-iwg22d-sodimm.dtb \ r8a7745-iwg22d-sodimm-dbhd-ca.dtb \ r8a7745-sk-rzg1e.dtb \ + r8a77470-iwg23s-sbc.dtb \ r8a7778-bockw.dtb \ r8a7779-marzen.dtb \ r8a7790-lager.dtb \ diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts new file mode 100644 index 0000000..ebbfb36 --- /dev/null +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts @@ -0,0 +1,30 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Device Tree Source for the iWave-RZ/G1C single board computer + * + * Copyright (C) 2018 Renesas Electronics Corp. + */ + +/dts-v1/; +#include "r8a77470.dtsi" +/ { + model = "iWave iW-RainboW-G23S single board computer based on RZ/G1C"; + compatible = "iwave,g23s", "renesas,r8a77470"; + + aliases { + serial1 = &scif1; + }; + + memory@40000000 { + device_type = "memory"; + reg = <0 0x40000000 0 0x20000000>; + }; +}; + +&extal_clk { + clock-frequency = <20000000>; +}; + +&scif1 { + status = "okay"; +};