diff mbox

[5/5] arm64: dts: renesas: r8a77995-draak: add X12 input dot clock

Message ID 1526386840-15368-6-git-send-email-ulrich.hecht+renesas@gmail.com (mailing list archive)
State Accepted
Commit 1236b86b6bfe89f5809a1141318ac245e741cbd6
Delegated to: Simon Horman
Headers show

Commit Message

Ulrich Hecht May 15, 2018, 12:20 p.m. UTC
74.25 Mhz oscillator X12 is connected to DU_DOTCLKIN0.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Simon Horman May 16, 2018, 8:38 a.m. UTC | #1
On Tue, May 15, 2018 at 02:20:40PM +0200, Ulrich Hecht wrote:
> 74.25 Mhz oscillator X12 is connected to DU_DOTCLKIN0.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)

This looks fine but I will wait to see if there are other reviews before
applying.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Laurent Pinchart May 20, 2018, 8:58 a.m. UTC | #2
Hi Ulrich,

Thank you for the patch.

On Wednesday, 16 May 2018 11:38:22 EEST Simon Horman wrote:
> On Tue, May 15, 2018 at 02:20:40PM +0200, Ulrich Hecht wrote:
> > 74.25 Mhz oscillator X12 is connected to DU_DOTCLKIN0.
> > 
> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> > ---
> > 
> >  arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> 
> This looks fine but I will wait to see if there are other reviews before
> applying.
> 
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

As far as I'm concerned this patch can be merged already. I would however 
possibly hold off merging patch 3/5 and 4/5 until they can be tested.
Simon Horman May 22, 2018, 8:58 a.m. UTC | #3
On Sun, May 20, 2018 at 11:58:36AM +0300, Laurent Pinchart wrote:
> Hi Ulrich,
> 
> Thank you for the patch.
> 
> On Wednesday, 16 May 2018 11:38:22 EEST Simon Horman wrote:
> > On Tue, May 15, 2018 at 02:20:40PM +0200, Ulrich Hecht wrote:
> > > 74.25 Mhz oscillator X12 is connected to DU_DOTCLKIN0.
> > > 
> > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> > > ---
> > > 
> > >  arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > 
> > This looks fine but I will wait to see if there are other reviews before
> > applying.
> > 
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> 
> As far as I'm concerned this patch can be merged already. I would however 
> possibly hold off merging patch 3/5 and 4/5 until they can be tested.

Thanks, I have applied this patch for v4.19.

As per your suggestion, I have marked patches 3/5 and 4/5 as deferred
pending testing.
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
index b059e32..04d2018 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
@@ -117,6 +117,12 @@ 
 		regulator-boot-on;
 		regulator-always-on;
 	};
+
+	x12_clk: x12 {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <74250000>;
+	};
 };
 
 &extal_clk {
@@ -235,6 +241,11 @@ 
 	pinctrl-names = "default";
 	status = "okay";
 
+	clocks = <&cpg CPG_MOD 724>,
+		 <&cpg CPG_MOD 723>,
+		 <&x12_clk>;
+	clock-names = "du.0", "du.1", "dclkin.0";
+
 	ports {
 		port@0 {
 			endpoint {