| Message ID | 1535106262-13004-4-git-send-email-jacopo@jmondi.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | vin-tests: Add D3 Draak support | expand |
Hi Jacopo, Thanks for your work. On 2018-08-24 12:24:21 +0200, Jacopo Mondi wrote: > Add configurable capture format to propagate_parallel() function. > The capture format is the image format set on the VIN nodes. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > scripts/boards.sh | 2 ++ > scripts/vin-tests.sh | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/scripts/boards.sh b/scripts/boards.sh > index 7eb3a27..b379af6 100644 > --- a/scripts/boards.sh > +++ b/scripts/boards.sh > @@ -28,6 +28,7 @@ case $info in > # FIXME: This is a hack and not the correct mbus format > # for V3M, but results in an image. > parallelformat="YUYV8_1X16" > + parallel_captureformat="RGB565" I'm sorry I don't see the value of this change, am I missing something? There is no functional change but I assume you use this for something but until I figure out what I will leave this change hanging. > ;; > "Renesas Draak board based on r8a77995") > gen="gen3" > @@ -35,6 +36,7 @@ case $info in > parallelname="adv7612 0-004c" > # FIXME: This is a hackfor D3, but results in an image. > parallelformat="YUYV8_1X16" > + parallel_captureformat="RGB565" > ;; > "Koelsch") > gen="gen2" > diff --git a/scripts/vin-tests.sh b/scripts/vin-tests.sh > index 0c5b29a..e7b7a48 100644 > --- a/scripts/vin-tests.sh > +++ b/scripts/vin-tests.sh > @@ -111,5 +111,5 @@ mc_propagate_parallel() { > echo "format: $format size: $size/$vinsize field: $field/$vinfield vdev: $vdev" > > $mediactl -d $mdev -V "$cam [fmt:$format/$size field:$field]" > - yavta -f RGB565 -s $vinsize --field $vinfield $vdev > + yavta -f $parallel_captureformat -s $vinsize --field $vinfield $vdev > } > -- > 2.7.4 >
Hi Niklas, On Fri, Aug 24, 2018 at 06:18:13PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2018-08-24 12:24:21 +0200, Jacopo Mondi wrote: > > Add configurable capture format to propagate_parallel() function. > > The capture format is the image format set on the VIN nodes. > > > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > > --- > > scripts/boards.sh | 2 ++ > > scripts/vin-tests.sh | 2 +- > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/scripts/boards.sh b/scripts/boards.sh > > index 7eb3a27..b379af6 100644 > > --- a/scripts/boards.sh > > +++ b/scripts/boards.sh > > @@ -28,6 +28,7 @@ case $info in > > # FIXME: This is a hack and not the correct mbus format > > # for V3M, but results in an image. > > parallelformat="YUYV8_1X16" > > + parallel_captureformat="RGB565" > > I'm sorry I don't see the value of this change, am I missing something? > There is no functional change but I assume you use this for something > but until I figure out what I will leave this change hanging. > > ;; > > "Renesas Draak board based on r8a77995") > > gen="gen3" > > @@ -35,6 +36,7 @@ case $info in > > parallelname="adv7612 0-004c" > > # FIXME: This is a hackfor D3, but results in an image. > > parallelformat="YUYV8_1X16" > > + parallel_captureformat="RGB565" Oops, this was supposed to be a different format, that's why I have added this new variable. I'll fix it in next iteration. > > ;; > > "Koelsch") > > gen="gen2" > > diff --git a/scripts/vin-tests.sh b/scripts/vin-tests.sh > > index 0c5b29a..e7b7a48 100644 > > --- a/scripts/vin-tests.sh > > +++ b/scripts/vin-tests.sh > > @@ -111,5 +111,5 @@ mc_propagate_parallel() { > > echo "format: $format size: $size/$vinsize field: $field/$vinfield vdev: $vdev" > > > > $mediactl -d $mdev -V "$cam [fmt:$format/$size field:$field]" > > - yavta -f RGB565 -s $vinsize --field $vinfield $vdev > > + yavta -f $parallel_captureformat -s $vinsize --field $vinfield $vdev > > } > > -- > > 2.7.4 > > > > -- > Regards, > Niklas Söderlund
diff --git a/scripts/boards.sh b/scripts/boards.sh index 7eb3a27..b379af6 100644 --- a/scripts/boards.sh +++ b/scripts/boards.sh @@ -28,6 +28,7 @@ case $info in # FIXME: This is a hack and not the correct mbus format # for V3M, but results in an image. parallelformat="YUYV8_1X16" + parallel_captureformat="RGB565" ;; "Renesas Draak board based on r8a77995") gen="gen3" @@ -35,6 +36,7 @@ case $info in parallelname="adv7612 0-004c" # FIXME: This is a hackfor D3, but results in an image. parallelformat="YUYV8_1X16" + parallel_captureformat="RGB565" ;; "Koelsch") gen="gen2" diff --git a/scripts/vin-tests.sh b/scripts/vin-tests.sh index 0c5b29a..e7b7a48 100644 --- a/scripts/vin-tests.sh +++ b/scripts/vin-tests.sh @@ -111,5 +111,5 @@ mc_propagate_parallel() { echo "format: $format size: $size/$vinsize field: $field/$vinfield vdev: $vdev" $mediactl -d $mdev -V "$cam [fmt:$format/$size field:$field]" - yavta -f RGB565 -s $vinsize --field $vinfield $vdev + yavta -f $parallel_captureformat -s $vinsize --field $vinfield $vdev }
Add configurable capture format to propagate_parallel() function. The capture format is the image format set on the VIN nodes. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- scripts/boards.sh | 2 ++ scripts/vin-tests.sh | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)