| Message ID | 1535535207-2800-2-git-send-email-na-hoan@jinso.co.jp (mailing list archive) |
|---|---|
| State | Deferred |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | arm64: dts: salvator-common: Add PWM-2 channel | expand |
Hi Hoan, On Wed, Aug 29, 2018 at 11:33 AM Nguyen An Hoan <na-hoan@jinso.co.jp> wrote: > From: Hoan Nguyen An <na-hoan@jinso.co.jp> > > Add PWM-2 channel(CN28 - pin30) support for Salvator-X Thanks for your patch! Please explain why this is useful. Usually we do not enable random functionality on expansion connectors. In this case, this even has an (undocumented) impact on on-board devices, as the signal is also connected to the BD9571MWV PMIC. (Perhaps that was the actual intention of this patch? ;-) If yes, please explain) Thanks! Gr{oetje,eeting}s, Geert
Dear Geert-san, Thank you very much for your comments! CC: Simon-san > Hi Hoan, > > On Wed, Aug 29, 2018 at 11:33 AM Nguyen An Hoan <na-hoan@jinso.co.jp> wrote: > > From: Hoan Nguyen An <na-hoan@jinso.co.jp> > > > > Add PWM-2 channel(CN28 - pin30) support for Salvator-X > > Thanks for your patch! > > Please explain why this is useful. Usually we do not enable random functionality > on expansion connectors. > In this case, this even has an (undocumented) impact on on-board devices, > as the signal is also connected to the BD9571MWV PMIC. > (Perhaps that was the actual intention of this patch? ;-) If yes, > please explain) > Thanks! > Gr{oetje,eeting}s, > Geert > On this issue, with H3/M3 SoC there are 7 PWM channels but only 2 channels are supported: PWM1, PWM2. While PWM1 is connected to CN19 for LVDS service. So only remaining PWM2, I think simple, if you want to generate a signal with variable frequency and pulse width using M3/H3 (I used for testting Addition Tasks) then forced to use PWM2. Although I'm not sure the H3/M3 boards are not purposeful to use the PWM functions. Thanks you! Hoan
Dear Geert-san, Thank you very much for your comments! CC: Simon-san > Hi Hoan, > > On Wed, Aug 29, 2018 at 11:33 AM Nguyen An Hoan <na-hoan@jinso.co.jp> wrote: > > From: Hoan Nguyen An <na-hoan@jinso.co.jp> > > > > Add PWM-2 channel(CN28 - pin30) support for Salvator-X > > Thanks for your patch! > > Please explain why this is useful. Usually we do not enable random functionality > on expansion connectors. > In this case, this even has an (undocumented) impact on on-board devices, > as the signal is also connected to the BD9571MWV PMIC. > (Perhaps that was the actual intention of this patch? ;-) If yes, > please explain) > Thanks! > Gr{oetje,eeting}s, > Geert > On this issue, with H3/M3 SoC there are 7 PWM channels but only 2 channels are supported: PWM1, PWM2. While PWM1 is connected to CN19 for LVDS service. So only remaining PWM2, I think simple, if you want to generate a signal with variable frequency and pulse width using M3/H3 (I used for testting Addition Tasks) then forced to use PWM2. Although I'm not sure the H3/M3 boards are not purposeful to use the PWM functions. Thanks you! Hoan
diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi index 7d3d866..1234f91 100644 --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi @@ -572,6 +572,11 @@ function = "pwm1"; }; + pwm2_pins: pwm2 { + groups = "pwm2_a"; + function = "pwm2"; + }; + scif1_pins: scif1 { groups = "scif1_data_a", "scif1_ctrl"; function = "scif1"; @@ -669,6 +674,12 @@ status = "okay"; }; +&pwm2 { + pinctrl-0 = <&pwm2_pins>; + pinctrl-names = "default"; + status = "okay"; +}; + &rcar_sound { pinctrl-0 = <&sound_pins &sound_clk_pins>; pinctrl-names = "default";