| Message ID | 1562576868-8124-6-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | treewide: modify sh-pfc and add support pwm duty zero | expand |
Hi Shimoda-san, On Mon, Jul 8, 2019 at 11:08 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > Since the rcar_pwm_apply() has already check whehter state->enabled > is not set or not, this patch removes a redundant condition. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> This is completely independent from the rest of the series, and can be applied immediately, right? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Tuesday, August 6, 2019 6:06 PM > > Hi Shimoda-san, > > On Mon, Jul 8, 2019 at 11:08 AM Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > > Since the rcar_pwm_apply() has already check whehter state->enabled > > is not set or not, this patch removes a redundant condition. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thank you for your review! > This is completely independent from the rest of the series, and can be applied > immediately, right? That's right. Best regards, Yoshihiro Shimoda > Gr{oetje,eeting}s, > > Geert > > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hello, On Tue, Aug 06, 2019 at 11:05:30AM +0200, Geert Uytterhoeven wrote: > On Mon, Jul 8, 2019 at 11:08 AM Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > > Since the rcar_pwm_apply() has already check whehter state->enabled > > is not set or not, this patch removes a redundant condition. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > This is completely independent from the rest of the series, and can be applied > immediately, right? The original patch didn't make it into my mailbox. I only see a few replies. Is it only me? https://patchwork.ozlabs.org/project/linux-pwm/list/ doesn't seem to have it either. Best regards Uwe
Hello, > From: Uwe Kleine-König, Sent: Wednesday, August 7, 2019 1:00 AM > > Hello, > > On Tue, Aug 06, 2019 at 11:05:30AM +0200, Geert Uytterhoeven wrote: > > On Mon, Jul 8, 2019 at 11:08 AM Yoshihiro Shimoda > > <yoshihiro.shimoda.uh@renesas.com> wrote: > > > Since the rcar_pwm_apply() has already check whehter state->enabled > > > is not set or not, this patch removes a redundant condition. > > > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > This is completely independent from the rest of the series, and can be applied > > immediately, right? > > The original patch didn't make it into my mailbox. I only see a few > replies. Is it only me? > https://patchwork.ozlabs.org/project/linux-pwm/list/ doesn't seem to > have it either. I don't know why but, linux-renesas-soc ML only got the patch series. https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=143129 JFYI, but I submitted another patch yesterday, and it seemed to be archived on all MLs: https://www.spinics.net/lists/stable/msg322085.html https://lkml.org/lkml/2019/8/6/274 https://patchwork.kernel.org/patch/11078469/ Best regards, Yoshihiro Shimoda > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | http://www.pengutronix.de/ |
Hello, On Mon, Jul 08, 2019 at 06:07:46PM +0900, Yoshihiro Shimoda wrote: > Since the rcar_pwm_apply() has already check whehter state->enabled > is not set or not, this patch removes a redundant condition. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> This patch (and also patch 6 of this series) doesn't seem to have made it to the pwm list and pwm patchwork. Best regards Uwe
diff --git a/drivers/pwm/pwm-rcar.c b/drivers/pwm/pwm-rcar.c index 5b2b8ec..c8cd43f 100644 --- a/drivers/pwm/pwm-rcar.c +++ b/drivers/pwm/pwm-rcar.c @@ -187,7 +187,7 @@ static int rcar_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, /* The SYNC should be set to 0 even if rcar_pwm_set_counter failed */ rcar_pwm_update(rp, RCAR_PWMCR_SYNC, 0, RCAR_PWMCR); - if (!ret && state->enabled) + if (!ret) ret = rcar_pwm_enable(rp); return ret;
Since the rcar_pwm_apply() has already check whehter state->enabled is not set or not, this patch removes a redundant condition. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/pwm/pwm-rcar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)