From patchwork Mon Jul 8 09:07:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoshihiro Shimoda X-Patchwork-Id: 11034751 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8C9B913B1 for ; Mon, 8 Jul 2019 09:13:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D65A2837D for ; Mon, 8 Jul 2019 09:13:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 719F1284D2; Mon, 8 Jul 2019 09:13:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5C4FE27E63 for ; Mon, 8 Jul 2019 09:13:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728708AbfGHJNo (ORCPT ); Mon, 8 Jul 2019 05:13:44 -0400 Received: from relmlor1.renesas.com ([210.160.252.171]:24098 "EHLO relmlie5.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729726AbfGHJNn (ORCPT ); Mon, 8 Jul 2019 05:13:43 -0400 X-IronPort-AV: E=Sophos;i="5.62,466,1554735600"; d="scan'208";a="20843050" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie5.idc.renesas.com with ESMTP; 08 Jul 2019 18:08:37 +0900 Received: from localhost.localdomain (unknown [10.166.17.210]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 6B3EF4219A70; Mon, 8 Jul 2019 18:08:37 +0900 (JST) From: Yoshihiro Shimoda To: linus.walleij@linaro.org, geert+renesas@glider.be, thierry.reding@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Yoshihiro Shimoda Subject: [PATCH RFC 6/7] pwm: rcar: Add gpio support to output duty zero Date: Mon, 8 Jul 2019 18:07:47 +0900 Message-Id: <1562576868-8124-7-git-send-email-yoshihiro.shimoda.uh@renesas.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1562576868-8124-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> References: <1562576868-8124-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The R-Car SoCs PWM Timer cannot output duty zero. So, this patch adds gpio support to output it. Signed-off-by: Yoshihiro Shimoda --- drivers/pwm/pwm-rcar.c | 36 ++++++++++++++++++++++++++++++++++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-rcar.c b/drivers/pwm/pwm-rcar.c index c8cd43f..1c19a8b 100644 --- a/drivers/pwm/pwm-rcar.c +++ b/drivers/pwm/pwm-rcar.c @@ -7,6 +7,7 @@ #include #include +#include #include #include #include @@ -38,6 +39,7 @@ struct rcar_pwm_chip { struct pwm_chip chip; void __iomem *base; struct clk *clk; + struct gpio_desc *gpio; }; static inline struct rcar_pwm_chip *to_rcar_pwm_chip(struct pwm_chip *chip) @@ -119,8 +121,11 @@ static int rcar_pwm_set_counter(struct rcar_pwm_chip *rp, int div, int duty_ns, ph = tmp & RCAR_PWMCNT_PH0_MASK; /* Avoid prohibited setting */ - if (cyc == 0 || ph == 0) + if (cyc == 0) return -EINVAL; + /* Try to use GPIO to output duty zero */ + if (ph == 0) + return -EAGAIN; rcar_pwm_write(rp, cyc | ph, RCAR_PWMCNT); @@ -157,6 +162,28 @@ static void rcar_pwm_disable(struct rcar_pwm_chip *rp) rcar_pwm_update(rp, RCAR_PWMCR_EN0, 0, RCAR_PWMCR); } +static int rcar_pwm_gpiod_get(struct rcar_pwm_chip *rp) +{ + if (rp->gpio) + return 0; + + rp->gpio = gpiod_get(rp->chip.dev, "renesas,duty-zero", GPIOD_OUT_LOW); + if (!IS_ERR(rp->gpio)) + return 0; + + rp->gpio = NULL; + return -EINVAL; +} + +static void rcar_pwm_gpiod_put(struct rcar_pwm_chip *rp) +{ + if (!rp->gpio) + return; + + gpiod_put(rp->gpio); + rp->gpio = NULL; +} + static int rcar_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, struct pwm_state *state) { @@ -171,6 +198,7 @@ static int rcar_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, if (!state->enabled) { rcar_pwm_disable(rp); + rcar_pwm_gpiod_put(rp); return 0; } @@ -187,8 +215,12 @@ static int rcar_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, /* The SYNC should be set to 0 even if rcar_pwm_set_counter failed */ rcar_pwm_update(rp, RCAR_PWMCR_SYNC, 0, RCAR_PWMCR); - if (!ret) + if (!ret) { ret = rcar_pwm_enable(rp); + rcar_pwm_gpiod_put(rp); + } else if (ret == -EAGAIN) { + ret = rcar_pwm_gpiod_get(rp); + } return ret; }