| Message ID | 1573157463-14070-6-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | Add LCD panel support to iwg20d | expand |
Hi Fabrizio, Thank you for the patch. On Thu, Nov 07, 2019 at 08:11:01PM +0000, Fabrizio Castro wrote: > Add connector type for the etm0700g0dh6 from Emerging Display > Technologies (EDT). > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > --- > v2->v3: > * New patch > --- > drivers/gpu/drm/panel/panel-simple.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 5d48768..82065ff 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1342,6 +1342,7 @@ static const struct panel_desc edt_etm0700g0dh6 = { > }, > .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, > + .connector_type = DRM_MODE_CONNECTOR_PARALLEL, I still think we should have a DRM_MODE_CONNECTOR_PANEL, but regardless, this panel seems to match DRM_MODE_CONNECTOR_DPI. > }; > > static const struct panel_desc edt_etm0700g0bdh6 = {
Hi Laurent, Thank you for your feedback! > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Laurent Pinchart > Sent: 07 November 2019 20:49 > Subject: Re: [PATCH v3 5/7] drm/panel: panel-simple: Add connector type for etm0700g0dh6 > > Hi Fabrizio, > > Thank you for the patch. > > On Thu, Nov 07, 2019 at 08:11:01PM +0000, Fabrizio Castro wrote: > > Add connector type for the etm0700g0dh6 from Emerging Display > > Technologies (EDT). > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > --- > > v2->v3: > > * New patch > > --- > > drivers/gpu/drm/panel/panel-simple.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > index 5d48768..82065ff 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -1342,6 +1342,7 @@ static const struct panel_desc edt_etm0700g0dh6 = { > > }, > > .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > > .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, > > + .connector_type = DRM_MODE_CONNECTOR_PARALLEL, > > I still think we should have a DRM_MODE_CONNECTOR_PANEL, but regardless, > this panel seems to match DRM_MODE_CONNECTOR_DPI. Thank you! I wasn't really sure about which definition to pick, DRM_MODE_CONNECTOR_DPI will surely work just fine. Thanks, Fab > > > }; > > > > static const struct panel_desc edt_etm0700g0bdh6 = { > > -- > Regards, > > Laurent Pinchart
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 5d48768..82065ff 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1342,6 +1342,7 @@ static const struct panel_desc edt_etm0700g0dh6 = { }, .bus_format = MEDIA_BUS_FMT_RGB666_1X18, .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, + .connector_type = DRM_MODE_CONNECTOR_PARALLEL, }; static const struct panel_desc edt_etm0700g0bdh6 = {
Add connector type for the etm0700g0dh6 from Emerging Display Technologies (EDT). Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> --- v2->v3: * New patch --- drivers/gpu/drm/panel/panel-simple.c | 1 + 1 file changed, 1 insertion(+)