| Message ID | 1580323253-3281-3-git-send-email-marian-cristian.rotariu.rb@bp.renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | iwg22d-sodimm: enable RGB LCD panel | expand |
Hi Marian-Cristian, On Wed, Jan 29, 2020 at 7:58 PM Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> wrote: > The two variants of the iW-G22D should be mutually exclusive, therefore > this patch disables the RGB LCD display when the HDMI extension board is > used. > > Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> Shouldn't this be merged with the previous patch, to avoid bisection failures? > --- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts > +++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts > @@ -108,6 +108,19 @@ > }; > }; > > +&lcd_panel { > + status = "disabled"; > + > + /* null reference to get rid of the dtc warning */ > + ports { > + port@0 { > + endpoint { > + remote-endpoint = <0>; > + }; > + }; > + }; > +}; > + > &pfc { > can1_pins: can1 { > groups = "can1_data_b"; > diff --git a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts > index 878113a..444adc6 100644 > --- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts > +++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts > @@ -98,7 +98,7 @@ > pinctrl-names = "default"; > }; > > - lcd { > + lcd_panel: lcd { > compatible = "edt,etm043080dh6gp", "simple-panel"; > power-supply = <&vccq_panel>; Gr{oetje,eeting}s, Geert
Hi Geert, > -----Original Message----- > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc- > owner@vger.kernel.org> On Behalf Of Geert Uytterhoeven > Sent: 02 March 2020 13:50 > To: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>; Chris Paterson > <Chris.Paterson2@renesas.com>; Prabhakar Mahadev Lad > <prabhakar.mahadev-lad.rj@bp.renesas.com> > Subject: Re: [PATCH 2/2] ARM: dts: iwg22d-sodimm: disable lcd for extension > board > > Hi Marian-Cristian, > > On Wed, Jan 29, 2020 at 7:58 PM Marian-Cristian Rotariu <marian- > cristian.rotariu.rb@bp.renesas.com> wrote: > > The two variants of the iW-G22D should be mutually exclusive, > > therefore this patch disables the RGB LCD display when the HDMI > > extension board is used. > > > > Signed-off-by: Marian-Cristian Rotariu > > <marian-cristian.rotariu.rb@bp.renesas.com> > > Shouldn't this be merged with the previous patch, to avoid bisection failures? Ok, I will do that. Best regards, Marian
diff --git a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts index 2aeebfc..cb76469 100644 --- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts +++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts @@ -108,6 +108,19 @@ }; }; +&lcd_panel { + status = "disabled"; + + /* null reference to get rid of the dtc warning */ + ports { + port@0 { + endpoint { + remote-endpoint = <0>; + }; + }; + }; +}; + &pfc { can1_pins: can1 { groups = "can1_data_b"; diff --git a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts index 878113a..444adc6 100644 --- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts +++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts @@ -98,7 +98,7 @@ pinctrl-names = "default"; }; - lcd { + lcd_panel: lcd { compatible = "edt,etm043080dh6gp", "simple-panel"; power-supply = <&vccq_panel>;
The two variants of the iW-G22D should be mutually exclusive, therefore this patch disables the RGB LCD display when the HDMI extension board is used. Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> --- arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts | 13 +++++++++++++ arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-)