| Message ID | 1588542414-14826-11-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Add initial support for R8A7742/RZG1H SoC and iW-RainboW-G21D-Qseven development board support | expand |
On Sun, May 3, 2020 at 11:47 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Add support for iWave RainboW-G21D-Qseven board based on RZ/G1H. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hi Prabhakar, On Sun, May 3, 2020 at 11:47 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Add support for iWave RainboW-G21D-Qseven board based on RZ/G1H. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > --- /dev/null > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts > @@ -0,0 +1,37 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Device Tree Source for the iWave-RZ/G1H Qseven board > + * > + * Copyright (C) 2020 Renesas Electronics Corp. > + */ > + > +/dts-v1/; > +#include "r8a7742-iwg21m.dtsi" > + > +/ { > + model = "iWave Systems RainboW-G21D-Qseven board based on RZ/G1H"; > + compatible = "iwave,g21d", "iwave,g21m", "renesas,r8a7742"; > + > + aliases { > + serial2 = &scifa2; > + }; > + > + chosen { > + bootargs = "ignore_loglevel root=/dev/mmcblk0p1 rw rootwait"; > + stdout-path = "serial2:115200n8"; > + }; > +}; > + > +&pfc { > + scifa2_pins: scifa2 { > + groups = "scifa2_data_c"; Upon second look, I think this group is wrong. While labeled SCIFA2 in the SOM schematics, these signals seem to be connected to a debugging interface. The real UART2 seems to be present on the camera daughter board. Those signals are labeled "SCIFA2" in the camera board schematics, but "SCIF2" in the SOM schematics. This is OK, as "scif2_data" and "scifa2_data" share the same pins, so you can choose either SCIF2 or SCIFA2 to drive them. If I'm right, please change the group, and move all serial2 descriptions to the camera board DTS. > + function = "scifa2"; > + }; > +}; > + > +&scifa2 { > + pinctrl-0 = <&scifa2_pins>; > + pinctrl-names = "default"; > + > + status = "okay"; > +}; Gr{oetje,eeting}s, Geert
Hi Geert, On Fri, Jun 5, 2020 at 1:52 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Sun, May 3, 2020 at 11:47 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > Add support for iWave RainboW-G21D-Qseven board based on RZ/G1H. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > > --- /dev/null > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts > > @@ -0,0 +1,37 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Device Tree Source for the iWave-RZ/G1H Qseven board > > + * > > + * Copyright (C) 2020 Renesas Electronics Corp. > > + */ > > + > > +/dts-v1/; > > +#include "r8a7742-iwg21m.dtsi" > > + > > +/ { > > + model = "iWave Systems RainboW-G21D-Qseven board based on RZ/G1H"; > > + compatible = "iwave,g21d", "iwave,g21m", "renesas,r8a7742"; > > + > > + aliases { > > + serial2 = &scifa2; > > + }; > > + > > + chosen { > > + bootargs = "ignore_loglevel root=/dev/mmcblk0p1 rw rootwait"; > > + stdout-path = "serial2:115200n8"; > > + }; > > +}; > > + > > +&pfc { > > + scifa2_pins: scifa2 { > > + groups = "scifa2_data_c"; > > Upon second look, I think this group is wrong. While labeled SCIFA2 in > the SOM schematics, these signals seem to be connected to a debugging > interface. > > The real UART2 seems to be present on the camera daughter board. Those > signals are labeled "SCIFA2" in the camera board schematics, but "SCIF2" > in the SOM schematics. This is OK, as "scif2_data" and "scifa2_data" > share the same pins, so you can choose either SCIF2 or SCIFA2 to drive > them. > > If I'm right, please change the group, and move all serial2 descriptions > to the camera board DTS. > I took a closer look at the schematics, SCIFA2 is connected to the debug interface similarly on G1M where SCIF0 is connected to the debug interface. I will send the user guide privately which should clarify the serial interfaces on the board. Cheers, --Prabhakar > > + function = "scifa2"; > > + }; > > +}; > > + > > +&scifa2 { > > + pinctrl-0 = <&scifa2_pins>; > > + pinctrl-names = "default"; > > + > > + status = "okay"; > > +}; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index e8dd99201397..ed3376cce638 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -917,6 +917,7 @@ dtb-$(CONFIG_ARCH_RENESAS) += \ r7s9210-rza2mevb.dtb \ r8a73a4-ape6evm.dtb \ r8a7740-armadillo800eva.dtb \ + r8a7742-iwg21d-q7.dtb \ r8a7743-iwg20d-q7.dtb \ r8a7743-iwg20d-q7-dbcm-ca.dtb \ r8a7743-sk-rzg1m.dtb \ diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts new file mode 100644 index 000000000000..1f5c35c66d91 --- /dev/null +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts @@ -0,0 +1,37 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Device Tree Source for the iWave-RZ/G1H Qseven board + * + * Copyright (C) 2020 Renesas Electronics Corp. + */ + +/dts-v1/; +#include "r8a7742-iwg21m.dtsi" + +/ { + model = "iWave Systems RainboW-G21D-Qseven board based on RZ/G1H"; + compatible = "iwave,g21d", "iwave,g21m", "renesas,r8a7742"; + + aliases { + serial2 = &scifa2; + }; + + chosen { + bootargs = "ignore_loglevel root=/dev/mmcblk0p1 rw rootwait"; + stdout-path = "serial2:115200n8"; + }; +}; + +&pfc { + scifa2_pins: scifa2 { + groups = "scifa2_data_c"; + function = "scifa2"; + }; +}; + +&scifa2 { + pinctrl-0 = <&scifa2_pins>; + pinctrl-names = "default"; + + status = "okay"; +};