| Message ID | 1588542414-14826-5-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Add initial support for R8A7742/RZG1H SoC and iW-RainboW-G21D-Qseven development board support | expand |
Hi Prabhakar, On Sun, May 3, 2020 at 11:47 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Add support for r8a7742 SoC. Renesas RZ/G1H (R8A7742) MMCIF is identical > to the R-Car Gen2 family. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> Thanks for your patch! > --- a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt > +++ b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt > @@ -11,6 +11,7 @@ Required properties: > - "renesas,mmcif-r7s72100" for the MMCIF found in r7s72100 SoCs > - "renesas,mmcif-r8a73a4" for the MMCIF found in r8a73a4 SoCs > - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs > + - "renesas,mmcif-r8a7742" for the MMCIF found in r8a7742 SoCs > - "renesas,mmcif-r8a7743" for the MMCIF found in r8a7743 SoCs > - "renesas,mmcif-r8a7744" for the MMCIF found in r8a7744 SoCs > - "renesas,mmcif-r8a7745" for the MMCIF found in r8a7745 SoCs Please also update the paragraph stating the number of interrupts (1 for r8a7742). With that fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hi Geert, Thank you for the review. On Mon, May 4, 2020 at 11:26 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Sun, May 3, 2020 at 11:47 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > Add support for r8a7742 SoC. Renesas RZ/G1H (R8A7742) MMCIF is identical > > to the R-Car Gen2 family. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt > > +++ b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt > > @@ -11,6 +11,7 @@ Required properties: > > - "renesas,mmcif-r7s72100" for the MMCIF found in r7s72100 SoCs > > - "renesas,mmcif-r8a73a4" for the MMCIF found in r8a73a4 SoCs > > - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs > > + - "renesas,mmcif-r8a7742" for the MMCIF found in r8a7742 SoCs > > - "renesas,mmcif-r8a7743" for the MMCIF found in r8a7743 SoCs > > - "renesas,mmcif-r8a7744" for the MMCIF found in r8a7744 SoCs > > - "renesas,mmcif-r8a7745" for the MMCIF found in r8a7745 SoCs > > Please also update the paragraph stating the number of interrupts > (1 for r8a7742). > Oops missed that, will fixup and post a v3. > With that fixed: > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Thanks for the Ack. Cheers, --Prabhakar > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt index c064af5838aa..42c703e246b9 100644 --- a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +++ b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt @@ -11,6 +11,7 @@ Required properties: - "renesas,mmcif-r7s72100" for the MMCIF found in r7s72100 SoCs - "renesas,mmcif-r8a73a4" for the MMCIF found in r8a73a4 SoCs - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs + - "renesas,mmcif-r8a7742" for the MMCIF found in r8a7742 SoCs - "renesas,mmcif-r8a7743" for the MMCIF found in r8a7743 SoCs - "renesas,mmcif-r8a7744" for the MMCIF found in r8a7744 SoCs - "renesas,mmcif-r8a7745" for the MMCIF found in r8a7745 SoCs