| Message ID | 1628840413-21880-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | pinctrl: renesas: Remove unneeded semicolon | expand |
Hi Jiapeng, On Fri, Aug 13, 2021 at 9:40 AM Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote: > Fix the following coccicheck warnings: > > ./drivers/pinctrl/renesas/pinctrl-rzg2l.c:1124:2-3: Unneeded semicolon. > ./drivers/pinctrl/renesas/pinctrl-rzg2l.c:1114:2-3: Unneeded semicolon. > ./drivers/pinctrl/renesas/pinctrl-rzg2l.c:1080:2-3: Unneeded semicolon. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Thanks! Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> As this fixes the top commit in my renesas-pinctrl-for-v5.15 branch, for which I'm about to send a PR soon, I will fold this into the offending commit. Gr{oetje,eeting}s, Geert
diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c index 9efe3f2..dbf2f52 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c @@ -1077,7 +1077,7 @@ static int rzg2l_pinctrl_register(struct rzg2l_pinctrl *pctrl) if (ret) { dev_err(pctrl->dev, "failed to add GPIO chip: %i\n", ret); return ret; - }; + } return 0; } @@ -1111,7 +1111,7 @@ static int rzg2l_pinctrl_probe(struct platform_device *pdev) ret = PTR_ERR(pctrl->clk); dev_err(pctrl->dev, "failed to get GPIO clk : %i\n", ret); return ret; - }; + } spin_lock_init(&pctrl->lock); @@ -1121,7 +1121,7 @@ static int rzg2l_pinctrl_probe(struct platform_device *pdev) if (ret) { dev_err(pctrl->dev, "failed to enable GPIO clk: %i\n", ret); return ret; - }; + } ret = devm_add_action_or_reset(&pdev->dev, rzg2l_pinctrl_clk_disable, pctrl->clk);
Fix the following coccicheck warnings: ./drivers/pinctrl/renesas/pinctrl-rzg2l.c:1124:2-3: Unneeded semicolon. ./drivers/pinctrl/renesas/pinctrl-rzg2l.c:1114:2-3: Unneeded semicolon. ./drivers/pinctrl/renesas/pinctrl-rzg2l.c:1080:2-3: Unneeded semicolon. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/pinctrl/renesas/pinctrl-rzg2l.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)