| Message ID | 20170123141349.29844-1-chris.brandt@renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5786ac14239a0809ca13e6a6f77147e6bb04aa29 |
| Delegated to: | Simon Horman |
| Headers | show |
On Mon, Jan 23, 2017 at 3:13 PM, Chris Brandt <chris.brandt@renesas.com> wrote: > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Mon, Jan 23, 2017 at 04:12:16PM +0100, Geert Uytterhoeven wrote: > On Mon, Jan 23, 2017 at 3:13 PM, Chris Brandt <chris.brandt@renesas.com> wrote: > > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> > > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be> > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Should this be queued up as a fix for v4.10 with the following tag? Fixes: 887862227ba3 ("ARM: dts: r7s72100: add mmcif to device tree")
On Tuesday, January 24, 2017, Simon Horman wrote: > On Mon, Jan 23, 2017 at 04:12:16PM +0100, Geert Uytterhoeven wrote: > > On Mon, Jan 23, 2017 at 3:13 PM, Chris Brandt <chris.brandt@renesas.com> > wrote: > > > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> > > > > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Should this be queued up as a fix for v4.10 with the following tag? > > Fixes: 887862227ba3 ("ARM: dts: r7s72100: add mmcif to device tree") I assume it can. I'm not sure how it effect the driver one way good or bad (that's a question for Geert I think). SDHI for r7s72100 needs it too, I just didn't send that yet because my other fix will cause a merge conflict because it is modifying the same line. But, that patch is taking longer than I expected. My guess is that power-domains is for runtime power management...which seems to be a sore subject for r7s72100 at this point. Chris
On Tue, Jan 24, 2017 at 04:32:30PM +0000, Chris Brandt wrote: > On Tuesday, January 24, 2017, Simon Horman wrote: > > On Mon, Jan 23, 2017 at 04:12:16PM +0100, Geert Uytterhoeven wrote: > > > On Mon, Jan 23, 2017 at 3:13 PM, Chris Brandt <chris.brandt@renesas.com> > > wrote: > > > > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> > > > > > > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > Should this be queued up as a fix for v4.10 with the following tag? > > > > Fixes: 887862227ba3 ("ARM: dts: r7s72100: add mmcif to device tree") > > I assume it can. I'm not sure how it effect the driver one way good or bad > (that's a question for Geert I think). > SDHI for r7s72100 needs it too, I just didn't send that yet because my other > fix will cause a merge conflict because it is modifying the same line. But, > that patch is taking longer than I expected. > > My guess is that power-domains is for runtime power management...which seems > to be a sore subject for r7s72100 at this point. Geert tells me that this should not have a runtime effect. Accordingly, I will queued it up for v4.11.
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi index 3dd427d..354f4b6 100644 --- a/arch/arm/boot/dts/r7s72100.dtsi +++ b/arch/arm/boot/dts/r7s72100.dtsi @@ -466,6 +466,7 @@ GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp8_clks R7S72100_CLK_MMCIF>; + power-domains = <&cpg_clocks>; reg-io-width = <4>; bus-width = <8>; status = "disabled";
Signed-off-by: Chris Brandt <chris.brandt@renesas.com> --- arch/arm/boot/dts/r7s72100.dtsi | 1 + 1 file changed, 1 insertion(+)