From patchwork Sun Aug 20 12:40:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugeniu Rosca X-Patchwork-Id: 9911125 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2E511601D4 for ; Sun, 20 Aug 2017 12:41:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 15E6C2871B for ; Sun, 20 Aug 2017 12:41:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0AADC28763; Sun, 20 Aug 2017 12:41:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 71ABF28749 for ; Sun, 20 Aug 2017 12:41:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752856AbdHTMkv (ORCPT ); Sun, 20 Aug 2017 08:40:51 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:34359 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752839AbdHTMku (ORCPT ); Sun, 20 Aug 2017 08:40:50 -0400 Received: by mail-wr0-f195.google.com with SMTP id p14so7945035wrg.1; Sun, 20 Aug 2017 05:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=wap7/BZ0wgj2gOTCuECw+tvUeiQF536hyxc2XBODbgc=; b=JEo9V1+gCYVFcgmoJBkAiStayYvcChkP03dCzekeoj2ZiZ3WRN2iN1HrtBdWZYo5nl PM8VE+6FDyu+lhaJK523ACOeJNML5+qbkpmQ4j1GJ+R+3n2w0atrUQhlK6itL3jUPM7h Rlotr/qt9UTILZpVJBibOPzTMBEeJmmwHI/ESno19CIqI9qRdt8Bj5ef79CuEvWDxhO0 JwsirfrVeHHlKfIpAtOnCkmKJMjujawyh0OoD8YvggPB1soIqGb8JkYoH0zSoEHvdd5g UNXSvlrKa/lSSC+QqgGlZXPOAJlJtLddVgW71ejTerEshXh3Pk9miwwu8RGXPMXHJBhf ITOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wap7/BZ0wgj2gOTCuECw+tvUeiQF536hyxc2XBODbgc=; b=S/LJTGWZgEJB4UqFgpui0TSKbdh3JmeZ4JPTPiKbDRMdZu7mJObKNDYSmm6+pg7G/Q Kwmb24cNJzt0hZ1cINbHEP/VZ34y/d9qV9zWftIX+/g5sHr4OOKEQB17dUL92vvP+6Ke RQ2b2JO4JtqJ6y6LcqUwwDDlhCq3bIBLHM2B9kXFVSQErA50Jpi8lX+J30Aga/2Q9+ND dMiN92shr3Sl2jNBxU5sE+cPzPMD7Xod0o7BnI+K0d4MnXhuDN6M8CjGtWCKH+SRxYmN lMcRyLDhPgQTvKbuE3Cask4xvzKdyNvOttkroJ+L7O3r4LgI6iFgo6QiF+bWyAS2Lp0U XVpQ== X-Gm-Message-State: AHYfb5gNcxNwIapyvv9JKLn65+FlmErQN9oDbnw81y2cXiD7chKE4owx NnW2objQ4h4cKA== X-Received: by 10.80.226.133 with SMTP id p5mr9751710edl.221.1503232849523; Sun, 20 Aug 2017 05:40:49 -0700 (PDT) Received: from erosca.home ([2a02:8108:91c0:4bcc:1945:e3c9:914a:40d5]) by smtp.gmail.com with ESMTPSA id u10sm5151500eda.93.2017.08.20.05.40.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 20 Aug 2017 05:40:48 -0700 (PDT) From: Eugeniu Rosca X-Google-Original-From: Eugeniu Rosca To: laurent.pinchart@ideasonboard.com, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Eugeniu Rosca Subject: [PATCH] v4l: vsp1: Fix function declaration/definition mismatch Date: Sun, 20 Aug 2017 14:40:06 +0200 Message-Id: <20170820124006.4256-1-rosca.eugeniu@gmail.com> X-Mailer: git-send-email 2.14.1 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Eugeniu Rosca Cppcheck v1.81 complains that the parameter names of certain vsp1 functions don't match between declaration and definition. Fix this. No functional change is confirmed by the empty delta between the disassembled object files before and after the change. Signed-off-by: Eugeniu Rosca Reviewed-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_entity.h | 5 +++-- drivers/media/platform/vsp1/vsp1_hgo.h | 2 +- drivers/media/platform/vsp1/vsp1_hgt.h | 2 +- drivers/media/platform/vsp1/vsp1_uds.h | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_entity.h b/drivers/media/platform/vsp1/vsp1_entity.h index c169a060b6d2..1087d7e5c126 100644 --- a/drivers/media/platform/vsp1/vsp1_entity.h +++ b/drivers/media/platform/vsp1/vsp1_entity.h @@ -161,7 +161,8 @@ int vsp1_subdev_enum_mbus_code(struct v4l2_subdev *subdev, int vsp1_subdev_enum_frame_size(struct v4l2_subdev *subdev, struct v4l2_subdev_pad_config *cfg, struct v4l2_subdev_frame_size_enum *fse, - unsigned int min_w, unsigned int min_h, - unsigned int max_w, unsigned int max_h); + unsigned int min_width, unsigned int min_height, + unsigned int max_width, + unsigned int max_height); #endif /* __VSP1_ENTITY_H__ */ diff --git a/drivers/media/platform/vsp1/vsp1_hgo.h b/drivers/media/platform/vsp1/vsp1_hgo.h index c6c0b7a80e0c..76a9cf97b9d3 100644 --- a/drivers/media/platform/vsp1/vsp1_hgo.h +++ b/drivers/media/platform/vsp1/vsp1_hgo.h @@ -40,6 +40,6 @@ static inline struct vsp1_hgo *to_hgo(struct v4l2_subdev *subdev) } struct vsp1_hgo *vsp1_hgo_create(struct vsp1_device *vsp1); -void vsp1_hgo_frame_end(struct vsp1_entity *hgo); +void vsp1_hgo_frame_end(struct vsp1_entity *entity); #endif /* __VSP1_HGO_H__ */ diff --git a/drivers/media/platform/vsp1/vsp1_hgt.h b/drivers/media/platform/vsp1/vsp1_hgt.h index 83f2e130942a..37139d54b6c8 100644 --- a/drivers/media/platform/vsp1/vsp1_hgt.h +++ b/drivers/media/platform/vsp1/vsp1_hgt.h @@ -37,6 +37,6 @@ static inline struct vsp1_hgt *to_hgt(struct v4l2_subdev *subdev) } struct vsp1_hgt *vsp1_hgt_create(struct vsp1_device *vsp1); -void vsp1_hgt_frame_end(struct vsp1_entity *hgt); +void vsp1_hgt_frame_end(struct vsp1_entity *entity); #endif /* __VSP1_HGT_H__ */ diff --git a/drivers/media/platform/vsp1/vsp1_uds.h b/drivers/media/platform/vsp1/vsp1_uds.h index 7bf3cdcffc65..9c7f8497b5da 100644 --- a/drivers/media/platform/vsp1/vsp1_uds.h +++ b/drivers/media/platform/vsp1/vsp1_uds.h @@ -35,7 +35,7 @@ static inline struct vsp1_uds *to_uds(struct v4l2_subdev *subdev) struct vsp1_uds *vsp1_uds_create(struct vsp1_device *vsp1, unsigned int index); -void vsp1_uds_set_alpha(struct vsp1_entity *uds, struct vsp1_dl_list *dl, +void vsp1_uds_set_alpha(struct vsp1_entity *entity, struct vsp1_dl_list *dl, unsigned int alpha); #endif /* __VSP1_UDS_H__ */