| Message ID | 20171116201842.006310882@cogentembedded.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On 11/16/2017 11:18 PM, Sergei Shtylyov wrote: > Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor > Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x: Later, of course. Could be fixed while committing, I guess? > add onsemi,pca9654 id") made use of another, undocumented vendor prefix. > Since such prefix doesn't seem to be used in any device trees, I think we > can just fix the "compatible" string in the driver and the bindings and be > done with that... > > Fixes: 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id") > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> [...] MBR, Sergei
Hi Sergei, On Thu, Nov 16, 2017 at 9:18 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor > Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x: > add onsemi,pca9654 id") made use of another, undocumented vendor prefix. Ouch... > Since such prefix doesn't seem to be used in any device trees, I think we > can just fix the "compatible" string in the driver and the bindings and be > done with that... > > Fixes: 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id") > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > The patch is against the 'fixes' branch of LinusW's 'linux-gpio.git' repo. > > Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 2 +- > drivers/gpio/gpio-pca953x.c | 2 +- There's another (different) one in Documentation/devicetree/bindings/misc/idt_89hpesx.txt Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 11/17/2017 12:06 PM, Geert Uytterhoeven wrote: >> Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor >> Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x: >> add onsemi,pca9654 id") made use of another, undocumented vendor prefix. > > Ouch... > >> Since such prefix doesn't seem to be used in any device trees, I think we >> can just fix the "compatible" string in the driver and the bindings and be >> done with that... >> >> Fixes: 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id") >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >> --- >> The patch is against the 'fixes' branch of LinusW's 'linux-gpio.git' repo. >> >> Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 2 +- >> drivers/gpio/gpio-pca953x.c | 2 +- > > There's another (different) one in > Documentation/devicetree/bindings/misc/idt_89hpesx.txt Saw that. Do you think it also should be fixed (in this patch)? > Gr{oetje,eeting}s, > > Geert MBR, Sergei
On Fri, Nov 17, 2017 at 01:47:04PM +0300, Sergei Shtylyov wrote: > On 11/17/2017 12:06 PM, Geert Uytterhoeven wrote: > > > > Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor > > > Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x: > > > add onsemi,pca9654 id") made use of another, undocumented vendor prefix. > > > > Ouch... > > > > > Since such prefix doesn't seem to be used in any device trees, I think we > > > can just fix the "compatible" string in the driver and the bindings and be > > > done with that... > > > > > > Fixes: 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id") > > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > > > > > --- > > > The patch is against the 'fixes' branch of LinusW's 'linux-gpio.git' repo. > > > > > > Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 2 +- > > > drivers/gpio/gpio-pca953x.c | 2 +- > > > > There's another (different) one in > > Documentation/devicetree/bindings/misc/idt_89hpesx.txt > > Saw that. Do you think it also should be fixed (in this patch)? IMO, separate.
On Thu, Nov 16, 2017 at 11:18:32PM +0300, Sergei Shtylyov wrote: > Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor > Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x: > add onsemi,pca9654 id") made use of another, undocumented vendor prefix. > Since such prefix doesn't seem to be used in any device trees, I think we > can just fix the "compatible" string in the driver and the bindings and be > done with that... > > Fixes: 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id") > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > The patch is against the 'fixes' branch of LinusW's 'linux-gpio.git' repo. > > Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 2 +- > drivers/gpio/gpio-pca953x.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Acked-by: Rob Herring <robh@kernel.org>
On Thu, Nov 16, 2017 at 9:18 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor > Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x: > add onsemi,pca9654 id") made use of another, undocumented vendor prefix. > Since such prefix doesn't seem to be used in any device trees, I think we > can just fix the "compatible" string in the driver and the bindings and be > done with that... > > Fixes: 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id") > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Patch applied with Rob's ACK. Thanks for spotting this in time. Yours, Linus Walleij
Index: linux-gpio/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt =================================================================== --- linux-gpio.orig/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt +++ linux-gpio/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt @@ -27,7 +27,7 @@ Required properties: ti,tca6424 ti,tca9539 ti,tca9554 - onsemi,pca9654 + onnn,pca9654 exar,xra1202 Optional properties: Index: linux-gpio/drivers/gpio/gpio-pca953x.c =================================================================== --- linux-gpio.orig/drivers/gpio/gpio-pca953x.c +++ linux-gpio/drivers/gpio/gpio-pca953x.c @@ -947,7 +947,7 @@ static const struct of_device_id pca953x { .compatible = "ti,tca6416", .data = OF_953X(16, PCA_INT), }, { .compatible = "ti,tca6424", .data = OF_953X(24, PCA_INT), }, - { .compatible = "onsemi,pca9654", .data = OF_953X( 8, PCA_INT), }, + { .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), }, { .compatible = "exar,xra1202", .data = OF_953X( 8, 0), }, { }
Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id") made use of another, undocumented vendor prefix. Since such prefix doesn't seem to be used in any device trees, I think we can just fix the "compatible" string in the driver and the bindings and be done with that... Fixes: 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id") Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- The patch is against the 'fixes' branch of LinusW's 'linux-gpio.git' repo. Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 2 +- drivers/gpio/gpio-pca953x.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)