From patchwork Fri Dec 15 16:06:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 10115455 X-Patchwork-Delegate: horms@verge.net.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8B2766019C for ; Fri, 15 Dec 2017 16:06:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7AA1228F63 for ; Fri, 15 Dec 2017 16:06:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6FACC2928A; Fri, 15 Dec 2017 16:06:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0953029289 for ; Fri, 15 Dec 2017 16:06:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932359AbdLOQGP (ORCPT ); Fri, 15 Dec 2017 11:06:15 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:58514 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932480AbdLOQGO (ORCPT ); Fri, 15 Dec 2017 11:06:14 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 903A280D; Fri, 15 Dec 2017 08:06:14 -0800 (PST) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 60F2B3F4FF; Fri, 15 Dec 2017 08:06:14 -0800 (PST) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id B49DB1AE5125; Fri, 15 Dec 2017 16:06:23 +0000 (GMT) Date: Fri, 15 Dec 2017 16:06:23 +0000 From: Will Deacon To: Geert Uytterhoeven Cc: Dave Martin , Ard Biesheuvel , Catalin Marinas , Linux Kernel Mailing List , Linux-Renesas , Alex =?iso-8859-1?Q?Benn=E9e?= , "linux-arm-kernel@lists.infradead.org" Subject: Re: arm64: unhandled level 0 translation fault Message-ID: <20171215160623.GQ25650@arm.com> References: <20171214152431.GC12608@e103592.cambridge.arm.com> <20171215112343.GR22781@e103592.cambridge.arm.com> <20171215142732.GL25650@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Dec 15, 2017 at 04:59:28PM +0100, Geert Uytterhoeven wrote: > On Fri, Dec 15, 2017 at 3:27 PM, Will Deacon wrote: > > On Fri, Dec 15, 2017 at 02:30:00PM +0100, Geert Uytterhoeven wrote: > >> On Fri, Dec 15, 2017 at 12:23 PM, Dave Martin wrote: > >> > The two important differences here seem to be > >> > > >> > 1) Staging the state via current->thread.fpsimd_state instead of loading > >> > directly: > >> > > >> > - fpsimd_load_state(state); > >> > + current->thread.fpsimd_state = *state; > >> > + fpsimd_load_state(¤t->thread.fpsimd_state); > >> > >> The change above introduces the breakage. > > > > I finally managed to reproduce this, but only by using the exact same > > compiler as Geert: > > > > https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/x86_64-gcc-4.9.0-nolibc_aarch64-linux.tar.xz > > > > I then reliably see the problem if I run: > > > > # /usr/bin/update-ca-certificates > > /usr/sbin/... ? > > > from Debian Jessie. > > Funny, I've just got both > > *** Error in `/bin/sh': free(): invalid pointer: 0x0000aaaac17d4988 *** > > and > > mountall.sh[2172]: unhandled level 0 translation fault (11) at > 0x0000004d, esr 0x92000004, in dash[aaaace7e5000+1a000] > > during boot up, but I can't get update-ca-certificates to fail... Can you try the diff below, please? Will --->8 diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c index 540a1e010eb5..fae81f7964b4 100644 --- a/arch/arm64/kernel/fpsimd.c +++ b/arch/arm64/kernel/fpsimd.c @@ -1043,7 +1043,7 @@ void fpsimd_update_current_state(struct fpsimd_state *state) local_bh_disable(); - current->thread.fpsimd_state = *state; + current->thread.fpsimd_state.user_fpsimd = state->user_fpsimd; if (system_supports_sve() && test_thread_flag(TIF_SVE)) fpsimd_to_sve(current);