From patchwork Fri Apr 27 20:25:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 10369817 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3CDCC601BE for ; Fri, 27 Apr 2018 20:25:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E8522580E for ; Fri, 27 Apr 2018 20:25:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 232642859E; Fri, 27 Apr 2018 20:25:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A5FDB2580E for ; Fri, 27 Apr 2018 20:25:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759082AbeD0UZQ (ORCPT ); Fri, 27 Apr 2018 16:25:16 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:60286 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759039AbeD0UZP (ORCPT ); Fri, 27 Apr 2018 16:25:15 -0400 Received: from avalon.bb.dnainternet.fi (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C5DA53E45; Fri, 27 Apr 2018 22:25:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1524860714; bh=8cYqyHHULaAERpgZ6dk0ELbgv4x3d5AjH1proEDIXyA=; h=From:To:Cc:Subject:Date:From; b=qf+QiIA25lAs0CcVgS5PnjNhBA0yI5L2E1kIg7mkHUa+r/LCjT+/DBoJ4UTluuEq6 vaTqm8p7qEUEBxBa+bqJKDR2ztGA4XZzaalmCNZvc61EaCSpe7ZCCw5RTNL0NDZkX/ 9wF4PNW2N+/kz7YY8qE8M5BBgBTT7axVyMESBmuQ= From: Laurent Pinchart To: linux-renesas-soc@vger.kernel.org Cc: Kieran Bingham Subject: [PATCH 1/2] tests: modeset: Disabling connectors explicitly Date: Fri, 27 Apr 2018 23:25:23 +0300 Message-Id: <20180427202524.14225-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.16.1 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP At the end of the modeset test run for each CRTC the test disables the CRTC through the atomic API by setting its ACTIVE property to 0, without touching connector properties. While this work, it doesn't exercise the connector atomic_check disable code path. Disable to connector as well to extend code path coverage. Signed-off-by: Laurent Pinchart --- tests/kms-test-modeset.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/kms-test-modeset.py b/tests/kms-test-modeset.py index f8a78ad2926b..2898b7753503 100755 --- a/tests/kms-test-modeset.py +++ b/tests/kms-test-modeset.py @@ -49,7 +49,13 @@ class ModeSetTest(kmstest.KMSTest): self.logger.log("Atomic mode set complete") self.run(5) - self.atomic_crtc_disable(crtc) + + # Disablee the CRTC and connector explicitly to exercise all + # atomic_check handlers. + req = pykms.AtomicReq(self.card) + req.add(crtc, { 'ACTIVE': False, 'MODE_ID': 0 }) + req.add(connector, 'CRTC_ID', 0) + req.commit_sync(True) if self.flips == 0: self.fail("Page flip not registered")