From patchwork Tue May 29 15:08:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 10436027 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6412560327 for ; Tue, 29 May 2018 15:08:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 531CF28790 for ; Tue, 29 May 2018 15:08:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 464282879E; Tue, 29 May 2018 15:08:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C04D1287A0 for ; Tue, 29 May 2018 15:08:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935469AbeE2PH6 (ORCPT ); Tue, 29 May 2018 11:07:58 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:42412 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935285AbeE2PHz (ORCPT ); Tue, 29 May 2018 11:07:55 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7042580D; Tue, 29 May 2018 08:07:54 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3EA813F557; Tue, 29 May 2018 08:07:54 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id D7FCE1AE51D5; Tue, 29 May 2018 16:08:23 +0100 (BST) Date: Tue, 29 May 2018 16:08:23 +0100 From: Will Deacon To: Sudeep Holla Cc: Geert Uytterhoeven , Catalin Marinas , Jeremy Linton , ACPI Devel Maling List , Mark Rutland , austinwc@codeaurora.org, tnowicki@caviumnetworks.com, Palmer Dabbelt , linux-riscv@lists.infradead.org, Morten.Rasmussen@arm.com, vkilari@codeaurora.org, Lorenzo Pieralisi , jhugo@codeaurora.org, Al Stone , Len Brown , John Garry , wangxiongfeng2@huawei.com, Dietmar Eggemann , Linux ARM , Ard Biesheuvel , Greg KH , "Rafael J. Wysocki" , Linux Kernel Mailing List , Hanjun Guo , Linux-Renesas Subject: Re: [PATCH v9 00/12] Support PPTT for ARM64 Message-ID: <20180529150823.GD17159@arm.com> References: <20180511235807.30834-1-jeremy.linton@arm.com> <20180517170523.h7tuvbzdfluuidcz@armageddon.cambridge.arm.com> <09fb3fe7-d703-43f1-74f7-f8cb5ff1f67a@arm.com> <551905a6-eaa8-97df-06ec-1ceedfbc164f@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <551905a6-eaa8-97df-06ec-1ceedfbc164f@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, May 29, 2018 at 02:18:40PM +0100, Sudeep Holla wrote: > On 29/05/18 12:56, Geert Uytterhoeven wrote: > > On Tue, May 29, 2018 at 1:14 PM, Sudeep Holla wrote: > >> On 29/05/18 11:48, Geert Uytterhoeven wrote: > >>> System supend still works fine on systems with big cores only: > >>> > >>> R-Car H3 ES1.0 (4xCA57 (4xCA53 disabled in firmware)) > >>> R-Car M3-N (2xCA57) > >>> > >>> Reverting this commit fixes the issue for me. > >> > >> I can't find anything that relates to system suspend in these patches > >> unless they are messing with something during CPU hot plug-in back > >> during resume. > > > > It's only the last patch that introduces the breakage. > > > > As specified in the commit log, it won't change any behavior for DT > systems if it's non-NUMA or single node system. So I am still wondering > what could trigger this regression. I wonder if we're somehow giving an uninitialised/invalid NUMA configuration to the scheduler, although I can't see how this would happen. Geert -- if you enable CONFIG_DEBUG_PER_CPU_MAPS=y and apply the diff below do you see anything shouting in dmesg? Will --->8 diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c index dad128ba98bf..e3de033339b4 100644 --- a/arch/arm64/mm/numa.c +++ b/arch/arm64/mm/numa.c @@ -58,7 +58,7 @@ EXPORT_SYMBOL(node_to_cpumask_map); */ const struct cpumask *cpumask_of_node(int node) { - if (WARN_ON(node >= nr_node_ids)) + if (WARN_ON((unsigned)node >= nr_node_ids)) return cpu_none_mask; if (WARN_ON(node_to_cpumask_map[node] == NULL))