| Message ID | 20180914142652.30484-1-kieran.bingham+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [v2,1/2] media: vsp1: Document max_width restriction on SRU | expand |
Hi Kieran, Thank you for the patch. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> On Friday, 14 September 2018 17:26:51 EEST Kieran Bingham wrote: > The SRU is currently restricted to 256 pixels as part of the current > partition algorithm. Document that the actual capability of this > component is 288 pixels, but don't increase the implementation. > > The extended partition algorithm may later choose to utilise a larger > input to support overlapping partitions which will improve the quality > of the output images. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/media/platform/vsp1/vsp1_sru.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/platform/vsp1/vsp1_sru.c > b/drivers/media/platform/vsp1/vsp1_sru.c index d216707f64c9..19f91eb81134 > 100644 > --- a/drivers/media/platform/vsp1/vsp1_sru.c > +++ b/drivers/media/platform/vsp1/vsp1_sru.c > @@ -314,6 +314,11 @@ static unsigned int sru_max_width(struct vsp1_entity > *entity, output = vsp1_entity_get_pad_format(&sru->entity, > sru->entity.config, SRU_PAD_SOURCE); > > + /* > + * The maximum input width of the SRU is 288 input pixels, but 32 > + * pixels are reserved to support overlapping partition windows when > + * scaling. > + */ > if (input->width != output->width) > return 512; > else
diff --git a/drivers/media/platform/vsp1/vsp1_sru.c b/drivers/media/platform/vsp1/vsp1_sru.c index d216707f64c9..19f91eb81134 100644 --- a/drivers/media/platform/vsp1/vsp1_sru.c +++ b/drivers/media/platform/vsp1/vsp1_sru.c @@ -314,6 +314,11 @@ static unsigned int sru_max_width(struct vsp1_entity *entity, output = vsp1_entity_get_pad_format(&sru->entity, sru->entity.config, SRU_PAD_SOURCE); + /* + * The maximum input width of the SRU is 288 input pixels, but 32 + * pixels are reserved to support overlapping partition windows when + * scaling. + */ if (input->width != output->width) return 512; else
The SRU is currently restricted to 256 pixels as part of the current partition algorithm. Document that the actual capability of this component is 288 pixels, but don't increase the implementation. The extended partition algorithm may later choose to utilise a larger input to support overlapping partitions which will improve the quality of the output images. Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_sru.c | 5 +++++ 1 file changed, 5 insertions(+)