diff mbox series

ARM: shmobile: porter: enable R-Car Gen2 regulator quirk

Message ID 20190303194140.11757-1-marek.vasut@gmail.com (mailing list archive)
State Accepted
Commit d5aa84087eadd6f2619628bc9f3d028eeabded0f
Delegated to: Simon Horman
Headers show
Series ARM: shmobile: porter: enable R-Car Gen2 regulator quirk | expand

Commit Message

Marek Vasut March 3, 2019, 7:41 p.m. UTC 
From: Marek Vasut <marek.vasut+renesas@gmail.com>

Porter needs the regulator quirk, just like the other boards.
But unlike the other boards, the Porter uses DA9063L, which
is at 0x5a. Otherwise, DA9063L and DA9210 IRQ line is still
connected to CPU IRQ2 .

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Simon Horman <horms+renesas@verge.net.au>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org
---
 arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Wolfram Sang March 3, 2019, 11:08 p.m. UTC | #1 
On Sun, Mar 03, 2019 at 08:41:40PM +0100, marek.vasut@gmail.com wrote:
> From: Marek Vasut <marek.vasut+renesas@gmail.com>
> 
> Porter needs the regulator quirk, just like the other boards.
> But unlike the other boards, the Porter uses DA9063L, which
> is at 0x5a. Otherwise, DA9063L and DA9210 IRQ line is still
> connected to CPU IRQ2 .
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>

Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Simon Horman March 4, 2019, 10:23 a.m. UTC | #2 
On Mon, Mar 04, 2019 at 12:08:42AM +0100, Wolfram Sang wrote:
> On Sun, Mar 03, 2019 at 08:41:40PM +0100, marek.vasut@gmail.com wrote:
> > From: Marek Vasut <marek.vasut+renesas@gmail.com>
> > 
> > Porter needs the regulator quirk, just like the other boards.
> > But unlike the other boards, the Porter uses DA9063L, which
> > is at 0x5a. Otherwise, DA9063L and DA9210 IRQ line is still
> > connected to CPU IRQ2 .
> > 
> > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> 
> Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks, applied for v5.2.
Geert Uytterhoeven March 4, 2019, 10:43 a.m. UTC | #3 
On Sun, Mar 3, 2019 at 8:41 PM <marek.vasut@gmail.com> wrote:
> From: Marek Vasut <marek.vasut+renesas@gmail.com>
>
> Porter needs the regulator quirk, just like the other boards.
> But unlike the other boards, the Porter uses DA9063L, which
> is at 0x5a. Otherwise, DA9063L and DA9210 IRQ line is still
> connected to CPU IRQ2 .
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c b/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
index dc526ef2e9b3..ee949255ced3 100644
--- a/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
+++ b/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
@@ -1,6 +1,6 @@ 
 // SPDX-License-Identifier: GPL-2.0
 /*
- * R-Car Generation 2 da9063/da9210 regulator quirk
+ * R-Car Generation 2 da9063(L)/da9210 regulator quirk
  *
  * Certain Gen2 development boards have an da9063 and one or more da9210
  * regulators. All of these regulators have their interrupt request lines
@@ -65,6 +65,7 @@  static struct i2c_msg da9210_msg = {
 
 static const struct of_device_id rcar_gen2_quirk_match[] = {
 	{ .compatible = "dlg,da9063", .data = &da9063_msg },
+	{ .compatible = "dlg,da9063l", .data = &da9063_msg },
 	{ .compatible = "dlg,da9210", .data = &da9210_msg },
 	{},
 };
@@ -147,6 +148,7 @@  static int __init rcar_gen2_regulator_quirk(void)
 
 	if (!of_machine_is_compatible("renesas,koelsch") &&
 	    !of_machine_is_compatible("renesas,lager") &&
+	    !of_machine_is_compatible("renesas,porter") &&
 	    !of_machine_is_compatible("renesas,stout") &&
 	    !of_machine_is_compatible("renesas,gose"))
 		return -ENODEV;
@@ -210,7 +212,7 @@  static int __init rcar_gen2_regulator_quirk(void)
 		goto err_free;
 	}
 
-	pr_info("IRQ2 is asserted, installing da9063/da9210 regulator quirk\n");
+	pr_info("IRQ2 is asserted, installing regulator quirk\n");
 
 	bus_register_notifier(&i2c_bus_type, &regulator_quirk_nb);
 	return 0;