| Message ID | 20190516211310.22277-4-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Under Review |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | i2c: improve i2c_new_{device|dummy} | expand |
On 2019-05-16 23:13, Wolfram Sang wrote: > Even though we don't use it yet, we should mark the second I2C address > this device is listening to as used. > > Not yet for upstream until all dependencies are merged! > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Peter Rosin <peda@axentia.se> Cheers, Peter
czw., 16 maj 2019 o 23:13 Wolfram Sang <wsa+renesas@sang-engineering.com> napisał(a): > > Even though we don't use it yet, we should mark the second I2C address > this device is listening to as used. > > Not yet for upstream until all dependencies are merged! > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > drivers/mfd/da9063-i2c.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c > index 455de74c0dd2..2133b09f6e7a 100644 > --- a/drivers/mfd/da9063-i2c.c > +++ b/drivers/mfd/da9063-i2c.c > @@ -221,6 +221,8 @@ static int da9063_i2c_probe(struct i2c_client *i2c, > return ret; > } > > + devm_i2c_new_dummy_device(&i2c->dev, i2c->adapter, i2c->addr + 1); > + > return da9063_device_init(da9063, i2c->irq); > } > > -- > 2.19.1 > Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Hi Wolfram, On 16/05/2019 22:13, Wolfram Sang wrote: > Even though we don't use it yet, we should mark the second I2C address > this device is listening to as used. > > Not yet for upstream until all dependencies are merged! > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> As I reviewed the other two anyway, it seems silly not to add this here :D Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/mfd/da9063-i2c.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c > index 455de74c0dd2..2133b09f6e7a 100644 > --- a/drivers/mfd/da9063-i2c.c > +++ b/drivers/mfd/da9063-i2c.c > @@ -221,6 +221,8 @@ static int da9063_i2c_probe(struct i2c_client *i2c, > return ret; > } > > + devm_i2c_new_dummy_device(&i2c->dev, i2c->adapter, i2c->addr + 1); > + > return da9063_device_init(da9063, i2c->irq); > } > >
diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c index 455de74c0dd2..2133b09f6e7a 100644 --- a/drivers/mfd/da9063-i2c.c +++ b/drivers/mfd/da9063-i2c.c @@ -221,6 +221,8 @@ static int da9063_i2c_probe(struct i2c_client *i2c, return ret; } + devm_i2c_new_dummy_device(&i2c->dev, i2c->adapter, i2c->addr + 1); + return da9063_device_init(da9063, i2c->irq); }
Even though we don't use it yet, we should mark the second I2C address this device is listening to as used. Not yet for upstream until all dependencies are merged! Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/mfd/da9063-i2c.c | 2 ++ 1 file changed, 2 insertions(+)