| Message ID | 20190613155421.16408-5-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | media: don't check retval after our own assignment | expand |
Hi Wolfram, On 13/06/2019 16:54, Wolfram Sang wrote: > No need to check a retval after we assigned a constant to it. With title fixed, Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > drivers/media/dvb-frontends/zd1301_demod.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/dvb-frontends/zd1301_demod.c b/drivers/media/dvb-frontends/zd1301_demod.c > index 96adbba7a82b..bbabe6a2d4f4 100644 > --- a/drivers/media/dvb-frontends/zd1301_demod.c > +++ b/drivers/media/dvb-frontends/zd1301_demod.c > @@ -421,8 +421,7 @@ static int zd1301_demod_i2c_master_xfer(struct i2c_adapter *adapter, > } else { > dev_dbg(&pdev->dev, "unknown msg[0].len=%u\n", msg[0].len); > ret = -EOPNOTSUPP; > - if (ret) > - goto err; > + goto err; > } > > return num; >
diff --git a/drivers/media/dvb-frontends/zd1301_demod.c b/drivers/media/dvb-frontends/zd1301_demod.c index 96adbba7a82b..bbabe6a2d4f4 100644 --- a/drivers/media/dvb-frontends/zd1301_demod.c +++ b/drivers/media/dvb-frontends/zd1301_demod.c @@ -421,8 +421,7 @@ static int zd1301_demod_i2c_master_xfer(struct i2c_adapter *adapter, } else { dev_dbg(&pdev->dev, "unknown msg[0].len=%u\n", msg[0].len); ret = -EOPNOTSUPP; - if (ret) - goto err; + goto err; } return num;
No need to check a retval after we assigned a constant to it. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/media/dvb-frontends/zd1301_demod.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)