| Message ID | 20190912103734.1879-1-kieran.bingham+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 8e66f52288c18db46f4cdcf417cefaaafc6b8608 |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm: dts: renesas: r8a77980: Remove r8a77970 DU compatible | expand |
On Thu, Sep 12, 2019 at 12:38 PM Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> wrote: > The r8a77970 was added with an compatible string for a differnet device different > rather than adding the correct compatible to the driver. > > Remove the unnecessary compatible which is for a different platform. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Please note, this patch should not be integrated until the renesas,du-r8a77980 > compatible string makes it into the DU [0]. Hence postponed. Gr{oetje,eeting}s, Geert
Hi Geert, On 12/09/2019 12:56, Geert Uytterhoeven wrote: > On Thu, Sep 12, 2019 at 12:38 PM Kieran Bingham > <kieran.bingham+renesas@ideasonboard.com> wrote: >> The r8a77970 was added with an compatible string for a differnet device > > different Also s/an/a/ ... Perhaps I should just step away from the keyboard today, I can't seem to type ! hehe >> rather than adding the correct compatible to the driver. >> >> Remove the unnecessary compatible which is for a different platform. >> >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> Please note, this patch should not be integrated until the renesas,du-r8a77980 >> compatible string makes it into the DU [0]. > > Hence postponed. Thanks. -- KB > Gr{oetje,eeting}s, > > Geert >
Hi Kieran, On Thu, Sep 12, 2019 at 2:03 PM Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> wrote: > On 12/09/2019 12:56, Geert Uytterhoeven wrote: > > On Thu, Sep 12, 2019 at 12:38 PM Kieran Bingham > > <kieran.bingham+renesas@ideasonboard.com> wrote: > >> The r8a77970 was added with an compatible string for a differnet device > > > > different > > Also s/an/a/ ... Perhaps I should just step away from the keyboard > today, I can't seem to type ! hehe Doh, finding a first typo increased my adrenaline level, masking the ability to see a second ;-) Gr{oetje,eeting}s, Geert
On Thu, Sep 12, 2019 at 11:37:34AM +0100, Kieran Bingham wrote: > The r8a77970 was added with an compatible string for a differnet device > rather than adding the correct compatible to the driver. > > Remove the unnecessary compatible which is for a different platform. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > --- > Please note, this patch should not be integrated until the renesas,du-r8a77980 > compatible string makes it into the DU [0]. > > [0] https://lore.kernel.org/linux-renesas-soc/a9cc2193-0a18-0490-c273-c64bd70992f5@ideasonboard.com/T/#t > > arch/arm64/boot/dts/renesas/r8a77980.dtsi | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi > index 042f4089e546..c6195377d181 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi > @@ -1487,8 +1487,7 @@ > }; > > du: display@feb00000 { > - compatible = "renesas,du-r8a77980", > - "renesas,du-r8a77970"; > + compatible = "renesas,du-r8a77980"; > reg = <0 0xfeb00000 0 0x80000>; > interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&cpg CPG_MOD 724>; > -- > 2.20.1 >
diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi index 042f4089e546..c6195377d181 100644 --- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi @@ -1487,8 +1487,7 @@ }; du: display@feb00000 { - compatible = "renesas,du-r8a77980", - "renesas,du-r8a77970"; + compatible = "renesas,du-r8a77980"; reg = <0 0xfeb00000 0 0x80000>; interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cpg CPG_MOD 724>;
The r8a77970 was added with an compatible string for a differnet device rather than adding the correct compatible to the driver. Remove the unnecessary compatible which is for a different platform. Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> --- Please note, this patch should not be integrated until the renesas,du-r8a77980 compatible string makes it into the DU [0]. [0] https://lore.kernel.org/linux-renesas-soc/a9cc2193-0a18-0490-c273-c64bd70992f5@ideasonboard.com/T/#t arch/arm64/boot/dts/renesas/r8a77980.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)