| Message ID | 20200405232318.26833-3-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | dt-bindings: display: bridge: Convert bindings used by R-Car DU to YAML | expand |
On Mon, Apr 06, 2020 at 02:23:16AM +0300, Laurent Pinchart wrote: > The simple-bridge driver supports multiple simple or dumb bridges, > covered by different compatible strings but otherwise identical DT > bindings. Some of those bridges have undocumented bindings, while others > are documented in text form in separate files. Group them all in a > single binding and convert it to YAML. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Acked-by: Maxime Ripard <mripard@kernel.org> Maxime
On Mon, Apr 06, 2020 at 02:23:16AM +0300, Laurent Pinchart wrote: > The simple-bridge driver supports multiple simple or dumb bridges, > covered by different compatible strings but otherwise identical DT > bindings. Some of those bridges have undocumented bindings, while others > are documented in text form in separate files. Group them all in a > single binding and convert it to YAML. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > .../bindings/display/bridge/adi,adv7123.txt | 50 ---------- > .../bindings/display/bridge/dumb-vga-dac.txt | 50 ---------- > .../display/bridge/simple-bridge.yaml | 99 +++++++++++++++++++ > .../bindings/display/bridge/ti,ths813x.txt | 51 ---------- > 4 files changed, 99 insertions(+), 151 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/bridge/adi,adv7123.txt > delete mode 100644 Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt > create mode 100644 Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml > delete mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ths813x.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7123.txt b/Documentation/devicetree/bindings/display/bridge/adi,adv7123.txt > deleted file mode 100644 > index a6b2b2b8f3d9..000000000000 > --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7123.txt > +++ /dev/null > @@ -1,50 +0,0 @@ > -Analog Device ADV7123 Video DAC > -------------------------------- > - > -The ADV7123 is a digital-to-analog converter that outputs VGA signals from a > -parallel video input. > - > -Required properties: > - > -- compatible: Should be "adi,adv7123" > - > -Optional properties: > - > -- psave-gpios: Power save control GPIO Not documented in the new schema. Did you intend to change to 'enable-gpios'? Rob
Hi Rob, On Tue, Apr 14, 2020 at 05:00:00PM -0500, Rob Herring wrote: > On Mon, Apr 06, 2020 at 02:23:16AM +0300, Laurent Pinchart wrote: > > The simple-bridge driver supports multiple simple or dumb bridges, > > covered by different compatible strings but otherwise identical DT > > bindings. Some of those bridges have undocumented bindings, while others > > are documented in text form in separate files. Group them all in a > > single binding and convert it to YAML. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > --- > > .../bindings/display/bridge/adi,adv7123.txt | 50 ---------- > > .../bindings/display/bridge/dumb-vga-dac.txt | 50 ---------- > > .../display/bridge/simple-bridge.yaml | 99 +++++++++++++++++++ > > .../bindings/display/bridge/ti,ths813x.txt | 51 ---------- > > 4 files changed, 99 insertions(+), 151 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/display/bridge/adi,adv7123.txt > > delete mode 100644 Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt > > create mode 100644 Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml > > delete mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ths813x.txt > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7123.txt b/Documentation/devicetree/bindings/display/bridge/adi,adv7123.txt > > deleted file mode 100644 > > index a6b2b2b8f3d9..000000000000 > > --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7123.txt > > +++ /dev/null > > @@ -1,50 +0,0 @@ > > -Analog Device ADV7123 Video DAC > > -------------------------------- > > - > > -The ADV7123 is a digital-to-analog converter that outputs VGA signals from a > > -parallel video input. > > - > > -Required properties: > > - > > -- compatible: Should be "adi,adv7123" > > - > > -Optional properties: > > - > > -- psave-gpios: Power save control GPIO > > Not documented in the new schema. Did you intend to change to > 'enable-gpios'? Oops, I forgot to mention that, my bad. The psave GPIO isn't supported by the driver, and isn't used in any upstream DT files, so I thought it would be safe to drop it, and add support it later (possibly through the enable GPIO) if/when needed. I'll mention it in the commit message.
diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7123.txt b/Documentation/devicetree/bindings/display/bridge/adi,adv7123.txt deleted file mode 100644 index a6b2b2b8f3d9..000000000000 --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7123.txt +++ /dev/null @@ -1,50 +0,0 @@ -Analog Device ADV7123 Video DAC -------------------------------- - -The ADV7123 is a digital-to-analog converter that outputs VGA signals from a -parallel video input. - -Required properties: - -- compatible: Should be "adi,adv7123" - -Optional properties: - -- psave-gpios: Power save control GPIO - -Required nodes: - -The ADV7123 has two video ports. Their connections are modeled using the OF -graph bindings specified in Documentation/devicetree/bindings/graph.txt. - -- Video port 0 for DPI input -- Video port 1 for VGA output - - -Example -------- - - adv7123: encoder@0 { - compatible = "adi,adv7123"; - - ports { - #address-cells = <1>; - #size-cells = <0>; - - port@0 { - reg = <0>; - - adv7123_in: endpoint@0 { - remote-endpoint = <&dpi_out>; - }; - }; - - port@1 { - reg = <1>; - - adv7123_out: endpoint@0 { - remote-endpoint = <&vga_connector_in>; - }; - }; - }; - }; diff --git a/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt b/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt deleted file mode 100644 index 164cbb15f04c..000000000000 --- a/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt +++ /dev/null @@ -1,50 +0,0 @@ -Dumb RGB to VGA DAC bridge ---------------------------- - -This binding is aimed for dumb RGB to VGA DAC based bridges that do not require -any configuration. - -Required properties: - -- compatible: Must be "dumb-vga-dac" - -Required nodes: - -This device has two video ports. Their connections are modelled using the OF -graph bindings specified in Documentation/devicetree/bindings/graph.txt. - -- Video port 0 for RGB input -- Video port 1 for VGA output - -Optional properties: -- vdd-supply: Power supply for DAC - -Example -------- - -bridge { - compatible = "dumb-vga-dac"; - #address-cells = <1>; - #size-cells = <0>; - - ports { - #address-cells = <1>; - #size-cells = <0>; - - port@0 { - reg = <0>; - - vga_bridge_in: endpoint { - remote-endpoint = <&tcon0_out_vga>; - }; - }; - - port@1 { - reg = <1>; - - vga_bridge_out: endpoint { - remote-endpoint = <&vga_con_in>; - }; - }; - }; -}; diff --git a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml new file mode 100644 index 000000000000..0880cbf217d5 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml @@ -0,0 +1,99 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/bridge/simple-bridge.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Transparent non-programmable DRM bridges + +maintainers: + - Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> + - Maxime Ripard <mripard@kernel.org> + +description: | + This binding supports transparent non-programmable bridges that don't require + any configuration, with a single input and a single output. + +properties: + compatible: + oneOf: + - items: + - enum: + - ti,ths8134a + - ti,ths8134b + - const: ti,ths8134 + - enum: + - adi,adv7123 + - dumb-vga-dac + - ti,opa362 + - ti,ths8134 + - ti,ths8135 + + ports: + type: object + description: | + This device has two video ports. Their connections are modeled using the + OF graph bindings specified in Documentation/devicetree/bindings/graph.txt. + properties: + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + + port@0: + type: object + description: The bridge input + + port@1: + type: object + description: The bridge output + + required: + - port@0 + - port@1 + + additionalProperties: false + + enable-gpios: + maxItems: 1 + description: GPIO controlling bridge enable + + vdd-supply: + maxItems: 1 + description: Power supply for the bridge + +required: + - compatible + - ports + +additionalProperties: false + +examples: + - | + bridge { + compatible = "ti,ths8134a", "ti,ths8134"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + vga_bridge_in: endpoint { + remote-endpoint = <&tcon0_out_vga>; + }; + }; + + port@1 { + reg = <1>; + + vga_bridge_out: endpoint { + remote-endpoint = <&vga_con_in>; + }; + }; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ths813x.txt b/Documentation/devicetree/bindings/display/bridge/ti,ths813x.txt deleted file mode 100644 index df3d7c1ac09e..000000000000 --- a/Documentation/devicetree/bindings/display/bridge/ti,ths813x.txt +++ /dev/null @@ -1,51 +0,0 @@ -THS8134 and THS8135 Video DAC ------------------------------ - -This is the binding for Texas Instruments THS8134, THS8134A, THS8134B and -THS8135 Video DAC bridges. - -Required properties: - -- compatible: Must be one of - "ti,ths8134" - "ti,ths8134a," "ti,ths8134" - "ti,ths8134b", "ti,ths8134" - "ti,ths8135" - -Required nodes: - -This device has two video ports. Their connections are modelled using the OF -graph bindings specified in Documentation/devicetree/bindings/graph.txt. - -- Video port 0 for RGB input -- Video port 1 for VGA output - -Example -------- - -vga-bridge { - compatible = "ti,ths8135"; - #address-cells = <1>; - #size-cells = <0>; - - ports { - #address-cells = <1>; - #size-cells = <0>; - - port@0 { - reg = <0>; - - vga_bridge_in: endpoint { - remote-endpoint = <&lcdc_out_vga>; - }; - }; - - port@1 { - reg = <1>; - - vga_bridge_out: endpoint { - remote-endpoint = <&vga_con_in>; - }; - }; - }; -};
The simple-bridge driver supports multiple simple or dumb bridges, covered by different compatible strings but otherwise identical DT bindings. Some of those bridges have undocumented bindings, while others are documented in text form in separate files. Group them all in a single binding and convert it to YAML. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- .../bindings/display/bridge/adi,adv7123.txt | 50 ---------- .../bindings/display/bridge/dumb-vga-dac.txt | 50 ---------- .../display/bridge/simple-bridge.yaml | 99 +++++++++++++++++++ .../bindings/display/bridge/ti,ths813x.txt | 51 ---------- 4 files changed, 99 insertions(+), 151 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/bridge/adi,adv7123.txt delete mode 100644 Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt create mode 100644 Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml delete mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ths813x.txt