From patchwork Thu Apr 9 12:12:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 11481691 X-Patchwork-Delegate: kieran@bingham.xyz Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 707EB14DD for ; Thu, 9 Apr 2020 12:12:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 449622078E for ; Thu, 9 Apr 2020 12:12:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="LjwpGwAg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726582AbgDIMMR (ORCPT ); Thu, 9 Apr 2020 08:12:17 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:48746 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725971AbgDIMMR (ORCPT ); Thu, 9 Apr 2020 08:12:17 -0400 Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D6D1E1A40; Thu, 9 Apr 2020 14:12:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1586434334; bh=koKgkFI4J6/xNpng+dPXWyaaFOTxX5vZys0IqcN1p88=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LjwpGwAgc+5mPxNqm06HtNrQCunuW+aIvgsiMw/Dr5ekkp3Zy+naedgQAW459YNRh 6qw1KvyQ2K43DqZT3UqoBIButIkbfFkPOdhmY9z+JV/FrWGt5UpVgImRpgEMsdONeq zh1/zGPBZ1gKPwgoQ8fKcNBujvMiWKjz7V3E+Mec= From: Kieran Bingham To: linux-renesas-soc@vger.kernel.org, Jacopo Mondi , Laurent Pinchart , =?utf-8?q?Niklas_S?= =?utf-8?q?=C3=B6derlund?= , Hyun Kwon , Manivannan Sadhasivam Cc: Kieran Bingham Subject: [PATCH v8 12/13] sqaush! max9286: Describe pad index usage Date: Thu, 9 Apr 2020 13:12:01 +0100 Message-Id: <20200409121202.11130-13-kieran.bingham+renesas@ideasonboard.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200409121202.11130-1-kieran.bingham+renesas@ideasonboard.com> References: <20200409121202.11130-1-kieran.bingham+renesas@ideasonboard.com> MIME-Version: 1.0 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Sakari commented that the sink/source pad indexes are not the same as the OF port numbers. We define them such that they match, so that they can be used interchangably - but of course they are not the 'same thing'. Document this in a comment at the definition of the pad sizings. Signed-off-by: Kieran Bingham --- drivers/media/i2c/max9286.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index 61178ae363d6..6f114756a1e2 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -128,6 +128,10 @@ #define MAX9286_AUTOMASKEN BIT(4) #define MAX9286_MASKLINK(n) ((n) << 0) +/* + * The sink and source pads are created to match the OF graph port numbers so + * that their indexes can be used interchangeably. + */ #define MAX9286_NUM_GMSL 4 #define MAX9286_N_SINKS 4 #define MAX9286_N_PADS 5