| Message ID | 20200514164540.507233-7-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | v4l2-subdev: Introduce [g|s]et_mbus_format pad op | expand |
On 14/05/2020 18:45, Jacopo Mondi wrote: > Deprecate 'g_mbus_config' video operation in favor of the newly > introduced 'get_mbus_config' pad operation. > > Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > include/media/v4l2-subdev.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h > index 8d5f4a255b87..7c77092ae9b7 100644 > --- a/include/media/v4l2-subdev.h > +++ b/include/media/v4l2-subdev.h > @@ -402,7 +402,9 @@ struct v4l2_mbus_frame_desc { > * > * @query_dv_timings: callback for VIDIOC_QUERY_DV_TIMINGS() ioctl handler code. > * > - * @g_mbus_config: get supported mediabus configurations > + * @g_mbus_config: get supported mediabus configurations. This operation is > + * deprecated in favour of the get_mbus_config() pad operation > + * and should not be used by new software. > * > * @s_mbus_config: set a certain mediabus configuration. This operation is added > * for compatibility with soc-camera drivers and should not be used by new > Why not just kill g/s_mbus_config? The soc_camera sensors that use it can just be marked as BROKEN in the Kconfig. I really don't want to keep deprecated stuff around in the kAPI unless absolutely necessary. This series looks good otherwise. Regards, Hans
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h index 8d5f4a255b87..7c77092ae9b7 100644 --- a/include/media/v4l2-subdev.h +++ b/include/media/v4l2-subdev.h @@ -402,7 +402,9 @@ struct v4l2_mbus_frame_desc { * * @query_dv_timings: callback for VIDIOC_QUERY_DV_TIMINGS() ioctl handler code. * - * @g_mbus_config: get supported mediabus configurations + * @g_mbus_config: get supported mediabus configurations. This operation is + * deprecated in favour of the get_mbus_config() pad operation + * and should not be used by new software. * * @s_mbus_config: set a certain mediabus configuration. This operation is added * for compatibility with soc-camera drivers and should not be used by new