diff mbox series

[v2,2/3] dt-bindings: media: i2c: Document 'remote-endpoint'

Message ID 20200714142856.58365-3-jacopo+renesas@jmondi.org (mailing list archive)
State Superseded
Delegated to: Kieran Bingham
Headers show
Series dt-bidings: media: ov5647 bindings + small fix | expand

Commit Message

Jacopo Mondi July 14, 2020, 2:28 p.m. UTC 
Document the 'remote-endpoint' property and add it to the list of required
endpoint properties in imx219 and ov8856 dt-schema binding files.

Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 Documentation/devicetree/bindings/media/i2c/imx219.yaml | 5 +++++
 Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 5 +++++
 2 files changed, 10 insertions(+)

Comments

Laurent Pinchart July 14, 2020, 11:45 p.m. UTC | #1 
Hi Jacopo,

Thank you for the patch.

On Tue, Jul 14, 2020 at 04:28:55PM +0200, Jacopo Mondi wrote:
> Document the 'remote-endpoint' property and add it to the list of required
> endpoint properties in imx219 and ov8856 dt-schema binding files.
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  Documentation/devicetree/bindings/media/i2c/imx219.yaml | 5 +++++
>  Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/imx219.yaml b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> index dfc4d29a4f04..0251e15fe0a7 100644
> --- a/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> @@ -71,8 +71,13 @@ properties:
>              description:
>                Allowed data bus frequencies.
>  
> +          remote-endpoint:
> +            description: |-
> +              phandle to the video receiver input port
> +
>          required:
>            - link-frequencies
> +          - remote-endpoint
>  
>  required:
>    - compatible
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> index 1956b2a32bf4..c1f363bb5aee 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> @@ -84,9 +84,14 @@ properties:
>                Allowed data bus frequencies. 360000000, 180000000 Hz or both
>                are supported by the driver.
>  
> +          remote-endpoint:
> +            description: |-
> +              phandle to the video receiver input port
> +

Extraneous blank line ?

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  
>          required:
>            - link-frequencies
> +          - remote-endpoint
>  
>      required:
>        - endpoint
Jacopo Mondi July 15, 2020, 7:26 a.m. UTC | #2 
Hi Laurent,

On Wed, Jul 15, 2020 at 02:45:35AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Tue, Jul 14, 2020 at 04:28:55PM +0200, Jacopo Mondi wrote:
> > Document the 'remote-endpoint' property and add it to the list of required
> > endpoint properties in imx219 and ov8856 dt-schema binding files.
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > ---
> >  Documentation/devicetree/bindings/media/i2c/imx219.yaml | 5 +++++
> >  Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 5 +++++
> >  2 files changed, 10 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/imx219.yaml b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > index dfc4d29a4f04..0251e15fe0a7 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > @@ -71,8 +71,13 @@ properties:
> >              description:
> >                Allowed data bus frequencies.
> >
> > +          remote-endpoint:
> > +            description: |-
> > +              phandle to the video receiver input port
> > +
> >          required:
> >            - link-frequencies
> > +          - remote-endpoint
> >
> >  required:
> >    - compatible
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > index 1956b2a32bf4..c1f363bb5aee 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > @@ -84,9 +84,14 @@ properties:
> >                Allowed data bus frequencies. 360000000, 180000000 Hz or both
> >                are supported by the driver.
> >
> > +          remote-endpoint:
> > +            description: |-
> > +              phandle to the video receiver input port
> > +
>
> Extraneous blank line ?
>

Yes indeed.

I'll fix and resend with your comments taken in (this and the one in
the previous patch).

Rob, Hans:
Should this go in through the media tree or through rob ?

Thanks
  j

> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> >
> >          required:
> >            - link-frequencies
> > +          - remote-endpoint
> >
> >      required:
> >        - endpoint
>
> --
> Regards,
>
> Laurent Pinchart
Sergei Shtylyov July 15, 2020, 8:10 a.m. UTC | #3 
Hello!

On 14.07.2020 17:28, Jacopo Mondi wrote:

> Document the 'remote-endpoint' property and add it to the list of required
> endpoint properties in imx219 and ov8856 dt-schema binding files.
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>   Documentation/devicetree/bindings/media/i2c/imx219.yaml | 5 +++++
>   Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 5 +++++
>   2 files changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/imx219.yaml b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> index dfc4d29a4f04..0251e15fe0a7 100644
> --- a/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> @@ -71,8 +71,13 @@ properties:
>               description:
>                 Allowed data bus frequencies.
>   
> +          remote-endpoint:
> +            description: |-
> +              phandle to the video receiver input port

    s/to/of/?

> +
>           required:
>             - link-frequencies
> +          - remote-endpoint
>   
>   required:
>     - compatible
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> index 1956b2a32bf4..c1f363bb5aee 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> @@ -84,9 +84,14 @@ properties:
>                 Allowed data bus frequencies. 360000000, 180000000 Hz or both
>                 are supported by the driver.
>   
> +          remote-endpoint:
> +            description: |-
> +              phandle to the video receiver input port

    s/to/of/?

[...]

MBR, Sergei
Jacopo Mondi July 15, 2020, 8:37 a.m. UTC | #4 
Hi Sergei,

On Wed, Jul 15, 2020 at 11:10:15AM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 14.07.2020 17:28, Jacopo Mondi wrote:
>
> > Document the 'remote-endpoint' property and add it to the list of required
> > endpoint properties in imx219 and ov8856 dt-schema binding files.
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > ---
> >   Documentation/devicetree/bindings/media/i2c/imx219.yaml | 5 +++++
> >   Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 5 +++++
> >   2 files changed, 10 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/imx219.yaml b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > index dfc4d29a4f04..0251e15fe0a7 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > @@ -71,8 +71,13 @@ properties:
> >               description:
> >                 Allowed data bus frequencies.
> > +          remote-endpoint:
> > +            description: |-
> > +              phandle to the video receiver input port
>
>    s/to/of/?
>
> > +
> >           required:
> >             - link-frequencies
> > +          - remote-endpoint
> >   required:
> >     - compatible
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > index 1956b2a32bf4..c1f363bb5aee 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > @@ -84,9 +84,14 @@ properties:
> >                 Allowed data bus frequencies. 360000000, 180000000 Hz or both
> >                 are supported by the driver.
> > +          remote-endpoint:
> > +            description: |-
> > +              phandle to the video receiver input port
>
>    s/to/of/?

I see both being used in the existing Documentation.
In the media/ folder it seems like "phandle to" is the only used
version, so I think I will go with that for consistency, unless this
is grammatically wrong and I didn't realize it :)

>
> [...]
>
> MBR, Sergei
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/imx219.yaml b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
index dfc4d29a4f04..0251e15fe0a7 100644
--- a/Documentation/devicetree/bindings/media/i2c/imx219.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
@@ -71,8 +71,13 @@  properties:
             description:
               Allowed data bus frequencies.
 
+          remote-endpoint:
+            description: |-
+              phandle to the video receiver input port
+
         required:
           - link-frequencies
+          - remote-endpoint
 
 required:
   - compatible
diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
index 1956b2a32bf4..c1f363bb5aee 100644
--- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
@@ -84,9 +84,14 @@  properties:
               Allowed data bus frequencies. 360000000, 180000000 Hz or both
               are supported by the driver.
 
+          remote-endpoint:
+            description: |-
+              phandle to the video receiver input port
+
 
         required:
           - link-frequencies
+          - remote-endpoint
 
     required:
       - endpoint