| Message ID | 20210210154908.1227203-1-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | media: i2c: max9271: Add MODULE_* macros | expand |
On Wed, Feb 10, 2021 at 04:49:08PM +0100, Jacopo Mondi wrote: > Since commit 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271 > a module") the max9271 library is built as a module but no > MODULE_*() attributes were specified, causing a build error > due to missing license information. > > ERROR: modpost: missing MODULE_LICENSE() in drivers/media/i2c/max9271.o > > Fix this by adding MODULE attributes to the driver. > > Fixes: 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271 a module") > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Reported-by: Nathan Chancellor <nathan@kernel.org> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > drivers/media/i2c/max9271.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/i2c/max9271.c b/drivers/media/i2c/max9271.c > index c247db569bab..c495582dcff6 100644 > --- a/drivers/media/i2c/max9271.c > +++ b/drivers/media/i2c/max9271.c > @@ -18,6 +18,7 @@ > > #include <linux/delay.h> > #include <linux/i2c.h> > +#include <linux/module.h> > > #include "max9271.h" > > @@ -339,3 +340,7 @@ int max9271_set_translation(struct max9271_device *dev, u8 source, u8 dest) > return 0; > } > EXPORT_SYMBOL_GPL(max9271_set_translation); > + > +MODULE_DESCRIPTION("Maxim MAX9271 GMSL Serializer"); > +MODULE_AUTHOR("Jacopo Mondi"); > +MODULE_LICENSE("GPL v2"); Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Hi Jacopo, Thank you for the patch. On Wed, Feb 10, 2021 at 04:49:08PM +0100, Jacopo Mondi wrote: > Since commit 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271 > a module") the max9271 library is built as a module but no > MODULE_*() attributes were specified, causing a build error > due to missing license information. > > ERROR: modpost: missing MODULE_LICENSE() in drivers/media/i2c/max9271.o > > Fix this by adding MODULE attributes to the driver. > > Fixes: 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271 a module") > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Reported-by: Nathan Chancellor <nathan@kernel.org> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/i2c/max9271.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/i2c/max9271.c b/drivers/media/i2c/max9271.c > index c247db569bab..c495582dcff6 100644 > --- a/drivers/media/i2c/max9271.c > +++ b/drivers/media/i2c/max9271.c > @@ -18,6 +18,7 @@ > > #include <linux/delay.h> > #include <linux/i2c.h> > +#include <linux/module.h> > > #include "max9271.h" > > @@ -339,3 +340,7 @@ int max9271_set_translation(struct max9271_device *dev, u8 source, u8 dest) > return 0; > } > EXPORT_SYMBOL_GPL(max9271_set_translation); > + > +MODULE_DESCRIPTION("Maxim MAX9271 GMSL Serializer"); > +MODULE_AUTHOR("Jacopo Mondi"); > +MODULE_LICENSE("GPL v2");
On Wed, Feb 10, 2021 at 04:49:08PM +0100, Jacopo Mondi wrote: > Since commit 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271 > a module") the max9271 library is built as a module but no > MODULE_*() attributes were specified, causing a build error > due to missing license information. > > ERROR: modpost: missing MODULE_LICENSE() in drivers/media/i2c/max9271.o > > Fix this by adding MODULE attributes to the driver. > > Fixes: 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271 a module") > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Reported-by: Nathan Chancellor <nathan@kernel.org> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > drivers/media/i2c/max9271.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/i2c/max9271.c b/drivers/media/i2c/max9271.c > index c247db569bab..c495582dcff6 100644 > --- a/drivers/media/i2c/max9271.c > +++ b/drivers/media/i2c/max9271.c > @@ -18,6 +18,7 @@ > > #include <linux/delay.h> > #include <linux/i2c.h> > +#include <linux/module.h> > > #include "max9271.h" > > @@ -339,3 +340,7 @@ int max9271_set_translation(struct max9271_device *dev, u8 source, u8 dest) > return 0; > } > EXPORT_SYMBOL_GPL(max9271_set_translation); > + > +MODULE_DESCRIPTION("Maxim MAX9271 GMSL Serializer"); > +MODULE_AUTHOR("Jacopo Mondi"); > +MODULE_LICENSE("GPL v2"); > -- > 2.30.0 >
diff --git a/drivers/media/i2c/max9271.c b/drivers/media/i2c/max9271.c index c247db569bab..c495582dcff6 100644 --- a/drivers/media/i2c/max9271.c +++ b/drivers/media/i2c/max9271.c @@ -18,6 +18,7 @@ #include <linux/delay.h> #include <linux/i2c.h> +#include <linux/module.h> #include "max9271.h" @@ -339,3 +340,7 @@ int max9271_set_translation(struct max9271_device *dev, u8 source, u8 dest) return 0; } EXPORT_SYMBOL_GPL(max9271_set_translation); + +MODULE_DESCRIPTION("Maxim MAX9271 GMSL Serializer"); +MODULE_AUTHOR("Jacopo Mondi"); +MODULE_LICENSE("GPL v2");
Since commit 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271 a module") the max9271 library is built as a module but no MODULE_*() attributes were specified, causing a build error due to missing license information. ERROR: modpost: missing MODULE_LICENSE() in drivers/media/i2c/max9271.o Fix this by adding MODULE attributes to the driver. Fixes: 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271 a module") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Reported-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- drivers/media/i2c/max9271.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.30.0