| Message ID | 20210304165300.295952-1-kieran.bingham+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: dts: renesas: falcon: Add GP LEDs | expand |
Hi Kieran, On Thu, Mar 4, 2021 at 5:53 PM Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> wrote: > Three general purpose LEDs are provided on the Falcon CPU board. > > Connect GP_LED1, GP_LED2, and GP_LED3 to the gpio-leds frameworks. > These LEDs are arranged in a block of four LEDs on the board itself, but > the fourth LED is as yet unidentified. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts > +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts I believe the LEDs are on the CPU board, so they belong in r8a779a0-falcon-cpu.dtsi instead? > @@ -20,6 +20,20 @@ aliases { > chosen { > stdout-path = "serial0:115200n8"; > }; > + > + leds { > + compatible = "gpio-leds"; > + > + led1 { > + gpios = <&gpio4 18 GPIO_ACTIVE_HIGH>; Any need for other properties from Documentation/devicetree/bindings/leds/common.yaml, like color = <LED_COLOR_ID_GREEN>? > + }; > + led2 { > + gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>; > + }; > + led3 { > + gpios = <&gpio4 20 GPIO_ACTIVE_HIGH>; > + }; > + }; > }; Gr{oetje,eeting}s, Geert
On 05/03/2021 14:10, Geert Uytterhoeven wrote: > Hi Kieran, > > On Thu, Mar 4, 2021 at 5:53 PM Kieran Bingham > <kieran.bingham+renesas@ideasonboard.com> wrote: >> Three general purpose LEDs are provided on the Falcon CPU board. >> >> Connect GP_LED1, GP_LED2, and GP_LED3 to the gpio-leds frameworks. >> These LEDs are arranged in a block of four LEDs on the board itself, but >> the fourth LED is as yet unidentified. >> >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > Thanks for your patch! > >> --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts > > I believe the LEDs are on the CPU board, so they belong in > r8a779a0-falcon-cpu.dtsi instead? Yes, I hadn't quite grasped the layouts of this new board yet. Sorry - I'll move it. > >> @@ -20,6 +20,20 @@ aliases { >> chosen { >> stdout-path = "serial0:115200n8"; >> }; >> + >> + leds { >> + compatible = "gpio-leds"; >> + >> + led1 { >> + gpios = <&gpio4 18 GPIO_ACTIVE_HIGH>; > > Any need for other properties from > Documentation/devicetree/bindings/leds/common.yaml, like > color = <LED_COLOR_ID_GREEN>? Oh, I wasn't aware of those. But indeed the LED is green, so it seems appropriate. I'll test it out, and see if I can make it glow red (jokes). > >> + }; >> + led2 { >> + gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>; >> + }; >> + led3 { >> + gpios = <&gpio4 20 GPIO_ACTIVE_HIGH>; >> + }; >> + }; >> }; > > Gr{oetje,eeting}s, > > Geert >
diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts index 5617b81dd7dc..a18f84128fe1 100644 --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts @@ -20,6 +20,20 @@ aliases { chosen { stdout-path = "serial0:115200n8"; }; + + leds { + compatible = "gpio-leds"; + + led1 { + gpios = <&gpio4 18 GPIO_ACTIVE_HIGH>; + }; + led2 { + gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>; + }; + led3 { + gpios = <&gpio4 20 GPIO_ACTIVE_HIGH>; + }; + }; }; &rwdt {
Three general purpose LEDs are provided on the Falcon CPU board. Connect GP_LED1, GP_LED2, and GP_LED3 to the gpio-leds frameworks. These LEDs are arranged in a block of four LEDs on the board itself, but the fourth LED is as yet unidentified. Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> --- arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+)