| Message ID | 20210323005616.20110-1-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | c29b6b0b126e9ee69a5d6339475e831a149295bd |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | [1/2] drm: rcar-du: Don't put reference to drm_device in rcar_du_remove() | expand |
Hi Laurent, On 23/03/2021 00:56, Laurent Pinchart wrote: > The reference to the drm_device that was acquired by > devm_drm_dev_alloc() is released automatically by the devres > infrastructure. It must not be released manually, as that causes a > reference underflow.. > Ouch. We need some tests on module load and unload somewhere... I'm getting closer with infrastructure ... > Fixes: ea6aae151887 ("drm: rcar-du: Embed drm_device in rcar_du_device") > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 43de3d8686e8..2a06ec1cbefb 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -556,8 +556,6 @@ static int rcar_du_remove(struct platform_device *pdev) > > drm_kms_helper_poll_fini(ddev); > > - drm_dev_put(ddev); > - > return 0; > } > >
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 43de3d8686e8..2a06ec1cbefb 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c @@ -556,8 +556,6 @@ static int rcar_du_remove(struct platform_device *pdev) drm_kms_helper_poll_fini(ddev); - drm_dev_put(ddev); - return 0; }
The reference to the drm_device that was acquired by devm_drm_dev_alloc() is released automatically by the devres infrastructure. It must not be released manually, as that causes a reference underflow.. Fixes: ea6aae151887 ("drm: rcar-du: Embed drm_device in rcar_du_device") Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 -- 1 file changed, 2 deletions(-)