| Message ID | 20210811171816.12012-1-lutovinova@ispras.ru (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | fc41665498332ad394b7db37f23e9394096ddc71 |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | [v2] media: rcar-csi2: Add checking to rcsi2_start_receiver() | expand |
Hello Nadezda, On Wed, Aug 11, 2021 at 08:18:16PM +0300, Nadezda Lutovinova wrote: > If rcsi2_code_to_fmt() return NULL, then null pointer dereference occurs > in the next cycle. That should not be possible now but adding checking > protects from future bugs. > The patch adds checking if format is NULL. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > --- > v2: fix subject and commit message, remove dev_err() > --- > drivers/media/platform/rcar-vin/rcar-csi2.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c > index e28eff039688..d28f83f7698b 100644 > --- a/drivers/media/platform/rcar-vin/rcar-csi2.c > +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c > @@ -553,6 +553,8 @@ static int rcsi2_start_receiver(struct rcar_csi2 *priv) > > /* Code is validated in set_fmt. */ > format = rcsi2_code_to_fmt(priv->mf.code); > + if (!format) > + return -EINVAL; > > /* > * Enable all supported CSI-2 channels with virtual channel and > -- > 2.17.1 >
Hi Nadezda, Thanks for your patch. On 2021-08-11 20:18:16 +0300, Nadezda Lutovinova wrote: > If rcsi2_code_to_fmt() return NULL, then null pointer dereference occurs > in the next cycle. That should not be possible now but adding checking > protects from future bugs. > The patch adds checking if format is NULL. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > v2: fix subject and commit message, remove dev_err() > --- > drivers/media/platform/rcar-vin/rcar-csi2.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c > index e28eff039688..d28f83f7698b 100644 > --- a/drivers/media/platform/rcar-vin/rcar-csi2.c > +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c > @@ -553,6 +553,8 @@ static int rcsi2_start_receiver(struct rcar_csi2 *priv) > > /* Code is validated in set_fmt. */ > format = rcsi2_code_to_fmt(priv->mf.code); > + if (!format) > + return -EINVAL; > > /* > * Enable all supported CSI-2 channels with virtual channel and > -- > 2.17.1 >
diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c index e28eff039688..d28f83f7698b 100644 --- a/drivers/media/platform/rcar-vin/rcar-csi2.c +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c @@ -553,6 +553,8 @@ static int rcsi2_start_receiver(struct rcar_csi2 *priv) /* Code is validated in set_fmt. */ format = rcsi2_code_to_fmt(priv->mf.code); + if (!format) + return -EINVAL; /* * Enable all supported CSI-2 channels with virtual channel and
If rcsi2_code_to_fmt() return NULL, then null pointer dereference occurs in the next cycle. That should not be possible now but adding checking protects from future bugs. The patch adds checking if format is NULL. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru> --- v2: fix subject and commit message, remove dev_err() --- drivers/media/platform/rcar-vin/rcar-csi2.c | 2 ++ 1 file changed, 2 insertions(+)