| Message ID | 20211102110243.1510895-1-kieran.bingham+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 60f9462cfa608dbd6b7e68da8c30940163a87a65 |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | [v2] media: i2c: max9286: Depend on VIDEO_V4L2 | expand |
Hi Kieran, Thanks for your work. On 2021-11-02 11:02:43 +0000, Kieran Bingham wrote: > The MAX9286 has not explicitly declared a dependency upon VIDEO_V4L2. > While this dependency has likely always been met by configurations > including it, the device does use V4L2 core, and should depend upon it. > > Add VIDEO_V4L2 as a dependency to match other drivers and prevent > failures when compile testing. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > --- > v2: > - Split VIDEO_V4L2 to it's own line > > A bit of an RFC almost, as I haven't seen any failure on this, however > this does stand out as different to other drivers, and the recent > "max96712: Select VIDEO_V4L2" posting has shown that these deserialiser > drivers could find themselves being compile tested in a manner which > would other wise break. > > drivers/media/i2c/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index d6a5d4ca439a..e9cfedf561d3 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -469,6 +469,7 @@ config VIDEO_VPX3220 > config VIDEO_MAX9286 > tristate "Maxim MAX9286 GMSL deserializer support" > depends on I2C && I2C_MUX > + depends on VIDEO_V4L2 > depends on OF_GPIO > select V4L2_FWNODE > select VIDEO_V4L2_SUBDEV_API > -- > 2.30.2 >
Hi Kieran On Tue, Nov 02, 2021 at 11:02:43AM +0000, Kieran Bingham wrote: > The MAX9286 has not explicitly declared a dependency upon VIDEO_V4L2. > While this dependency has likely always been met by configurations > including it, the device does use V4L2 core, and should depend upon it. > > Add VIDEO_V4L2 as a dependency to match other drivers and prevent > failures when compile testing. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org> o Thanks j > > --- > v2: > - Split VIDEO_V4L2 to it's own line > > A bit of an RFC almost, as I haven't seen any failure on this, however > this does stand out as different to other drivers, and the recent > "max96712: Select VIDEO_V4L2" posting has shown that these deserialiser > drivers could find themselves being compile tested in a manner which > would other wise break. > > drivers/media/i2c/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index d6a5d4ca439a..e9cfedf561d3 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -469,6 +469,7 @@ config VIDEO_VPX3220 > config VIDEO_MAX9286 > tristate "Maxim MAX9286 GMSL deserializer support" > depends on I2C && I2C_MUX > + depends on VIDEO_V4L2 > depends on OF_GPIO > select V4L2_FWNODE > select VIDEO_V4L2_SUBDEV_API > -- > 2.30.2 >
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index d6a5d4ca439a..e9cfedf561d3 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -469,6 +469,7 @@ config VIDEO_VPX3220 config VIDEO_MAX9286 tristate "Maxim MAX9286 GMSL deserializer support" depends on I2C && I2C_MUX + depends on VIDEO_V4L2 depends on OF_GPIO select V4L2_FWNODE select VIDEO_V4L2_SUBDEV_API
The MAX9286 has not explicitly declared a dependency upon VIDEO_V4L2. While this dependency has likely always been met by configurations including it, the device does use V4L2 core, and should depend upon it. Add VIDEO_V4L2 as a dependency to match other drivers and prevent failures when compile testing. Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> --- v2: - Split VIDEO_V4L2 to it's own line A bit of an RFC almost, as I haven't seen any failure on this, however this does stand out as different to other drivers, and the recent "max96712: Select VIDEO_V4L2" posting has shown that these deserialiser drivers could find themselves being compile tested in a manner which would other wise break. drivers/media/i2c/Kconfig | 1 + 1 file changed, 1 insertion(+)