| Message ID | 20211117010527.27365-2-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | SPI driver support for RZ/G2L | expand |
Hi Prabhakar, On Wed, Nov 17, 2021 at 2:05 AM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Add RSPI binding documentation for Renesas RZ/G2L SoC. > > RSPI block is identical to one found on RZ/A, so no driver changes are > required the fallback compatible string "renesas,rspi-rz" will be used ... required. The ... > on RZ/G2L > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- a/Documentation/devicetree/bindings/spi/renesas,rspi.yaml > +++ b/Documentation/devicetree/bindings/spi/renesas,rspi.yaml > @@ -21,7 +21,8 @@ properties: > - enum: > - renesas,rspi-r7s72100 # RZ/A1H > - renesas,rspi-r7s9210 # RZ/A2 > - - const: renesas,rspi-rz # RZ/A > + - renesas,r9a07g044-rspi # RZ/G2{L,LC} > + - const: renesas,rspi-rz # RZ/A and RZ/G2{L,LC} > > - items: > - enum: > @@ -116,6 +117,16 @@ allOf: > required: > - interrupt-names > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,r9a07g044-rspi > + then: > + required: > + - resets > + You may want to merge this with the existing section that makes resets required for renesas,qspi. > - if: > properties: > compatible: Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thank you for the review. On Wed, Nov 17, 2021 at 8:51 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Wed, Nov 17, 2021 at 2:05 AM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > Add RSPI binding documentation for Renesas RZ/G2L SoC. > > > > RSPI block is identical to one found on RZ/A, so no driver changes are > > required the fallback compatible string "renesas,rspi-rz" will be used > > ... required. The ... > will fix that. > > on RZ/G2L > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- a/Documentation/devicetree/bindings/spi/renesas,rspi.yaml > > +++ b/Documentation/devicetree/bindings/spi/renesas,rspi.yaml > > @@ -21,7 +21,8 @@ properties: > > - enum: > > - renesas,rspi-r7s72100 # RZ/A1H > > - renesas,rspi-r7s9210 # RZ/A2 > > - - const: renesas,rspi-rz # RZ/A > > + - renesas,r9a07g044-rspi # RZ/G2{L,LC} > > + - const: renesas,rspi-rz # RZ/A and RZ/G2{L,LC} > > > > - items: > > - enum: > > @@ -116,6 +117,16 @@ allOf: > > required: > > - interrupt-names > > > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - renesas,r9a07g044-rspi > > + then: > > + required: > > + - resets > > + > > You may want to merge this with the existing section that makes > resets required for renesas,qspi. > Right, I completely missed that. Cheers, Prabhakar > > - if: > > properties: > > compatible: > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
On Wed, Nov 17, 2021 at 01:05:25AM +0000, Lad Prabhakar wrote: > Add RSPI binding documentation for Renesas RZ/G2L SoC. > > RSPI block is identical to one found on RZ/A, so no driver changes are > required the fallback compatible string "renesas,rspi-rz" will be used > on RZ/G2L Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
Hi Mark, Thank you for the review. On Wed, Nov 17, 2021 at 12:55 PM Mark Brown <broonie@kernel.org> wrote: > > On Wed, Nov 17, 2021 at 01:05:25AM +0000, Lad Prabhakar wrote: > > Add RSPI binding documentation for Renesas RZ/G2L SoC. > > > > RSPI block is identical to one found on RZ/A, so no driver changes are > > required the fallback compatible string "renesas,rspi-rz" will be used > > on RZ/G2L > > Please submit patches using subject lines reflecting the style for the > subsystem, this makes it easier for people to identify relevant patches. > Look at what existing commits in the area you're changing are doing and > make sure your subject lines visually resemble what they're doing. > There's no need to resubmit to fix this alone. My bad will update it to "spi: dt-bindings: renesas,rspi: Document RZ/G2L SoC" and re-send a v2 along with the review commented by Geert. Cheers, Prabhakar
diff --git a/Documentation/devicetree/bindings/spi/renesas,rspi.yaml b/Documentation/devicetree/bindings/spi/renesas,rspi.yaml index 8397f60d80a2..604f8452b4f5 100644 --- a/Documentation/devicetree/bindings/spi/renesas,rspi.yaml +++ b/Documentation/devicetree/bindings/spi/renesas,rspi.yaml @@ -21,7 +21,8 @@ properties: - enum: - renesas,rspi-r7s72100 # RZ/A1H - renesas,rspi-r7s9210 # RZ/A2 - - const: renesas,rspi-rz # RZ/A + - renesas,r9a07g044-rspi # RZ/G2{L,LC} + - const: renesas,rspi-rz # RZ/A and RZ/G2{L,LC} - items: - enum: @@ -116,6 +117,16 @@ allOf: required: - interrupt-names + - if: + properties: + compatible: + contains: + enum: + - renesas,r9a07g044-rspi + then: + required: + - resets + - if: properties: compatible: