| Message ID | 20211117011247.27621-3-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Enable RSPI support on RZ/G2L SMARC EVK | expand |
Hi Prabhakar, On Wed, Nov 17, 2021 at 2:12 AM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > RSPI1 (SPI1) interface is available on PMOD0 connector (J1) on carrier > board, This patch adds pinmux and spi1 node to carrier board dtsi file. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi > @@ -31,6 +31,7 @@ > i2c0 = &i2c0; > i2c1 = &i2c1; > i2c3 = &i2c3; > + spi1 = &spi1; Do you mind if I drop this while applying? > }; > > chosen { Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v5.17. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thank you for the review. On Wed, Nov 17, 2021 at 10:10 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Wed, Nov 17, 2021 at 2:12 AM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > RSPI1 (SPI1) interface is available on PMOD0 connector (J1) on carrier > > board, This patch adds pinmux and spi1 node to carrier board dtsi file. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > > Thanks for your patch! > > > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi > > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi > > @@ -31,6 +31,7 @@ > > i2c0 = &i2c0; > > i2c1 = &i2c1; > > i2c3 = &i2c3; > > + spi1 = &spi1; > > Do you mind if I drop this while applying? > Fine by me. Any reason to do so? (I ask because in future I can take care of it prior to posting) Cheers, Prabhakar > > }; > > > > chosen { > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > i.e. will queue in renesas-devel for v5.17. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Prabhakar, On Wed, Nov 17, 2021 at 11:16 AM Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote: > On Wed, Nov 17, 2021 at 10:10 AM Geert Uytterhoeven > <geert@linux-m68k.org> wrote: > > On Wed, Nov 17, 2021 at 2:12 AM Lad Prabhakar > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > RSPI1 (SPI1) interface is available on PMOD0 connector (J1) on carrier > > > board, This patch adds pinmux and spi1 node to carrier board dtsi file. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > > > > Thanks for your patch! > > > > > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi > > > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi > > > @@ -31,6 +31,7 @@ > > > i2c0 = &i2c0; > > > i2c1 = &i2c1; > > > i2c3 = &i2c3; > > > + spi1 = &spi1; > > > > Do you mind if I drop this while applying? > > > Fine by me. Any reason to do so? (I ask because in future I can take > care of it prior to posting) Aliases are used to match physical connectors with a device, so they make sense for serial and network ports. We don't have them for SPI on any Renesas arm64 boards. We do have them for I2C, but I2C differs from SPI, as on I2C you can instantiate new devices from sysfs. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, On Wed, Nov 17, 2021 at 10:25 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Wed, Nov 17, 2021 at 11:16 AM Lad, Prabhakar > <prabhakar.csengg@gmail.com> wrote: > > On Wed, Nov 17, 2021 at 10:10 AM Geert Uytterhoeven > > <geert@linux-m68k.org> wrote: > > > On Wed, Nov 17, 2021 at 2:12 AM Lad Prabhakar > > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > > RSPI1 (SPI1) interface is available on PMOD0 connector (J1) on carrier > > > > board, This patch adds pinmux and spi1 node to carrier board dtsi file. > > > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > > > > > > Thanks for your patch! > > > > > > > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi > > > > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi > > > > @@ -31,6 +31,7 @@ > > > > i2c0 = &i2c0; > > > > i2c1 = &i2c1; > > > > i2c3 = &i2c3; > > > > + spi1 = &spi1; > > > > > > Do you mind if I drop this while applying? > > > > > Fine by me. Any reason to do so? (I ask because in future I can take > > care of it prior to posting) > > Aliases are used to match physical connectors with a device, so they > make sense for serial and network ports. > We don't have them for SPI on any Renesas arm64 boards. > We do have them for I2C, but I2C differs from SPI, as on I2C you can > instantiate new devices from sysfs. > Agreed makes sense now. Thank you for the clarification. Cheers, Prabhakar > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi index 4c32f068a1f0..f9460ec5c8fa 100644 --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi @@ -31,6 +31,7 @@ i2c0 = &i2c0; i2c1 = &i2c1; i2c3 = &i2c3; + spi1 = &spi1; }; chosen { @@ -263,6 +264,13 @@ input-enable; }; + spi1_pins: spi1 { + pinmux = <RZG2L_PORT_PINMUX(44, 0, 1)>, /* CK */ + <RZG2L_PORT_PINMUX(44, 1, 1)>, /* MOSI */ + <RZG2L_PORT_PINMUX(44, 2, 1)>, /* MISO */ + <RZG2L_PORT_PINMUX(44, 3, 1)>; /* SSL */ + }; + ssi0_pins: ssi0 { pinmux = <RZG2L_PORT_PINMUX(45, 0, 1)>, /* BCK */ <RZG2L_PORT_PINMUX(45, 1, 1)>, /* RCK */ @@ -318,6 +326,13 @@ status = "okay"; }; +&spi1 { + pinctrl-0 = <&spi1_pins>; + pinctrl-names = "default"; + + status = "okay"; +}; + &ssi0 { pinctrl-0 = <&ssi0_pins>; pinctrl-names = "default";