| Message ID | 20211121180155.9062-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | memory: renesas-rpc-if: Silence clang warning | expand |
Hi Prabhakar, On Sun, Nov 21, 2021 at 7:05 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > This patch silences the following clang warning: > > | drivers/memory/renesas-rpc-if.c:253:14: warning: cast to smaller integer > | type 'enum rpcif_type' from 'const void *' [-Wvoid-pointer-to-enum-cast] > | rpc->type = (enum rpcif_type)of_device_get_match_data(dev); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Fixes: b04cc0d912eb8 ("memory: renesas-rpc-if: Add support for RZ/G2L") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- a/drivers/memory/renesas-rpc-if.c > +++ b/drivers/memory/renesas-rpc-if.c > @@ -250,7 +250,7 @@ int rpcif_sw_init(struct rpcif *rpc, struct device *dev) > return PTR_ERR(rpc->dirmap); > rpc->size = resource_size(res); > > - rpc->type = (enum rpcif_type)of_device_get_match_data(dev); > + rpc->type = (enum rpcif_type)(uintptr_t)of_device_get_match_data(dev); While correct, the cast to "enum rpcif_type" is not stricly needed anymore. > rpc->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL); > > return PTR_ERR_OR_ZERO(rpc->rstc); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thank you for the review. On Mon, Nov 22, 2021 at 7:50 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Sun, Nov 21, 2021 at 7:05 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > This patch silences the following clang warning: > > > > | drivers/memory/renesas-rpc-if.c:253:14: warning: cast to smaller integer > > | type 'enum rpcif_type' from 'const void *' [-Wvoid-pointer-to-enum-cast] > > | rpc->type = (enum rpcif_type)of_device_get_match_data(dev); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > Fixes: b04cc0d912eb8 ("memory: renesas-rpc-if: Add support for RZ/G2L") > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- a/drivers/memory/renesas-rpc-if.c > > +++ b/drivers/memory/renesas-rpc-if.c > > @@ -250,7 +250,7 @@ int rpcif_sw_init(struct rpcif *rpc, struct device *dev) > > return PTR_ERR(rpc->dirmap); > > rpc->size = resource_size(res); > > > > - rpc->type = (enum rpcif_type)of_device_get_match_data(dev); > > + rpc->type = (enum rpcif_type)(uintptr_t)of_device_get_match_data(dev); > > While correct, the cast to "enum rpcif_type" is not stricly needed anymore. > Agreed. @Krzysztof, let me know if you want me to resend the patch with the cast to "enum rpcif_type" dropped. Cheers, Prabhakar > > rpc->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL); > > > > return PTR_ERR_OR_ZERO(rpc->rstc); > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
On 22/11/2021 09:46, Lad, Prabhakar wrote: > Hi Geert, > > Thank you for the review. > > On Mon, Nov 22, 2021 at 7:50 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: >> >> Hi Prabhakar, >> >> On Sun, Nov 21, 2021 at 7:05 PM Lad Prabhakar >> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: >>> This patch silences the following clang warning: >>> >>> | drivers/memory/renesas-rpc-if.c:253:14: warning: cast to smaller integer >>> | type 'enum rpcif_type' from 'const void *' [-Wvoid-pointer-to-enum-cast] >>> | rpc->type = (enum rpcif_type)of_device_get_match_data(dev); >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >>> Fixes: b04cc0d912eb8 ("memory: renesas-rpc-if: Add support for RZ/G2L") >>> Reported-by: kernel test robot <lkp@intel.com> >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> >> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >>> --- a/drivers/memory/renesas-rpc-if.c >>> +++ b/drivers/memory/renesas-rpc-if.c >>> @@ -250,7 +250,7 @@ int rpcif_sw_init(struct rpcif *rpc, struct device *dev) >>> return PTR_ERR(rpc->dirmap); >>> rpc->size = resource_size(res); >>> >>> - rpc->type = (enum rpcif_type)of_device_get_match_data(dev); >>> + rpc->type = (enum rpcif_type)(uintptr_t)of_device_get_match_data(dev); >> >> While correct, the cast to "enum rpcif_type" is not stricly needed anymore. >> > Agreed. > > @Krzysztof, let me know if you want me to resend the patch with the > cast to "enum rpcif_type" dropped. I can fix it when applying, thanks! Best regards, Krzysztof
On Mon, Nov 22, 2021 at 9:32 AM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > On 22/11/2021 09:46, Lad, Prabhakar wrote: > > Hi Geert, > > > > Thank you for the review. > > > > On Mon, Nov 22, 2021 at 7:50 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > >> > >> Hi Prabhakar, > >> > >> On Sun, Nov 21, 2021 at 7:05 PM Lad Prabhakar > >> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > >>> This patch silences the following clang warning: > >>> > >>> | drivers/memory/renesas-rpc-if.c:253:14: warning: cast to smaller integer > >>> | type 'enum rpcif_type' from 'const void *' [-Wvoid-pointer-to-enum-cast] > >>> | rpc->type = (enum rpcif_type)of_device_get_match_data(dev); > >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >>> > >>> Fixes: b04cc0d912eb8 ("memory: renesas-rpc-if: Add support for RZ/G2L") > >>> Reported-by: kernel test robot <lkp@intel.com> > >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > >> > >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> > >>> --- a/drivers/memory/renesas-rpc-if.c > >>> +++ b/drivers/memory/renesas-rpc-if.c > >>> @@ -250,7 +250,7 @@ int rpcif_sw_init(struct rpcif *rpc, struct device *dev) > >>> return PTR_ERR(rpc->dirmap); > >>> rpc->size = resource_size(res); > >>> > >>> - rpc->type = (enum rpcif_type)of_device_get_match_data(dev); > >>> + rpc->type = (enum rpcif_type)(uintptr_t)of_device_get_match_data(dev); > >> > >> While correct, the cast to "enum rpcif_type" is not stricly needed anymore. > >> > > Agreed. > > > > @Krzysztof, let me know if you want me to resend the patch with the > > cast to "enum rpcif_type" dropped. > > I can fix it when applying, thanks! > Thank you. Cheers, Prabhakar > > Best regards, > Krzysztof
On Sun, 21 Nov 2021 18:01:55 +0000, Lad Prabhakar wrote: > This patch silences the following clang warning: > > | drivers/memory/renesas-rpc-if.c:253:14: warning: cast to smaller integer > | type 'enum rpcif_type' from 'const void *' [-Wvoid-pointer-to-enum-cast] > | rpc->type = (enum rpcif_type)of_device_get_match_data(dev); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > [...] Applied, thanks! [1/1] memory: renesas-rpc-if: Silence clang warning commit: 2602dc10f9d930bcc537467d13de4cfbfaa2126d Best regards,
diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c index 8c51145c0f5c..0202c1dbc5c4 100644 --- a/drivers/memory/renesas-rpc-if.c +++ b/drivers/memory/renesas-rpc-if.c @@ -250,7 +250,7 @@ int rpcif_sw_init(struct rpcif *rpc, struct device *dev) return PTR_ERR(rpc->dirmap); rpc->size = resource_size(res); - rpc->type = (enum rpcif_type)of_device_get_match_data(dev); + rpc->type = (enum rpcif_type)(uintptr_t)of_device_get_match_data(dev); rpc->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL); return PTR_ERR_OR_ZERO(rpc->rstc);
This patch silences the following clang warning: | drivers/memory/renesas-rpc-if.c:253:14: warning: cast to smaller integer | type 'enum rpcif_type' from 'const void *' [-Wvoid-pointer-to-enum-cast] | rpc->type = (enum rpcif_type)of_device_get_match_data(dev); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: b04cc0d912eb8 ("memory: renesas-rpc-if: Add support for RZ/G2L") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- drivers/memory/renesas-rpc-if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)