| Message ID | 20211121235808.10167-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Under Review |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: dts: hihope-rzg2-ex-lvds: Add power-supply and enable-gpios to backlight node | expand |
Hi Prabhakar, On Mon, Nov 22, 2021 at 12:58 AM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > This patch adds missing power-supply and enable-gpios property to > backlight node. This fixes the warning "pwm-backlight backlight: > backlight supply power not found, using dummy regulator". > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex-lvds.dtsi > +++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex-lvds.dtsi > @@ -12,6 +12,17 @@ > > brightness-levels = <0 2 8 16 32 64 128 255>; > default-brightness-level = <6>; > + power-supply = <®_12v>; > + enable-gpios = <&gpio6 7 GPIO_ACTIVE_HIGH>; According to the schematics (up to Rev. 4.00), GP6_07 is not connected? > + }; > + > + reg_12v: regulator2 { Using "regulatorN" as a node name is error-prone, and may lead to accidental clashes. Please use a more appropriate name. > + compatible = "regulator-fixed"; > + regulator-name = "fixed-12V"; > + regulator-min-microvolt = <12000000>; > + regulator-max-microvolt = <12000000>; Hmm, the AT1316A is a constant-current source, not a constant-voltage source? The -02 variant has a 0.2V Low Reference Voltage. Combined with the 1.1Ω resistor, that should give 181818 microamp. > + regulator-boot-on; > + regulator-always-on; > }; > }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thank you for the review. On Tue, Nov 23, 2021 at 2:44 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Mon, Nov 22, 2021 at 12:58 AM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > This patch adds missing power-supply and enable-gpios property to > > backlight node. This fixes the warning "pwm-backlight backlight: > > backlight supply power not found, using dummy regulator". > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Thanks for your patch! > > > --- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex-lvds.dtsi > > +++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex-lvds.dtsi > > @@ -12,6 +12,17 @@ > > > > brightness-levels = <0 2 8 16 32 64 128 255>; > > default-brightness-level = <6>; > > + power-supply = <®_12v>; > > + enable-gpios = <&gpio6 7 GPIO_ACTIVE_HIGH>; > > According to the schematics (up to Rev. 4.00), GP6_07 is not connected? > Ouch sorry about that. When I noticed a warning with the regulator, I saw the missing gpio property too and I pulled out the older schematic with Rev2 which has GP6_07 :( > > + }; > > + > > + reg_12v: regulator2 { > > Using "regulatorN" as a node name is error-prone, and may lead to > accidental clashes. Please use a more appropriate name. > > > + compatible = "regulator-fixed"; > > + regulator-name = "fixed-12V"; > > + regulator-min-microvolt = <12000000>; > > + regulator-max-microvolt = <12000000>; > > Hmm, the AT1316A is a constant-current source, not a constant-voltage > source? The -02 variant has a 0.2V Low Reference Voltage. Combined > with the 1.1Ω resistor, that should give 181818 microamp. > Agreed. Cheers, Prabhakar > > + regulator-boot-on; > > + regulator-always-on; > > }; > > }; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex-lvds.dtsi b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex-lvds.dtsi index 40c5e8d6d841..a4fb8582a36b 100644 --- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex-lvds.dtsi +++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex-lvds.dtsi @@ -12,6 +12,17 @@ brightness-levels = <0 2 8 16 32 64 128 255>; default-brightness-level = <6>; + power-supply = <®_12v>; + enable-gpios = <&gpio6 7 GPIO_ACTIVE_HIGH>; + }; + + reg_12v: regulator2 { + compatible = "regulator-fixed"; + regulator-name = "fixed-12V"; + regulator-min-microvolt = <12000000>; + regulator-max-microvolt = <12000000>; + regulator-boot-on; + regulator-always-on; }; };
This patch adds missing power-supply and enable-gpios property to backlight node. This fixes the warning "pwm-backlight backlight: backlight supply power not found, using dummy regulator". Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- arch/arm64/boot/dts/renesas/hihope-rzg2-ex-lvds.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+)