| Message ID | 20220104153615.13393-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | gpio: rcar: Propagate errors from devm_request_irq() | expand |
On Tue, Jan 4, 2022 at 5:36 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > The driver overrides the error code returned by devm_request_irq() to > -ENOENT. Switch to propagating the error code upstream. Thanks, FWIW, Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > This patch depends on [1]. > > [1] https://lkml.org/lkml/2021/12/22/633 > --- > drivers/gpio/gpio-rcar.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c > index 437baecc434e..bd2e16d6e21c 100644 > --- a/drivers/gpio/gpio-rcar.c > +++ b/drivers/gpio/gpio-rcar.c > @@ -552,10 +552,10 @@ static int gpio_rcar_probe(struct platform_device *pdev) > goto err0; > } > > - if (devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler, > - IRQF_SHARED, name, p)) { > + ret = devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler, > + IRQF_SHARED, name, p); > + if (ret) { > dev_err(dev, "failed to request IRQ\n"); > - ret = -ENOENT; > goto err1; > } > > -- > 2.17.1 >
Hello! On 1/4/22 6:36 PM, Lad Prabhakar wrote: > The driver overrides the error code returned by devm_request_irq() to > -ENOENT. Switch to propagating the error code upstream. > > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> [...] Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> MBR, Sergey
On Tue, Jan 4, 2022 at 4:36 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > The driver overrides the error code returned by devm_request_irq() to > -ENOENT. Switch to propagating the error code upstream. > > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- Applied, thanks! Bart
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 437baecc434e..bd2e16d6e21c 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -552,10 +552,10 @@ static int gpio_rcar_probe(struct platform_device *pdev) goto err0; } - if (devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler, - IRQF_SHARED, name, p)) { + ret = devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler, + IRQF_SHARED, name, p); + if (ret) { dev_err(dev, "failed to request IRQ\n"); - ret = -ENOENT; goto err1; }
The driver overrides the error code returned by devm_request_irq() to -ENOENT. Switch to propagating the error code upstream. Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- This patch depends on [1]. [1] https://lkml.org/lkml/2021/12/22/633 --- drivers/gpio/gpio-rcar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)