| Message ID | 20220319223306.60782-2-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 0182581a9f63764bcbdbc68e98881b50e03fc4c4 |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: dts: renesas: r8a77961: improvements from BSP | expand |
Hi Wolfram, Thanks for your patch! On Sun, Mar 20, 2022 at 11:48 AM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > From: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > > It was forgotten when adding the other CAN nodes, add it now. > > Fixes: 92c406ed0a7f ("arm64: dts: renesas: r8a77961: Add CAN nodes") I don't think it was forgotten, and think this is not really a fix: CAN and CAN-FD are two different devices, with different drivers. > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > arch/arm64/boot/dts/renesas/r8a77961.dtsi | 25 +++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi > index ac9b587f6fc5..87bb903954ed 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi > @@ -1222,6 +1222,31 @@ can1: can@e6c38000 { > status = "disabled"; > }; > > + canfd: can@e66c0000 { > + compatible = "renesas,r8a77961-canfd", Can you please send a patch to augment the DT bindings? > + "renesas,rcar-gen3-canfd"; Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v5.19, with the Fixes tag removed. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
> > Fixes: 92c406ed0a7f ("arm64: dts: renesas: r8a77961: Add CAN nodes") > > I don't think it was forgotten, and think this is not really a fix: > CAN and CAN-FD are two different devices, with different drivers. I thought Goda-san tested both interfaces back then, but maybe I was wrong. Yeah, Fixes tag may be dropped probably. > > + compatible = "renesas,r8a77961-canfd", > > Can you please send a patch to augment the DT bindings? Sure, will do. > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > i.e. will queue in renesas-devel for v5.19, with the Fixes tag removed. Thanks!
diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi index ac9b587f6fc5..87bb903954ed 100644 --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi @@ -1222,6 +1222,31 @@ can1: can@e6c38000 { status = "disabled"; }; + canfd: can@e66c0000 { + compatible = "renesas,r8a77961-canfd", + "renesas,rcar-gen3-canfd"; + reg = <0 0xe66c0000 0 0x8000>; + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 914>, + <&cpg CPG_CORE R8A77961_CLK_CANFD>, + <&can_clk>; + clock-names = "fck", "canfd", "can_clk"; + assigned-clocks = <&cpg CPG_CORE R8A77961_CLK_CANFD>; + assigned-clock-rates = <40000000>; + power-domains = <&sysc R8A77961_PD_ALWAYS_ON>; + resets = <&cpg 914>; + status = "disabled"; + + channel0 { + status = "disabled"; + }; + + channel1 { + status = "disabled"; + }; + }; + pwm0: pwm@e6e30000 { compatible = "renesas,pwm-r8a77961", "renesas,pwm-rcar"; reg = <0 0xe6e30000 0 8>;