| Message ID | 20220412094029.287562-4-herve.codina@bootlin.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | RZN1 USB Host support | expand |
Hi Herve, herve.codina@bootlin.com wrote on Tue, 12 Apr 2022 11:40:26 +0200: > Add Renesas R9A06G032 SoC support to the Renesas R-Car gen2 PCI > bridge driver. > The Renesas RZ/N1D (R9A06G032) internal PCI bridge is compatible > with the one available in the R-Car Gen2 family. > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> > --- > drivers/pci/controller/pci-rcar-gen2.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c > index 528bc3780e01..586e4785a57f 100644 > --- a/drivers/pci/controller/pci-rcar-gen2.c > +++ b/drivers/pci/controller/pci-rcar-gen2.c > @@ -352,6 +352,8 @@ static const struct of_device_id rcar_pci_of_match[] = { > { .compatible = "renesas,pci-r8a7791", }, > { .compatible = "renesas,pci-r8a7794", }, > { .compatible = "renesas,pci-rcar-gen2", }, > + { .compatible = "renesas,pci-r9a06g032", }, > + { .compatible = "renesas,pci-rzn1", }, I don't think you don't yet need to match against the two, matching against pci-rzn1 is enough for now, until we discover that something is specific in the r9a06g032 family and we need to handle something else of course. Thanks, Miquèl
Hello! On 4/12/22 12:40 PM, Herve Codina wrote: > Add Renesas R9A06G032 SoC support to the Renesas R-Car gen2 PCI > bridge driver. > The Renesas RZ/N1D (R9A06G032) internal PCI bridge is compatible > with the one available in the R-Car Gen2 family. > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> > --- > drivers/pci/controller/pci-rcar-gen2.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c > index 528bc3780e01..586e4785a57f 100644 > --- a/drivers/pci/controller/pci-rcar-gen2.c > +++ b/drivers/pci/controller/pci-rcar-gen2.c > @@ -352,6 +352,8 @@ static const struct of_device_id rcar_pci_of_match[] = { > { .compatible = "renesas,pci-r8a7791", }, > { .compatible = "renesas,pci-r8a7794", }, > { .compatible = "renesas,pci-rcar-gen2", }, > + { .compatible = "renesas,pci-r9a06g032", }, Do we really need this one here? Isn't it covered by the next item? > + { .compatible = "renesas,pci-rzn1", }, > { }, > }; > MBR, Sergey
Hi Sergey, On Wed, 13 Apr 2022 12:08:01 +0300 Sergey Shtylyov <s.shtylyov@omp.ru> wrote: > Hello! > > On 4/12/22 12:40 PM, Herve Codina wrote: > > > Add Renesas R9A06G032 SoC support to the Renesas R-Car gen2 PCI > > bridge driver. > > The Renesas RZ/N1D (R9A06G032) internal PCI bridge is compatible > > with the one available in the R-Car Gen2 family. > > > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> > > --- > > drivers/pci/controller/pci-rcar-gen2.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c > > index 528bc3780e01..586e4785a57f 100644 > > --- a/drivers/pci/controller/pci-rcar-gen2.c > > +++ b/drivers/pci/controller/pci-rcar-gen2.c > > @@ -352,6 +352,8 @@ static const struct of_device_id rcar_pci_of_match[] = { > > { .compatible = "renesas,pci-r8a7791", }, > > { .compatible = "renesas,pci-r8a7794", }, > > { .compatible = "renesas,pci-rcar-gen2", }, > > + { .compatible = "renesas,pci-r9a06g032", }, > > Do we really need this one here? Isn't it covered by the next item? Yes, this one is not needed. Miquèl did the same remark too. I will remove '.compatible = "renesas,pci-r9a06g032"' in v2. Regards, Herve > > > + { .compatible = "renesas,pci-rzn1", }, > > { }, > > }; > > >
diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c index 528bc3780e01..586e4785a57f 100644 --- a/drivers/pci/controller/pci-rcar-gen2.c +++ b/drivers/pci/controller/pci-rcar-gen2.c @@ -352,6 +352,8 @@ static const struct of_device_id rcar_pci_of_match[] = { { .compatible = "renesas,pci-r8a7791", }, { .compatible = "renesas,pci-r8a7794", }, { .compatible = "renesas,pci-rcar-gen2", }, + { .compatible = "renesas,pci-r9a06g032", }, + { .compatible = "renesas,pci-rzn1", }, { }, };
Add Renesas R9A06G032 SoC support to the Renesas R-Car gen2 PCI bridge driver. The Renesas RZ/N1D (R9A06G032) internal PCI bridge is compatible with the one available in the R-Car Gen2 family. Signed-off-by: Herve Codina <herve.codina@bootlin.com> --- drivers/pci/controller/pci-rcar-gen2.c | 2 ++ 1 file changed, 2 insertions(+)