diff mbox series

[v6,10/12] ARM: dts: r9a06g032: Fill the UART DMA properties

Message ID 20220421095323.101811-11-miquel.raynal@bootlin.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series serial: 8250: dw: RZN1 DMA support | expand

Commit Message

Miquel Raynal April 21, 2022, 9:53 a.m. UTC
UART 0 to 2 do not have DMA support, while UART 3 to 7 do.

Fill the "dmas" and "dma-names" properties for each of these nodes.

Please mind that these nodes go through the dmamux node which will
redirect the requests to the right DMA controller. The first 4 cells of
the "dmas" properties will be transferred as-is to the DMA
controllers. The last 2 cells are consumed by the dmamux. Which means
cell 0 and 4 are almost redundant, one giving the controller request ID
and the other the dmamux channel which is a 1:1 translation of the
request IDs, shifted by 16 when pointing to the second DMA controller.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 arch/arm/boot/dts/r9a06g032.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Geert Uytterhoeven April 28, 2022, 9:09 a.m. UTC | #1
On Thu, Apr 21, 2022 at 11:53 AM Miquel Raynal
<miquel.raynal@bootlin.com> wrote:
> UART 0 to 2 do not have DMA support, while UART 3 to 7 do.
>
> Fill the "dmas" and "dma-names" properties for each of these nodes.
>
> Please mind that these nodes go through the dmamux node which will
> redirect the requests to the right DMA controller. The first 4 cells of
> the "dmas" properties will be transferred as-is to the DMA
> controllers. The last 2 cells are consumed by the dmamux. Which means
> cell 0 and 4 are almost redundant, one giving the controller request ID
> and the other the dmamux channel which is a 1:1 translation of the
> request IDs, shifted by 16 when pointing to the second DMA controller.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Geert Uytterhoeven May 3, 2022, 8:36 a.m. UTC | #2
On Thu, Apr 28, 2022 at 11:09 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Thu, Apr 21, 2022 at 11:53 AM Miquel Raynal
> <miquel.raynal@bootlin.com> wrote:
> > UART 0 to 2 do not have DMA support, while UART 3 to 7 do.
> >
> > Fill the "dmas" and "dma-names" properties for each of these nodes.
> >
> > Please mind that these nodes go through the dmamux node which will
> > redirect the requests to the right DMA controller. The first 4 cells of
> > the "dmas" properties will be transferred as-is to the DMA
> > controllers. The last 2 cells are consumed by the dmamux. Which means
> > cell 0 and 4 are almost redundant, one giving the controller request ID
> > and the other the dmamux channel which is a 1:1 translation of the
> > request IDs, shifted by 16 when pointing to the second DMA controller.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Queuing in renesas-devel for v5.19.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi
index c854aa4cfa77..4288b935fcea 100644
--- a/arch/arm/boot/dts/r9a06g032.dtsi
+++ b/arch/arm/boot/dts/r9a06g032.dtsi
@@ -144,6 +144,9 @@  uart3: serial@50000000 {
 			reg-io-width = <4>;
 			clocks = <&sysctrl R9A06G032_CLK_UART3>, <&sysctrl R9A06G032_HCLK_UART3>;
 			clock-names = "baudclk", "apb_pclk";
+			dmas =  <&dmamux 0 0 0 0 0 1>,
+				<&dmamux 1 0 0 0 1 1>;
+			dma-names = "rx", "tx";
 			status = "disabled";
 		};
 
@@ -155,6 +158,9 @@  uart4: serial@50001000 {
 			reg-io-width = <4>;
 			clocks = <&sysctrl R9A06G032_CLK_UART4>, <&sysctrl R9A06G032_HCLK_UART4>;
 			clock-names = "baudclk", "apb_pclk";
+			dmas =  <&dmamux 2 0 0 0 2 1>,
+				<&dmamux 3 0 0 0 3 1>;
+			dma-names = "rx", "tx";
 			status = "disabled";
 		};
 
@@ -166,6 +172,9 @@  uart5: serial@50002000 {
 			reg-io-width = <4>;
 			clocks = <&sysctrl R9A06G032_CLK_UART5>, <&sysctrl R9A06G032_HCLK_UART5>;
 			clock-names = "baudclk", "apb_pclk";
+			dmas =  <&dmamux 4 0 0 0 4 1>,
+				<&dmamux 5 0 0 0 5 1>;
+			dma-names = "rx", "tx";
 			status = "disabled";
 		};
 
@@ -177,6 +186,9 @@  uart6: serial@50003000 {
 			reg-io-width = <4>;
 			clocks = <&sysctrl R9A06G032_CLK_UART6>, <&sysctrl R9A06G032_HCLK_UART6>;
 			clock-names = "baudclk", "apb_pclk";
+			dmas =  <&dmamux 6 0 0 0 6 1>,
+				<&dmamux 7 0 0 0 7 1>;
+			dma-names = "rx", "tx";
 			status = "disabled";
 		};
 
@@ -188,6 +200,9 @@  uart7: serial@50004000 {
 			reg-io-width = <4>;
 			clocks = <&sysctrl R9A06G032_CLK_UART7>, <&sysctrl R9A06G032_HCLK_UART7>;
 			clock-names = "baudclk", "apb_pclk";
+			dmas =  <&dmamux 4 0 0 0 20 1>,
+				<&dmamux 5 0 0 0 21 1>;
+			dma-names = "rx", "tx";
 			status = "disabled";
 		};