| Message ID | 20220518172808.1691450-2-ralph.siemsen@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [1/3] clk: renesas: r9a06g032: Fix UART clkgrp bitsel | expand |
Hi Ralph, Thanks for your patch! On 18 May 2022 18:27 Ralph Siemsen wrote: > Minor cleanup, remove unused fields from struct r9a06g032_clkdesc. > > Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org> > --- > drivers/clk/renesas/r9a06g032-clocks.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/renesas/r9a06g032-clocks.c > b/drivers/clk/renesas/r9a06g032-clocks.c > index 0baa6a06ada8..9dbcf9620fa0 100644 > --- a/drivers/clk/renesas/r9a06g032-clocks.c > +++ b/drivers/clk/renesas/r9a06g032-clocks.c > @@ -47,11 +47,9 @@ struct r9a06g032_clkdesc { > struct { > u16 div, mul; > }; > - unsigned int factor; > - unsigned int frequency; > /* for dual gate */ > struct { > - uint16_t group : 1, index: 3; > + uint16_t group : 1; > u16 sel, g1, r1, g2, r2; > } dual; > }; > @@ -84,7 +82,7 @@ struct r9a06g032_clkdesc { > #define D_UGATE(_idx, _n, _src, _g, _gi, _g1, _r1, _g2, _r2) \ > { .type = K_DUALGATE, .index = R9A06G032_##_idx, \ > .source = 1 + R9A06G032_##_src, .name = _n, \ > - .dual = { .group = _g, .index = _gi, \ > + .dual = { .group = _g, \ > .g1 = _g1, .r1 = _r1, .g2 = _g2, .r2 = _r2 }, } > > enum { K_GATE = 0, K_FFC, K_DIV, K_BITSEL, K_DUALGATE }; > -- > 2.25.1 Reviewed-by: Phil Edworthy <phil.edworthy@renesas.com> Thanks Phil
Hi Ralph, On Wed, May 18, 2022 at 7:28 PM Ralph Siemsen <ralph.siemsen@linaro.org> wrote: > Minor cleanup, remove unused fields from struct r9a06g032_clkdesc. > > Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-clk-for-v5.20. > --- a/drivers/clk/renesas/r9a06g032-clocks.c > +++ b/drivers/clk/renesas/r9a06g032-clocks.c > @@ -84,7 +82,7 @@ struct r9a06g032_clkdesc { > #define D_UGATE(_idx, _n, _src, _g, _gi, _g1, _r1, _g2, _r2) \ > { .type = K_DUALGATE, .index = R9A06G032_##_idx, \ > .source = 1 + R9A06G032_##_src, .name = _n, \ > - .dual = { .group = _g, .index = _gi, \ > + .dual = { .group = _g, \ My first reaction was: this makes _gi unused. Then I noticed you handle that in your next patch. I'll merge them into a single commit while applying. > .g1 = _g1, .r1 = _r1, .g2 = _g2, .r2 = _r2 }, } > > enum { K_GATE = 0, K_FFC, K_DIV, K_BITSEL, K_DUALGATE }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/clk/renesas/r9a06g032-clocks.c b/drivers/clk/renesas/r9a06g032-clocks.c index 0baa6a06ada8..9dbcf9620fa0 100644 --- a/drivers/clk/renesas/r9a06g032-clocks.c +++ b/drivers/clk/renesas/r9a06g032-clocks.c @@ -47,11 +47,9 @@ struct r9a06g032_clkdesc { struct { u16 div, mul; }; - unsigned int factor; - unsigned int frequency; /* for dual gate */ struct { - uint16_t group : 1, index: 3; + uint16_t group : 1; u16 sel, g1, r1, g2, r2; } dual; }; @@ -84,7 +82,7 @@ struct r9a06g032_clkdesc { #define D_UGATE(_idx, _n, _src, _g, _gi, _g1, _r1, _g2, _r2) \ { .type = K_DUALGATE, .index = R9A06G032_##_idx, \ .source = 1 + R9A06G032_##_src, .name = _n, \ - .dual = { .group = _g, .index = _gi, \ + .dual = { .group = _g, \ .g1 = _g1, .r1 = _r1, .g2 = _g2, .r2 = _r2 }, } enum { K_GATE = 0, K_FFC, K_DIV, K_BITSEL, K_DUALGATE };
Minor cleanup, remove unused fields from struct r9a06g032_clkdesc. Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org> --- drivers/clk/renesas/r9a06g032-clocks.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)