[v3] arm64: dts: renesas: rzv2m evk: Enable ethernet

Commit Message

Phil Edworthy May 20, 2022, 10:07 a.m. UTC

Enable Ethernet interface on RZ/V2M EVK.

Signed-off-by: Phil Edworthy <[e-mail]>
Reviewed-by: Biju Das <[e-mail]>
---
v3:
 - Fix PHY id
v2:
 - No change
---
 arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Geert Uytterhoeven May 20, 2022, 11:57 a.m. UTC | #1

On Fri, May 20, 2022 at 12:07 PM Phil Edworthy
<[e-mail]> wrote:
> Enable Ethernet interface on RZ/V2M EVK.
>
> Signed-off-by: Phil Edworthy <[e-mail]>
> Reviewed-by: Biju Das <[e-mail]>
> ---
> v3:
>  - Fix PHY id

Reviewed-by: Geert Uytterhoeven <[e-mail]>
i.e. will queue in renesas-devel for v5.20.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [e-mail]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

kernel test robot May 21, 2022, 8:34 p.m. UTC | #2

Hi Phil,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on geert-renesas-devel/next]
[cannot apply to krzk/for-next v5.18-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Phil-Edworthy/arm64-dts-renesas-rzv2m-evk-Enable-ethernet/20220520-180929
base:   https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-devel.git next
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20220522/[e-mail]/config)
compiler: aarch64-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/bae3dc745b58471823c22e98b6dbfb0ef17e213a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Phil-Edworthy/arm64-dts-renesas-rzv2m-evk-Enable-ethernet/20220520-180929
        git checkout bae3dc745b58471823c22e98b6dbfb0ef17e213a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <[e-mail]>

All errors (new ones prefixed by >>):

>> Error: arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts:47.1-5 Label or path avb not found
   FATAL ERROR: Syntax error parsing input tree

Patch

diff --git a/arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts b/arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts
index c207d8ce5523..1e6e805085bf 100644
--- a/arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts
+++ b/arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts
@@ -14,6 +14,7 @@  / {
 
 	aliases {
 		serial0 = &uart0;
+		ethernet0 = &avb;
 	};
 
 	chosen {
@@ -42,3 +43,16 @@  &extal_clk {
 &uart0 {
 	status = "okay";
 };
+
+&avb {
+	renesas,no-ether-link;
+	phy-handle = <&phy0>;
+	phy-mode = "gmii";
+	status = "okay";
+
+	phy0: ethernet-phy@0 {
+		compatible = "ethernet-phy-id001c.c916",
+			     "ethernet-phy-ieee802.3-c22";
+		reg = <0>;
+	};
+};