diff mbox series

[2/2] watchdog: rzg2l_wdt: Add rzv2m compatible string

Message ID 20220607135619.174110-3-phil.edworthy@renesas.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series arm64: renesas: Add RZ/V2M watchdog support | expand

Commit Message

Phil Edworthy June 7, 2022, 1:56 p.m. UTC 
The WDT on RZ/V2M devices is basically the same as RZ/G2L, with the
exception that the RZ/V2M has a single combined interrupt, whereas the
RZ/G2L has time out and error interrupts.

Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/watchdog/rzg2l_wdt.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Geert Uytterhoeven June 9, 2022, 10:11 a.m. UTC | #1 
Hi Phil,

Thanks for your patch!

On Tue, Jun 7, 2022 at 3:59 PM Phil Edworthy <phil.edworthy@renesas.com> wrote:
> The WDT on RZ/V2M devices is basically the same as RZ/G2L, with the
> exception that the RZ/V2M has a single combined interrupt, whereas the
> RZ/G2L has time out and error interrupts.

... and that the RZ/V2M watchdog does not have the parity error
handling.

> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

> --- a/drivers/watchdog/rzg2l_wdt.c
> +++ b/drivers/watchdog/rzg2l_wdt.c
> @@ -256,6 +256,7 @@ static int rzg2l_wdt_probe(struct platform_device *pdev)
>
>  static const struct of_device_id rzg2l_wdt_ids[] = {
>         { .compatible = "renesas,rzg2l-wdt", },
> +       { .compatible = "renesas,rzv2m-wdt", },

Hence this is not sufficient, as you need to prevent writing to the
parity registers on RZ/V2M.

>         { /* sentinel */ }
>  };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Phil Edworthy June 10, 2022, 6:55 a.m. UTC | #2 
Hi Geert,

On 09 June 2022 11:11 Geert Uytterhoeven wrote:
> On Tue, Jun 7, 2022 at 3:59 PM Phil wrote:
> > The WDT on RZ/V2M devices is basically the same as RZ/G2L, with the
> > exception that the RZ/V2M has a single combined interrupt, whereas the
> > RZ/G2L has time out and error interrupts.
> 
> ... and that the RZ/V2M watchdog does not have the parity error
> handling.
> 
> > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> 
> > --- a/drivers/watchdog/rzg2l_wdt.c
> > +++ b/drivers/watchdog/rzg2l_wdt.c
> > @@ -256,6 +256,7 @@ static int rzg2l_wdt_probe(struct platform_device
> *pdev)
> >
> >  static const struct of_device_id rzg2l_wdt_ids[] = {
> >         { .compatible = "renesas,rzg2l-wdt", },
> > +       { .compatible = "renesas,rzv2m-wdt", },
> 
> Hence this is not sufficient, as you need to prevent writing to the
> parity registers on RZ/V2M.

Oops, thanks for the review and noticing this.

Phil
diff mbox series

Patch

diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c
index 6eea0ee4af49..cee3eef7cc47 100644
--- a/drivers/watchdog/rzg2l_wdt.c
+++ b/drivers/watchdog/rzg2l_wdt.c
@@ -256,6 +256,7 @@  static int rzg2l_wdt_probe(struct platform_device *pdev)
 
 static const struct of_device_id rzg2l_wdt_ids[] = {
 	{ .compatible = "renesas,rzg2l-wdt", },
+	{ .compatible = "renesas,rzv2m-wdt", },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, rzg2l_wdt_ids);