| Message ID | 20220622173614.12778-3-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | mmc: renesas_sdhi: Trivial fixes | expand |
Hi Prabhakar, On Wed, Jun 22, 2022 at 7:36 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Fix typo's, > * difference -> different > * alignment -> aligned > > While at it replaced 128-bytes -> 128 byte. > > Reported-by: Pavel Machek <pavel@denx.de> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c > +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c > @@ -355,7 +355,7 @@ renesas_sdhi_internal_dmac_map(struct tmio_mmc_host *host, > > data->host_cookie = cookie; > > - /* This DMAC cannot handle if buffer is not 128-bytes alignment */ > + /* This DMAC cannot handle if buffer is not 128 byte aligned */ 128-byte? ;-) > if (!IS_ALIGNED(sg_dma_address(data->sg), 128)) { > renesas_sdhi_internal_dmac_unmap(host, data, cookie); > return false; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thank you for the review. On Wed, Jun 22, 2022 at 7:11 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Wed, Jun 22, 2022 at 7:36 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > Fix typo's, > > * difference -> different > > * alignment -> aligned > > > > While at it replaced 128-bytes -> 128 byte. > > > > Reported-by: Pavel Machek <pavel@denx.de> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Thanks for your patch! > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c > > +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c > > @@ -355,7 +355,7 @@ renesas_sdhi_internal_dmac_map(struct tmio_mmc_host *host, > > > > data->host_cookie = cookie; > > > > - /* This DMAC cannot handle if buffer is not 128-bytes alignment */ > > + /* This DMAC cannot handle if buffer is not 128 byte aligned */ > > 128-byte? ;-) > In the previous version of the patch Wolfram never came back on your reply, so I went with 128 byte instead. Cheers, Prabhakar
> > > - /* This DMAC cannot handle if buffer is not 128-bytes alignment */ > > > + /* This DMAC cannot handle if buffer is not 128 byte aligned */ > > > > 128-byte? ;-) > > > In the previous version of the patch Wolfram never came back on your > reply, so I went with 128 byte instead. I hoped for a native speaker to chime in. I don't care about the '-' but maybe we should rephrase it to: /* This DMAC needs buffers to be 128-byte aligned */ ?
Hi Wolfram, On Wed, Jun 22, 2022 at 8:09 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > > > > > - /* This DMAC cannot handle if buffer is not 128-bytes alignment */ > > > > + /* This DMAC cannot handle if buffer is not 128 byte aligned */ > > > > > > 128-byte? ;-) > > > > > In the previous version of the patch Wolfram never came back on your > > reply, so I went with 128 byte instead. > > I hoped for a native speaker to chime in. I don't care about the '-' but > maybe we should rephrase it to: > > /* This DMAC needs buffers to be 128-byte aligned */ > > ? Fine by me, will update and resend a v3. Cheers, Prabhakar
diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c index 3084b15ae2cb..4eb65b3c36bb 100644 --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c @@ -321,7 +321,7 @@ renesas_sdhi_internal_dmac_dataend_dma(struct tmio_mmc_host *host) } /* - * renesas_sdhi_internal_dmac_map() will be called with two difference + * renesas_sdhi_internal_dmac_map() will be called with two different * sg pointers in two mmc_data by .pre_req(), but tmio host can have a single * sg_ptr only. So, renesas_sdhi_internal_dmac_{un}map() should use a sg * pointer in a mmc_data instead of host->sg_ptr. @@ -355,7 +355,7 @@ renesas_sdhi_internal_dmac_map(struct tmio_mmc_host *host, data->host_cookie = cookie; - /* This DMAC cannot handle if buffer is not 128-bytes alignment */ + /* This DMAC cannot handle if buffer is not 128 byte aligned */ if (!IS_ALIGNED(sg_dma_address(data->sg), 128)) { renesas_sdhi_internal_dmac_unmap(host, data, cookie); return false;
Fix typo's, * difference -> different * alignment -> aligned While at it replaced 128-bytes -> 128 byte. Reported-by: Pavel Machek <pavel@denx.de> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- drivers/mmc/host/renesas_sdhi_internal_dmac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)